| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6cda7972-d21d-5e7a-3122-0d3420e2ae42 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0B6:29B0B8:19EB578:256FC4D:6A58C8CA |
| html-safe-nonce | 1ba572dc788e5a9953f354c0f5032f8633a65dabc31288d6581a6685488f29a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEI2OjI5QjBCODoxOUVCNTc4OjI1NkZDNEQ6NkE1OEM4Q0EiLCJ2aXNpdG9yX2lkIjoiNjg4Mjc4NDgxNDE3NDg4MTk5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b095b6407a93d8942eb32c94f2c1cd4576b0623a75adeb3791a8aebaa38ec152 |
| hovercard-subject-tag | pull_request:506962355 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2297/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/61ef7868991a618d4652abcf0ae8199041b9886e85b2c2d5e64debb210a56845/RustPython/RustPython/pull/2297 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61ef7868991a618d4652abcf0ae8199041b9886e85b2c2d5e64debb210a56845/RustPython/RustPython/pull/2297 |
| og:image:alt | This is sort of a big lump change, and there aren't necessarily tests to prove it, since there aren't any tests in test_struct.py that verify the native ordering -- even though there's ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | coolreader18 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/2297#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2297 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2297 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/2297 |
| Reload | https://github.com/RustPython/RustPython/pull/2297 |
| Reload | https://github.com/RustPython/RustPython/pull/2297 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
287
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
101
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| coolreader18 | https://github.com/coolreader18 |
| master | https://github.com/RustPython/RustPython/tree/master |
| coolreader18/rework-pystruct | https://github.com/RustPython/RustPython/tree/coolreader18/rework-pystruct |
| Conversation | https://github.com/RustPython/RustPython/pull/2297 |
| Commits3 (3) | https://github.com/RustPython/RustPython/pull/2297/commits |
| Checks | https://github.com/RustPython/RustPython/pull/2297/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/2297/files |
| Update pystruct + array | https://github.com/RustPython/RustPython/pull/2297#top |
| coolreader18 | https://github.com/coolreader18 |
| master | https://github.com/RustPython/RustPython/tree/master |
| coolreader18/rework-pystruct | https://github.com/RustPython/RustPython/tree/coolreader18/rework-pystruct |
|
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Oct 20, 2020 | https://github.com/RustPython/RustPython/pull/2297#issue-725782044 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Oct 26, 2020 | https://github.com/RustPython/RustPython/pull/2297#issuecomment-716296533 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| @qingshi163 | https://github.com/qingshi163 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| Oct 26, 2020 | https://github.com/RustPython/RustPython/pull/2297#issuecomment-716509251 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
|
Oct 26, 2020
| https://github.com/RustPython/RustPython/pull/2297#pullrequestreview-516726805 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/2297/files |
| vm/src/stdlib/pystruct.rs | https://github.com/RustPython/RustPython/pull/2297/files#diff-7aa53b8b38a644b88a0d8d949c648e30ce3a426ef6613d72adc2253a16357702 |
| qingshi163 | https://github.com/qingshi163 |
| Oct 26, 2020 | https://github.com/RustPython/RustPython/pull/2297#discussion_r511922098 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| coolreader18 | https://github.com/coolreader18 |
| Oct 26, 2020 | https://github.com/RustPython/RustPython/pull/2297#discussion_r512028970 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| coolreader18 | https://github.com/coolreader18 |
| Oct 26, 2020 | https://github.com/RustPython/RustPython/pull/2297#discussion_r512031339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2309 | https://github.com/RustPython/RustPython/pull/2309 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
| coolreader18 | https://github.com/coolreader18 |
| October 26, 2020 12:13 | https://github.com/RustPython/RustPython/pull/2297#commits-pushed-0f84bd4 |
|
| https://github.com/coolreader18 |
| Update pystruct + array | https://github.com/RustPython/RustPython/pull/2297/commits/0f84bd4070073fcb99d6d02f9aeecb26402db09f |
| 0f84bd4 | https://github.com/RustPython/RustPython/pull/2297/commits/0f84bd4070073fcb99d6d02f9aeecb26402db09f |
|
| https://github.com/coolreader18 |
| Use a static type for struct.error | https://github.com/RustPython/RustPython/pull/2297/commits/59169aa2ce51e5e6b35217fe306327b806198560 |
| 59169aa | https://github.com/RustPython/RustPython/pull/2297/commits/59169aa2ce51e5e6b35217fe306327b806198560 |
|
| https://github.com/coolreader18 |
| Use std::os::raw::c_* instead of libc::c_* for wasm compat | https://github.com/RustPython/RustPython/pull/2297/commits/026f396e983691bb2e1d0fcdaa9664d93729e876 |
| 026f396 | https://github.com/RustPython/RustPython/pull/2297/commits/026f396e983691bb2e1d0fcdaa9664d93729e876 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/d6012427ce61ef4ee95bd0c9138871004f573710..026f396e983691bb2e1d0fcdaa9664d93729e876 |
| d601242 | https://github.com/RustPython/RustPython/commit/d6012427ce61ef4ee95bd0c9138871004f573710 |
| 026f396 | https://github.com/RustPython/RustPython/commit/026f396e983691bb2e1d0fcdaa9664d93729e876 |
|
Compare
| https://github.com/RustPython/RustPython/compare/d6012427ce61ef4ee95bd0c9138871004f573710..026f396e983691bb2e1d0fcdaa9664d93729e876 |
| October 26, 2020 17:14 | https://github.com/RustPython/RustPython/pull/2297#event-3921900203 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Oct 27, 2020
| https://github.com/RustPython/RustPython/pull/2297#pullrequestreview-517340524 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/2297/files/026f396e983691bb2e1d0fcdaa9664d93729e876 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| 3c9ad23 | https://github.com/RustPython/RustPython/commit/3c9ad2378bd18bb2febfd29eb6e4ff14a4c21c9d |
| Oct 27, 2020 | https://github.com/RustPython/RustPython/pull/2297#event-3923911110 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| November 7, 2020 21:44 | https://github.com/RustPython/RustPython/pull/2297#event-3970238346 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2297 |
|
| https://github.com/qingshi163 |
|
qingshi163
| https://github.com/qingshi163 |
|
| https://github.com/RustPython/RustPython/pull/2297/files/d6012427ce61ef4ee95bd0c9138871004f573710 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/2297/files/026f396e983691bb2e1d0fcdaa9664d93729e876 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2297 |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
|
| https://github.com/qingshi163 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |