| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86d13406-7fd0-77f0-0c0e-f34894bfe529 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AABE:158E36:403B5FB:56D08E7:69708DD3 |
| html-safe-nonce | 4a077c8fd8d4f74d33fb6c613e4bd950f5b38d07927a6390d7bd8324365b9d15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUJFOjE1OEUzNjo0MDNCNUZCOjU2RDA4RTc6Njk3MDhERDMiLCJ2aXNpdG9yX2lkIjoiNDcwNTc2NTQyNzY4NDM0NzM0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f1ef389c298652b6bb69521d98bcf3f22b1a61b5f386719a4c56c917909a0c13 |
| hovercard-subject-tag | pull_request:412632159 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/1902/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c966629b8ee1073fb4c45f9848a6453179faf3ce8a362fd8ea3a06f7acca112b/RustPython/RustPython/pull/1902 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c966629b8ee1073fb4c45f9848a6453179faf3ce8a362fd8ea3a06f7acca112b/RustPython/RustPython/pull/1902 |
| og:image:alt | This PR implements the dict union as defined in PEP 854 in RustPython and tests it. Compability tests with Cpython are skipped when tested with Python 3.8 or below (due to abvious reason - Githib d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TheAnyKey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/1902#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1902 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1902 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/1902 |
| Reload | https://github.com/RustPython/RustPython/pull/1902 |
| Reload | https://github.com/RustPython/RustPython/pull/1902 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.4k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
21.7k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
276
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
93
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
0
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/RustPython/RustPython/security |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/RustPython/RustPython/pull/1902#issue-comment-box |
| TheAnyKey | https://github.com/TheAnyKey |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| TheAnyKey:TheAnyKey/p39_dict_union | https://github.com/TheAnyKey/RustPython/tree/TheAnyKey/p39_dict_union |
|
Implement P3.9 style dict union (PEP584)
| https://github.com/RustPython/RustPython/pull/1902#top |
| TheAnyKey | https://github.com/TheAnyKey |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| TheAnyKey:TheAnyKey/p39_dict_union | https://github.com/TheAnyKey/RustPython/tree/TheAnyKey/p39_dict_union |
|
Conversation
2
| https://github.com/RustPython/RustPython/pull/1902 |
|
Commits
19
| https://github.com/RustPython/RustPython/pull/1902/commits |
|
Checks
0
| https://github.com/RustPython/RustPython/pull/1902/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/1902/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
|
| https://github.com/TheAnyKey |
| TheAnyKey | https://github.com/TheAnyKey |
| May 3, 2020 | https://github.com/RustPython/RustPython/pull/1902#issue-611457034 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
| TheAnyKey | https://github.com/TheAnyKey |
| April 28, 2020 18:41 | https://github.com/RustPython/RustPython/pull/1902#commits-pushed-94a7b48 |
|
| https://github.com/TheAnyKey |
| added initial implementation of self defining expressions to fstring … | https://github.com/RustPython/RustPython/pull/1902/commits/94a7b485602c5e578d7f593a6769ad7c55ec2612 |
| 94a7b48 | https://github.com/RustPython/RustPython/pull/1902/commits/94a7b485602c5e578d7f593a6769ad7c55ec2612 |
|
| https://github.com/TheAnyKey |
| implemented selfdocumenting fstrings and tests from cpython- current … | https://github.com/RustPython/RustPython/pull/1902/commits/34478d3db7b6482ce21f3f537e71e89bfe01f482 |
| 34478d3 | https://github.com/RustPython/RustPython/pull/1902/commits/34478d3db7b6482ce21f3f537e71e89bfe01f482 |
|
| https://github.com/TheAnyKey |
| minor cleanup | https://github.com/RustPython/RustPython/pull/1902/commits/c25353c083879906a06e711f0a766959f3448f5b |
| c25353c | https://github.com/RustPython/RustPython/pull/1902/commits/c25353c083879906a06e711f0a766959f3448f5b |
|
| https://github.com/TheAnyKey |
| now conversion flags can be followed by a format specifier and added … | https://github.com/RustPython/RustPython/pull/1902/commits/e7ec972ab719c412e6bffc2e06d07d27721521c3 |
| e7ec972 | https://github.com/RustPython/RustPython/pull/1902/commits/e7ec972ab719c412e6bffc2e06d07d27721521c3 |
|
| https://github.com/TheAnyKey |
| fixed qute handling in tests | https://github.com/RustPython/RustPython/pull/1902/commits/972503c3abf13f907bda18e6efd6c39abff6f5fc |
| 972503c | https://github.com/RustPython/RustPython/pull/1902/commits/972503c3abf13f907bda18e6efd6c39abff6f5fc |
|
| https://github.com/TheAnyKey |
| activated further test, removed todos | https://github.com/RustPython/RustPython/pull/1902/commits/8e8e839b946eca8b068873d3549050f4f00ae9d4 |
| 8e8e839 | https://github.com/RustPython/RustPython/pull/1902/commits/8e8e839b946eca8b068873d3549050f4f00ae9d4 |
|
| https://github.com/TheAnyKey |
| fixed fmt | https://github.com/RustPython/RustPython/pull/1902/commits/3ccb117b9a873ff15295ef734ccc015ef18d0413 |
| 3ccb117 | https://github.com/RustPython/RustPython/pull/1902/commits/3ccb117b9a873ff15295ef734ccc015ef18d0413 |
|
| https://github.com/TheAnyKey |
| Removed incompatibilty with CPython, fixed parser error handling | https://github.com/RustPython/RustPython/pull/1902/commits/3e8cde7b9c05189d0b595f084d5555442580346f |
| 3e8cde7 | https://github.com/RustPython/RustPython/pull/1902/commits/3e8cde7b9c05189d0b595f084d5555442580346f |
|
| https://github.com/TheAnyKey |
| fixed clippy; tests fail explicitly for python 3.7 and below | https://github.com/RustPython/RustPython/pull/1902/commits/80a9710aa8157ccb0b06a5f16156432d4cb0d2d0 |
| 80a9710 | https://github.com/RustPython/RustPython/pull/1902/commits/80a9710aa8157ccb0b06a5f16156432d4cb0d2d0 |
|
| https://github.com/TheAnyKey |
| skipping inkompatible test for the moment | https://github.com/RustPython/RustPython/pull/1902/commits/f823af19759c94af37dbd4e6e769e8a7874f246d |
| f823af1 | https://github.com/RustPython/RustPython/pull/1902/commits/f823af19759c94af37dbd4e6e769e8a7874f246d |
|
| https://github.com/TheAnyKey |
| recommit | https://github.com/RustPython/RustPython/pull/1902/commits/620115d69a831d95e744b10231d3520023b4cde7 |
| 620115d | https://github.com/RustPython/RustPython/pull/1902/commits/620115d69a831d95e744b10231d3520023b4cde7 |
|
| https://github.com/TheAnyKey |
| Initial implementation of Py3.9 dict union and python-level tests | https://github.com/RustPython/RustPython/pull/1902/commits/90123df1883585a66ec9094015ce92ba91445f8d |
| 90123df | https://github.com/RustPython/RustPython/pull/1902/commits/90123df1883585a66ec9094015ce92ba91445f8d |
|
| https://github.com/TheAnyKey |
| first complete? implementation. TODO: Cleanup, remove warnings, clipp… | https://github.com/RustPython/RustPython/pull/1902/commits/155f3cadff41706b800e4b0b91dd130f8cfc7041 |
| 155f3ca | https://github.com/RustPython/RustPython/pull/1902/commits/155f3cadff41706b800e4b0b91dd130f8cfc7041 |
|
| https://github.com/TheAnyKey |
| fixed clippy, fmt, warnings, etc.. Improved tests and extended testut… | https://github.com/RustPython/RustPython/pull/1902/commits/9a8b8e7d3cd7cd6447fec268600b3123f445c870 |
| 9a8b8e7 | https://github.com/RustPython/RustPython/pull/1902/commits/9a8b8e7d3cd7cd6447fec268600b3123f445c870 |
|
| https://github.com/TheAnyKey |
| changed reference python version to 3.9 - lets see what happens | https://github.com/RustPython/RustPython/pull/1902/commits/f6f97544361f872bcbfd2576f8ebd60214a48898 |
| f6f9754 | https://github.com/RustPython/RustPython/pull/1902/commits/f6f97544361f872bcbfd2576f8ebd60214a48898 |
|
| https://github.com/TheAnyKey |
| fixed issued in testutils.skip_if_unsupported and testutils.fail_if_u… | https://github.com/RustPython/RustPython/pull/1902/commits/a285474487b17e25d88cf44ea7fcfc5c427126ce |
| a285474 | https://github.com/RustPython/RustPython/pull/1902/commits/a285474487b17e25d88cf44ea7fcfc5c427126ce |
|
| https://github.com/TheAnyKey |
| fixed: returned wrong error when union opration is invoked with other… | https://github.com/RustPython/RustPython/pull/1902/commits/41849ab531eecbf7204996e8c9eed2651ef3888c |
| 41849ab | https://github.com/RustPython/RustPython/pull/1902/commits/41849ab531eecbf7204996e8c9eed2651ef3888c |
|
| https://github.com/TheAnyKey |
| reverted toolchain settings to python version 3.8 as 3.9 is so far no… | https://github.com/RustPython/RustPython/pull/1902/commits/1697ce05ad136a6b566dcb06a13df6699a20a942 |
| 1697ce0 | https://github.com/RustPython/RustPython/pull/1902/commits/1697ce05ad136a6b566dcb06a13df6699a20a942 |
|
| https://github.com/TheAnyKey |
| fixed typo | https://github.com/RustPython/RustPython/pull/1902/commits/0faf968678a1e1f8f1908b09eb7e2e54c5640677 |
| 0faf968 | https://github.com/RustPython/RustPython/pull/1902/commits/0faf968678a1e1f8f1908b09eb7e2e54c5640677 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 7, 2020
| https://github.com/RustPython/RustPython/pull/1902#pullrequestreview-407748611 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/1902/files/0faf968678a1e1f8f1908b09eb7e2e54c5640677 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/1902#pullrequestreview-407748611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| May 8, 2020 | https://github.com/RustPython/RustPython/pull/1902#issuecomment-625615713 |
| #1911 | https://github.com/RustPython/RustPython/pull/1911 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| May 8, 2020 | https://github.com/RustPython/RustPython/pull/1902#event-3315473730 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1902 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/1902/files/0faf968678a1e1f8f1908b09eb7e2e54c5640677 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1902 |
|
| https://github.com/TheAnyKey |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |