| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1bb9c619-fe33-82d5-3a01-aed860cd150d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AACE:29B0B8:194D05E:248CABE:6A58C636 |
| html-safe-nonce | a112e782985ff2562cd85a64622cfb05f919f3bfd6681ffff88f49750c076451 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUNFOjI5QjBCODoxOTREMDVFOjI0OENBQkU6NkE1OEM2MzYiLCJ2aXNpdG9yX2lkIjoiNjQzMjkyOTg0OTM5NzUyODExOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7287432c1ca7d7b2634725a039d0bc8edaed574fc18c066850b2de67f3b8f761 |
| hovercard-subject-tag | pull_request:370006800 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/1738/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/193bc8a3bd5f88d6ebf9a7e9dfa832bc4b552985ffe95ffe77f13c2329e70ffd/RustPython/RustPython/pull/1738 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/193bc8a3bd5f88d6ebf9a7e9dfa832bc4b552985ffe95ffe77f13c2329e70ffd/RustPython/RustPython/pull/1738 |
| og:image:alt | Add getset_descriptor
Remove PyReadOnlyProperty
#[pyproperty] now generates getset. PyProperty is only used for python code. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/1738#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1738 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1738 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/1738 |
| Reload | https://github.com/RustPython/RustPython/pull/1738 |
| Reload | https://github.com/RustPython/RustPython/pull/1738 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
287
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
101
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| youknowone:getset | https://github.com/youknowone/RustPython/tree/getset |
| Conversation | https://github.com/RustPython/RustPython/pull/1738 |
| Commits10 (10) | https://github.com/RustPython/RustPython/pull/1738/commits |
| Checks | https://github.com/RustPython/RustPython/pull/1738/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/1738/files |
| Add getset_descriptor | https://github.com/RustPython/RustPython/pull/1738#top |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| youknowone:getset | https://github.com/youknowone/RustPython/tree/getset |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 2, 2020 | https://github.com/RustPython/RustPython/pull/1738#issue-558691418 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Feb 2, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-581148925 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 3, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-581234871 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/cdcec67a08ab8b9bd0a6cdcf896a4ccc7b361553..ced24236e7623b57a0c5c4cfe85325e238e2e56d |
| cdcec67 | https://github.com/RustPython/RustPython/commit/cdcec67a08ab8b9bd0a6cdcf896a4ccc7b361553 |
| ced2423 | https://github.com/RustPython/RustPython/commit/ced24236e7623b57a0c5c4cfe85325e238e2e56d |
|
Compare
| https://github.com/RustPython/RustPython/compare/cdcec67a08ab8b9bd0a6cdcf896a4ccc7b361553..ced24236e7623b57a0c5c4cfe85325e238e2e56d |
| February 3, 2020 16:56 | https://github.com/RustPython/RustPython/pull/1738#event-3003002717 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Feb 3, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-581546010 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 3, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-581548691 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/451fc24c1d3cec6422b59e7ab5216432ad8b00e3..4eca2b09cbf0621a344173c782180645ce25e2f6 |
| 451fc24 | https://github.com/RustPython/RustPython/commit/451fc24c1d3cec6422b59e7ab5216432ad8b00e3 |
| 4eca2b0 | https://github.com/RustPython/RustPython/commit/4eca2b09cbf0621a344173c782180645ce25e2f6 |
|
Compare
| https://github.com/RustPython/RustPython/compare/451fc24c1d3cec6422b59e7ab5216432ad8b00e3..4eca2b09cbf0621a344173c782180645ce25e2f6 |
| February 3, 2020 20:06 | https://github.com/RustPython/RustPython/pull/1738#event-3003614335 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Feb 4, 2020
| https://github.com/RustPython/RustPython/pull/1738#pullrequestreview-352687862 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/1738/files |
| vm/src/obj/objgetset.rs | https://github.com/RustPython/RustPython/pull/1738/files#diff-eb334cc5c414541a06b1e006008d9b411b362b02f06759633b22d7c177c4b02e |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/876d46815018c6ae6f05874e468b260734a2e242..2bce24282093be3bacdd6b4139331b8484811e95 |
| 876d468 | https://github.com/RustPython/RustPython/commit/876d46815018c6ae6f05874e468b260734a2e242 |
| 2bce242 | https://github.com/RustPython/RustPython/commit/2bce24282093be3bacdd6b4139331b8484811e95 |
|
Compare
| https://github.com/RustPython/RustPython/compare/876d46815018c6ae6f05874e468b260734a2e242..2bce24282093be3bacdd6b4139331b8484811e95 |
| February 5, 2020 15:17 | https://github.com/RustPython/RustPython/pull/1738#event-3010401476 |
|
| https://github.com/youknowone |
| Add getset_descriptor | https://github.com/RustPython/RustPython/pull/1738/commits/9f5cd17f2bc296ddf97c4e8311000234f8222d43 |
| 9f5cd17 | https://github.com/RustPython/RustPython/pull/1738/commits/9f5cd17f2bc296ddf97c4e8311000234f8222d43 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/07a6bba0cb42c025526b68c34d37e8fff0d4c4a6..7626f137afd6bb37250c96ad8f44b8ea4393539e |
| 07a6bba | https://github.com/RustPython/RustPython/commit/07a6bba0cb42c025526b68c34d37e8fff0d4c4a6 |
| 7626f13 | https://github.com/RustPython/RustPython/commit/7626f137afd6bb37250c96ad8f44b8ea4393539e |
|
Compare
| https://github.com/RustPython/RustPython/compare/07a6bba0cb42c025526b68c34d37e8fff0d4c4a6..7626f137afd6bb37250c96ad8f44b8ea4393539e |
| February 5, 2020 16:29 | https://github.com/RustPython/RustPython/pull/1738#event-3010695216 |
| youknowone | https://github.com/youknowone |
| February 6, 2020 01:46 | https://github.com/RustPython/RustPython/pull/1738#commits-pushed-c3d5f6c |
|
| https://github.com/youknowone |
| IntoPyGetterFunc, IntoPySetterFunc | https://github.com/RustPython/RustPython/pull/1738/commits/c3d5f6c14598be14bee72d2f1ec5405566d6e735 |
| c3d5f6c | https://github.com/RustPython/RustPython/pull/1738/commits/c3d5f6c14598be14bee72d2f1ec5405566d6e735 |
|
| https://github.com/youknowone |
| &self support for getter/setter | https://github.com/RustPython/RustPython/pull/1738/commits/ca557788c8d9330079cfadd05798feeeb5fe57f0 |
| ca55778 | https://github.com/RustPython/RustPython/pull/1738/commits/ca557788c8d9330079cfadd05798feeeb5fe57f0 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/556a9198e526a21501277b13eb03d8e7a3b088e3..5b270b43156fa31a7e715d074531628424d2608a |
| 556a919 | https://github.com/RustPython/RustPython/commit/556a9198e526a21501277b13eb03d8e7a3b088e3 |
| 5b270b4 | https://github.com/RustPython/RustPython/commit/5b270b43156fa31a7e715d074531628424d2608a |
|
Compare
| https://github.com/RustPython/RustPython/compare/556a9198e526a21501277b13eb03d8e7a3b088e3..5b270b43156fa31a7e715d074531628424d2608a |
| February 5, 2020 17:10 | https://github.com/RustPython/RustPython/pull/1738#event-3010853662 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 5, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-582512412 |
| @coolreader18 | https://github.com/coolreader18 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/5b270b43156fa31a7e715d074531628424d2608a..87faff84cdd4a52b44a73dae5381bb0e05050b5d |
| 5b270b4 | https://github.com/RustPython/RustPython/commit/5b270b43156fa31a7e715d074531628424d2608a |
| 87faff8 | https://github.com/RustPython/RustPython/commit/87faff84cdd4a52b44a73dae5381bb0e05050b5d |
|
Compare
| https://github.com/RustPython/RustPython/compare/5b270b43156fa31a7e715d074531628424d2608a..87faff84cdd4a52b44a73dae5381bb0e05050b5d |
| February 5, 2020 17:33 | https://github.com/RustPython/RustPython/pull/1738#event-3010936593 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Feb 5, 2020
| https://github.com/RustPython/RustPython/pull/1738#pullrequestreview-353897701 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/1738/files |
| vm/src/slots.rs | https://github.com/RustPython/RustPython/pull/1738/files#diff-b7f5cb62ddfc4ebdc94a2c5faffafd160643849f68f308e5ab72bce90aa76047 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| vm/src/stdlib/io.rs | https://github.com/RustPython/RustPython/pull/1738/files#diff-3f2165c31ec5cbbb2f501f545c4ee243ccdf312ad4d7ea781716e9243cd945a6 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| youknowone | https://github.com/youknowone |
| February 6, 2020 03:33 | https://github.com/RustPython/RustPython/pull/1738#commits-pushed-d1f9cb4 |
|
| https://github.com/youknowone |
| PySetResult and IntoPySetResult | https://github.com/RustPython/RustPython/pull/1738/commits/d1f9cb4e58762d8084f812b4936f180b0a3ebbe4 |
| d1f9cb4 | https://github.com/RustPython/RustPython/pull/1738/commits/d1f9cb4e58762d8084f812b4936f180b0a3ebbe4 |
|
| https://github.com/youknowone |
| VM polymorphism for getter and setter | https://github.com/RustPython/RustPython/pull/1738/commits/226a2a6cb9f5f71206430a2ef7f5b39135ba6e9f |
| 226a2a6 | https://github.com/RustPython/RustPython/pull/1738/commits/226a2a6cb9f5f71206430a2ef7f5b39135ba6e9f |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/87faff84cdd4a52b44a73dae5381bb0e05050b5d..dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494 |
| 87faff8 | https://github.com/RustPython/RustPython/commit/87faff84cdd4a52b44a73dae5381bb0e05050b5d |
| dadf47d | https://github.com/RustPython/RustPython/commit/dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494 |
|
Compare
| https://github.com/RustPython/RustPython/compare/87faff84cdd4a52b44a73dae5381bb0e05050b5d..dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494 |
| February 5, 2020 18:37 | https://github.com/RustPython/RustPython/pull/1738#event-3011142169 |
|
| https://github.com/youknowone |
| compatiibility for CPytthon descr_check | https://github.com/RustPython/RustPython/pull/1738/commits/23381b9937e6ce241eb17d7ce056483562293340 |
| 23381b9 | https://github.com/RustPython/RustPython/pull/1738/commits/23381b9937e6ce241eb17d7ce056483562293340 |
|
| https://github.com/youknowone |
| pyproperty generates PyGetSet instead of PyProperty | https://github.com/RustPython/RustPython/pull/1738/commits/0aee78de18b3286b522fcc8d4d2d5f6301d98d93 |
| 0aee78d | https://github.com/RustPython/RustPython/pull/1738/commits/0aee78de18b3286b522fcc8d4d2d5f6301d98d93 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494..ada67d95f62572cb354c3b2bd04e0f55556716d5 |
| dadf47d | https://github.com/RustPython/RustPython/commit/dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494 |
| ada67d9 | https://github.com/RustPython/RustPython/commit/ada67d95f62572cb354c3b2bd04e0f55556716d5 |
|
Compare
| https://github.com/RustPython/RustPython/compare/dadf47dc8d72f8f75f9e83f4af092fd8f0d3f494..ada67d95f62572cb354c3b2bd04e0f55556716d5 |
| February 5, 2020 18:43 | https://github.com/RustPython/RustPython/pull/1738#event-3011160090 |
|
| https://github.com/youknowone |
| Remove PropertyBuilder and add new_getset | https://github.com/RustPython/RustPython/pull/1738/commits/facabfee1ac0ca5f5e2337a2e2aff253ce3810ee |
|
| https://github.com/RustPython/RustPython/commit/facabfee1ac0ca5f5e2337a2e2aff253ce3810ee#comments |
| facabfe | https://github.com/RustPython/RustPython/pull/1738/commits/facabfee1ac0ca5f5e2337a2e2aff253ce3810ee |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/ada67d95f62572cb354c3b2bd04e0f55556716d5..facabfee1ac0ca5f5e2337a2e2aff253ce3810ee |
| ada67d9 | https://github.com/RustPython/RustPython/commit/ada67d95f62572cb354c3b2bd04e0f55556716d5 |
| facabfe | https://github.com/RustPython/RustPython/commit/facabfee1ac0ca5f5e2337a2e2aff253ce3810ee |
|
Compare
| https://github.com/RustPython/RustPython/compare/ada67d95f62572cb354c3b2bd04e0f55556716d5..facabfee1ac0ca5f5e2337a2e2aff253ce3810ee |
| February 5, 2020 18:45 | https://github.com/RustPython/RustPython/pull/1738#event-3011167819 |
| youknowone | https://github.com/youknowone |
| February 6, 2020 03:56 | https://github.com/RustPython/RustPython/pull/1738#commits-pushed-58744df |
|
| https://github.com/youknowone |
| Revert | https://github.com/RustPython/RustPython/pull/1738/commits/58744df1d594fd06a8211b9c3c1014514b1ed230 |
| 08e66b5 | https://github.com/youknowone/RustPython/commit/08e66b5002f3a3a30db72b350b18c61d367ef1fc |
| 58744df | https://github.com/RustPython/RustPython/pull/1738/commits/58744df1d594fd06a8211b9c3c1014514b1ed230 |
|
| https://github.com/youknowone |
| cleanup property and get descriptor codes | https://github.com/RustPython/RustPython/pull/1738/commits/c0b235ed66f80ac71b7a13f76e198c18ea862411 |
| c0b235e | https://github.com/RustPython/RustPython/pull/1738/commits/c0b235ed66f80ac71b7a13f76e198c18ea862411 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 5, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-582558787 |
| #1736 | https://github.com/RustPython/RustPython/pull/1736 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Feb 6, 2020
| https://github.com/RustPython/RustPython/pull/1738#pullrequestreview-354134696 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/1738/files/c0b235ed66f80ac71b7a13f76e198c18ea862411 |
| coolreader18 | https://github.com/coolreader18 |
| https://github.com/RustPython/RustPython/pull/1738#pullrequestreview-354134696 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 6, 2020 | https://github.com/RustPython/RustPython/pull/1738#issuecomment-582691780 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| e7ea486 | https://github.com/RustPython/RustPython/commit/e7ea486749096cf305c1096f95f29fb7c3504f25 |
| Feb 6, 2020 | https://github.com/RustPython/RustPython/pull/1738#event-3012207259 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1738 |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
|
| https://github.com/RustPython/RustPython/pull/1738/files/c0b235ed66f80ac71b7a13f76e198c18ea862411 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1738 |
|
| https://github.com/youknowone |
|
| https://github.com/coolreader18 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |