| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:76f69b6f-85f9-1f8c-8c2b-0af83d4718fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9466:1CDBD:17BF64C:21FE952:6A58F8ED |
| html-safe-nonce | 7fb582dc3757ad0ea93e0a519436ac0df6bfd1be322aa1a60056bd38398a058e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDY2OjFDREJEOjE3QkY2NEM6MjFGRTk1Mjo2QTU4RjhFRCIsInZpc2l0b3JfaWQiOiI0MDI3NjIwNzg3NzkyNDQzNjI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4a67fa71f1c12d87c3eb254cab62b5fea51ffb72b0887215d6f3fa6d912f29e4 |
| hovercard-subject-tag | pull_request:369901365 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/1736/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c8c9df01d3a78507a389089d536a7c4eb2188bb38b1399a65d899d20ba6acd91/RustPython/RustPython/pull/1736 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c8c9df01d3a78507a389089d536a7c4eb2188bb38b1399a65d899d20ba6acd91/RustPython/RustPython/pull/1736 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/1736#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1736 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1736 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/1736 |
| Reload | https://github.com/RustPython/RustPython/pull/1736 |
| Reload | https://github.com/RustPython/RustPython/pull/1736 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1736 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
287
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
100
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| youknowone | https://github.com/youknowone |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| youknowone:revert-none | https://github.com/youknowone/RustPython/tree/revert-none |
| Conversation | https://github.com/RustPython/RustPython/pull/1736 |
| Commits11 (11) | https://github.com/RustPython/RustPython/pull/1736/commits |
| Checks | https://github.com/RustPython/RustPython/pull/1736/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/1736/files |
| (WIP) Revert None property workaround | https://github.com/RustPython/RustPython/pull/1736#top |
| youknowone | https://github.com/youknowone |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| youknowone:revert-none | https://github.com/youknowone/RustPython/tree/revert-none |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 1, 2020 | https://github.com/RustPython/RustPython/pull/1736#issue-558544766 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1736 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 2, 2020 | https://github.com/RustPython/RustPython/pull/1736#event-2999939333 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/9c0aeb66da2f67cf981b6804b072f78e4c8014ba..a06cb3cfc3693fbac18b25e793621853526bc40d |
| 9c0aeb6 | https://github.com/RustPython/RustPython/commit/9c0aeb66da2f67cf981b6804b072f78e4c8014ba |
| a06cb3c | https://github.com/RustPython/RustPython/commit/a06cb3cfc3693fbac18b25e793621853526bc40d |
|
Compare
| https://github.com/RustPython/RustPython/compare/9c0aeb66da2f67cf981b6804b072f78e4c8014ba..a06cb3cfc3693fbac18b25e793621853526bc40d |
| February 2, 2020 14:46 | https://github.com/RustPython/RustPython/pull/1736#event-3000073640 |
| youknowone | https://github.com/youknowone |
| February 6, 2020 01:23 | https://github.com/RustPython/RustPython/pull/1736#commits-pushed-9f5cd17 |
|
| https://github.com/youknowone |
| Add getset_descriptor | https://github.com/RustPython/RustPython/pull/1736/commits/9f5cd17f2bc296ddf97c4e8311000234f8222d43 |
| 9f5cd17 | https://github.com/RustPython/RustPython/pull/1736/commits/9f5cd17f2bc296ddf97c4e8311000234f8222d43 |
|
| https://github.com/youknowone |
| IntoPyGetterFunc, IntoPySetterFunc | https://github.com/RustPython/RustPython/pull/1736/commits/c3d5f6c14598be14bee72d2f1ec5405566d6e735 |
| c3d5f6c | https://github.com/RustPython/RustPython/pull/1736/commits/c3d5f6c14598be14bee72d2f1ec5405566d6e735 |
|
| https://github.com/youknowone |
| &self support for getter/setter | https://github.com/RustPython/RustPython/pull/1736/commits/ca557788c8d9330079cfadd05798feeeb5fe57f0 |
| ca55778 | https://github.com/RustPython/RustPython/pull/1736/commits/ca557788c8d9330079cfadd05798feeeb5fe57f0 |
|
| https://github.com/youknowone |
| PySetResult and IntoPySetResult | https://github.com/RustPython/RustPython/pull/1736/commits/a5c7a699f0df94ea344af580a4e7b35f56df54b6 |
| a5c7a69 | https://github.com/RustPython/RustPython/pull/1736/commits/a5c7a699f0df94ea344af580a4e7b35f56df54b6 |
|
| https://github.com/youknowone |
| More PySetResult | https://github.com/RustPython/RustPython/pull/1736/commits/71a3283342631220a8d1adee80c0d4a1b3007f8f |
| 71a3283 | https://github.com/RustPython/RustPython/pull/1736/commits/71a3283342631220a8d1adee80c0d4a1b3007f8f |
|
| https://github.com/youknowone |
| VM polymorphism for getter and setter | https://github.com/RustPython/RustPython/pull/1736/commits/f696c85dd117b8b1b08e45cd4f74ffefc1c7ea1f |
| f696c85 | https://github.com/RustPython/RustPython/pull/1736/commits/f696c85dd117b8b1b08e45cd4f74ffefc1c7ea1f |
|
| https://github.com/youknowone |
| compatiibility for CPytthon descr_check | https://github.com/RustPython/RustPython/pull/1736/commits/18426bac5a00dcc05ed01e67ccc63c0d6d6af2a0 |
| 18426ba | https://github.com/RustPython/RustPython/pull/1736/commits/18426bac5a00dcc05ed01e67ccc63c0d6d6af2a0 |
|
| https://github.com/youknowone |
| pyproperty generates PyGetSet instead of PyProperty | https://github.com/RustPython/RustPython/pull/1736/commits/5d6c82d432459a93ecc83e26f8e212784df6d869 |
| 5d6c82d | https://github.com/RustPython/RustPython/pull/1736/commits/5d6c82d432459a93ecc83e26f8e212784df6d869 |
|
| https://github.com/youknowone |
| Remove PropertyBuilder and add new_getset | https://github.com/RustPython/RustPython/pull/1736/commits/87faff84cdd4a52b44a73dae5381bb0e05050b5d |
| 87faff8 | https://github.com/RustPython/RustPython/pull/1736/commits/87faff84cdd4a52b44a73dae5381bb0e05050b5d |
|
| https://github.com/youknowone |
| Revert | https://github.com/RustPython/RustPython/pull/1736/commits/372f3d40abc1775cfcdda9e4b595fcf99b6c2615 |
| 08e66b5 | https://github.com/youknowone/RustPython/commit/08e66b5002f3a3a30db72b350b18c61d367ef1fc |
| 372f3d4 | https://github.com/RustPython/RustPython/pull/1736/commits/372f3d40abc1775cfcdda9e4b595fcf99b6c2615 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/a06cb3cfc3693fbac18b25e793621853526bc40d..1fcd08f78cadaa65707d85f380a033d371755a1b |
| a06cb3c | https://github.com/RustPython/RustPython/commit/a06cb3cfc3693fbac18b25e793621853526bc40d |
| 1fcd08f | https://github.com/RustPython/RustPython/commit/1fcd08f78cadaa65707d85f380a033d371755a1b |
|
Compare
| https://github.com/RustPython/RustPython/compare/a06cb3cfc3693fbac18b25e793621853526bc40d..1fcd08f78cadaa65707d85f380a033d371755a1b |
| February 5, 2020 17:53 | https://github.com/RustPython/RustPython/pull/1736#event-3011000072 |
|
| https://github.com/youknowone |
| cleanup property and get descriptor codes | https://github.com/RustPython/RustPython/pull/1736/commits/f5c5bd3ddac59a5431863ca8af8f69e1a751d4c6 |
| f5c5bd3 | https://github.com/RustPython/RustPython/pull/1736/commits/f5c5bd3ddac59a5431863ca8af8f69e1a751d4c6 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/1fcd08f78cadaa65707d85f380a033d371755a1b..f5c5bd3ddac59a5431863ca8af8f69e1a751d4c6 |
| 1fcd08f | https://github.com/RustPython/RustPython/commit/1fcd08f78cadaa65707d85f380a033d371755a1b |
| f5c5bd3 | https://github.com/RustPython/RustPython/commit/f5c5bd3ddac59a5431863ca8af8f69e1a751d4c6 |
|
Compare
| https://github.com/RustPython/RustPython/compare/1fcd08f78cadaa65707d85f380a033d371755a1b..f5c5bd3ddac59a5431863ca8af8f69e1a751d4c6 |
| February 5, 2020 18:03 | https://github.com/RustPython/RustPython/pull/1736#event-3011032848 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Feb 5, 2020 | https://github.com/RustPython/RustPython/pull/1736#event-3011207590 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| February 5, 2020 18:57 | https://github.com/RustPython/RustPython/pull/1736#event-3011207812 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Feb 5, 2020
| https://github.com/RustPython/RustPython/pull/1736#ref-pullrequest-558691418 |
|
Add getset_descriptor
#1738
| https://github.com/RustPython/RustPython/pull/1738 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1736 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1736 |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |