Title: objstr::get_value -> objstr::clone_value by youknowone · Pull Request #1654 · RustPython/RustPython · GitHub
Open Graph Title: objstr::get_value -> objstr::clone_value by youknowone · Pull Request #1654 · RustPython/RustPython
X Title: objstr::get_value -> objstr::clone_value by youknowone · Pull Request #1654 · RustPython/RustPython
Description: because the previous naming gives unclear performance estimation to users especially comparing to objstr::borrow_value. I also suggest one of below: Rename objstr::borrow_value -> objstr::get_value as current expectation. Rename get_values of non-copying types into borrow_value and clone_value. For now, there are bytes, int, range and tuple.
Open Graph Description: because the previous naming gives unclear performance estimation to users especially comparing to objstr::borrow_value. I also suggest one of below: Rename objstr::borrow_value -> objstr::get_v...
X Description: because the previous naming gives unclear performance estimation to users especially comparing to objstr::borrow_value. I also suggest one of below: Rename objstr::borrow_value -> objstr::g...
Opengraph URL: https://github.com/RustPython/RustPython/pull/1654
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:54f5ba8d-73b9-95fe-2d0c-5f288521a765 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 97D6:2CDEE4:5858B2:754719:6A592F03 |
| html-safe-nonce | c605f2afb2490ac3838c40715cfe483e5c609e7426c8d8c46d67678702fab07a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0Q2OjJDREVFNDo1ODU4QjI6NzU0NzE5OjZBNTkyRjAzIiwidmlzaXRvcl9pZCI6IjgzODcyODA4Mzk3MDk4OTY0NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0a8a884d13d39e3d641a52b6ba5d2c8556438f0b4627f99ce90dd7598c56e0c2 |
| hovercard-subject-tag | pull_request:358612933 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/1654/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | because the previous naming gives unclear performance estimation to users especially comparing to objstr::borrow_value. I also suggest one of below: Rename objstr::borrow_value -> objstr::get_v... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9713946e7d87c4b631b5230769f749551d20527cc4872e8f1d2ec6a11bead090 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 858568d2992d2e6aac25cc4ebf5b46c83bbfd745 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width