| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5fa78528-228d-fa7f-3d25-965a7d1f3c25 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9720:16768B:30C945:41FCD1:6A5A6FEB |
| html-safe-nonce | de7304e42b72b3dc2215e59745f2b2e246f8bec9a63608bca27f32ce39ec9ecd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzIwOjE2NzY4QjozMEM5NDU6NDFGQ0QxOjZBNUE2RkVCIiwidmlzaXRvcl9pZCI6IjI2NzMyMjcyNTA3MDgxNDgyMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9807549068d85d3598fc079ca2fe64d787873538234940634bfbdca9cb6d6cce |
| hovercard-subject-tag | pull_request:332800058 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/1572/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12047c6f4f3cde4867456370a762200a072034ec4d857dbb8c92d0ae78894a4c/RustPython/RustPython/pull/1572 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12047c6f4f3cde4867456370a762200a072034ec4d857dbb8c92d0ae78894a4c/RustPython/RustPython/pull/1572 |
| og:image:alt | Also adds socket.py from CPython 3.6.0 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | coolreader18 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 922bdba685ea48400234d557977f0e32d9adbae6f5125725b4f48cacc6801106 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0437efb828a4041956ce45d1f7fe69fff38926c7 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/1572#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1572 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1572 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/1572 |
| Reload | https://github.com/RustPython/RustPython/pull/1572 |
| Reload | https://github.com/RustPython/RustPython/pull/1572 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
290
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
105
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| coolreader18 | https://github.com/coolreader18 |
| master | https://github.com/RustPython/RustPython/tree/master |
| coolreader18/socket-socket2 | https://github.com/RustPython/RustPython/tree/coolreader18/socket-socket2 |
| Conversation | https://github.com/RustPython/RustPython/pull/1572 |
| Commits8 (8) | https://github.com/RustPython/RustPython/pull/1572/commits |
| Checks | https://github.com/RustPython/RustPython/pull/1572/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/1572/files |
| Update _socket to use the socket2 crate; similar to the C sockets api | https://github.com/RustPython/RustPython/pull/1572#top |
| coolreader18 | https://github.com/coolreader18 |
| master | https://github.com/RustPython/RustPython/tree/master |
| coolreader18/socket-socket2 | https://github.com/RustPython/RustPython/tree/coolreader18/socket-socket2 |
|
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Oct 26, 2019 | https://github.com/RustPython/RustPython/pull/1572#issue-512883292 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/3e5b4c4abe7724397c0040dc01686972047a9f95..116aa9c778f08e68b30953e1aaf9157e0b94a8f4 |
| 3e5b4c4 | https://github.com/RustPython/RustPython/commit/3e5b4c4abe7724397c0040dc01686972047a9f95 |
| 116aa9c | https://github.com/RustPython/RustPython/commit/116aa9c778f08e68b30953e1aaf9157e0b94a8f4 |
|
Compare
| https://github.com/RustPython/RustPython/compare/3e5b4c4abe7724397c0040dc01686972047a9f95..116aa9c778f08e68b30953e1aaf9157e0b94a8f4 |
| October 27, 2019 03:02 | https://github.com/RustPython/RustPython/pull/1572#event-2746410904 |
| https://github.com/palaviv |
| palaviv | https://github.com/palaviv |
| Oct 27, 2019 | https://github.com/RustPython/RustPython/pull/1572#issuecomment-546721058 |
| @coolreader18 | https://github.com/coolreader18 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Oct 28, 2019
| https://github.com/RustPython/RustPython/pull/1572#ref-pullrequest-513084117 |
|
socket2 Part 1, some necessary but miscellaneous changes that aren't directly related to socket
#1574
| https://github.com/RustPython/RustPython/pull/1574 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/dc3a132309e34cf56bcb9b52c110e4dd42f20d5f..dac1df13dcaf71930e7bd090451da882b1abf944 |
| dc3a132 | https://github.com/RustPython/RustPython/commit/dc3a132309e34cf56bcb9b52c110e4dd42f20d5f |
| dac1df1 | https://github.com/RustPython/RustPython/commit/dac1df13dcaf71930e7bd090451da882b1abf944 |
|
Compare
| https://github.com/RustPython/RustPython/compare/dc3a132309e34cf56bcb9b52c110e4dd42f20d5f..dac1df13dcaf71930e7bd090451da882b1abf944 |
| October 28, 2019 04:01 | https://github.com/RustPython/RustPython/pull/1572#event-2747221239 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Oct 28, 2019 | https://github.com/RustPython/RustPython/pull/1572#issuecomment-546782701 |
| @palaviv | https://github.com/palaviv |
| #1574 | https://github.com/RustPython/RustPython/pull/1574 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/a2954e6407b1488d70e6a299eeb04f0ab3c93ac5..ec9362960d242ab6c749d689bef7981dd8563a4c |
| a2954e6 | https://github.com/RustPython/RustPython/commit/a2954e6407b1488d70e6a299eeb04f0ab3c93ac5 |
| ec93629 | https://github.com/RustPython/RustPython/commit/ec9362960d242ab6c749d689bef7981dd8563a4c |
|
Compare
| https://github.com/RustPython/RustPython/compare/a2954e6407b1488d70e6a299eeb04f0ab3c93ac5..ec9362960d242ab6c749d689bef7981dd8563a4c |
| October 28, 2019 17:55 | https://github.com/RustPython/RustPython/pull/1572#event-2749503291 |
| coolreader18 | https://github.com/coolreader18 |
| October 28, 2019 22:27 | https://github.com/RustPython/RustPython/pull/1572#commits-pushed-fcc796d |
|
| https://github.com/coolreader18 |
| Use socket2 crate for the socket module | https://github.com/RustPython/RustPython/pull/1572/commits/fcc796d6e18e1114eb28aaad79489193ee9ff886 |
| fcc796d | https://github.com/RustPython/RustPython/pull/1572/commits/fcc796d6e18e1114eb28aaad79489193ee9ff886 |
|
| https://github.com/coolreader18 |
| Convert PySocket to new-style class | https://github.com/RustPython/RustPython/pull/1572/commits/435342bc323f749c420daab70744fb5076fccfcc |
| 435342b | https://github.com/RustPython/RustPython/pull/1572/commits/435342bc323f749c420daab70744fb5076fccfcc |
|
| https://github.com/coolreader18 |
| Add socket.py from CPython 3.6 | https://github.com/RustPython/RustPython/pull/1572/commits/90e97c2baacc06a3d7ae103ea5af4dc1514f8fdc |
| 90e97c2 | https://github.com/RustPython/RustPython/pull/1572/commits/90e97c2baacc06a3d7ae103ea5af4dc1514f8fdc |
|
| https://github.com/coolreader18 |
| Add socket constants | https://github.com/RustPython/RustPython/pull/1572/commits/f2d63723ccd070a9b66220fcb8b4baf113885e5a |
| f2d6372 | https://github.com/RustPython/RustPython/pull/1572/commits/f2d63723ccd070a9b66220fcb8b4baf113885e5a |
|
| https://github.com/coolreader18 |
| Fix _socket.socket __new__/__init__, set timeout | https://github.com/RustPython/RustPython/pull/1572/commits/25a571a38b75a682562f1b61745edc7155172ea1 |
| 25a571a | https://github.com/RustPython/RustPython/pull/1572/commits/25a571a38b75a682562f1b61745edc7155172ea1 |
|
| https://github.com/coolreader18 |
| Add select test | https://github.com/RustPython/RustPython/pull/1572/commits/d0b39f9f1dc7c4c321c4cb55f840b821f8531354 |
| d0b39f9 | https://github.com/RustPython/RustPython/pull/1572/commits/d0b39f9f1dc7c4c321c4cb55f840b821f8531354 |
|
| https://github.com/coolreader18 |
| Fix some minor stuff | https://github.com/RustPython/RustPython/pull/1572/commits/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| 460e149 | https://github.com/RustPython/RustPython/pull/1572/commits/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/ec9362960d242ab6c749d689bef7981dd8563a4c..460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| ec93629 | https://github.com/RustPython/RustPython/commit/ec9362960d242ab6c749d689bef7981dd8563a4c |
| 460e149 | https://github.com/RustPython/RustPython/commit/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
|
Compare
| https://github.com/RustPython/RustPython/compare/ec9362960d242ab6c749d689bef7981dd8563a4c..460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| October 29, 2019 03:29 | https://github.com/RustPython/RustPython/pull/1572#event-2750727306 |
| https://github.com/palaviv |
| palaviv | https://github.com/palaviv |
|
Nov 1, 2019
| https://github.com/RustPython/RustPython/pull/1572#pullrequestreview-310417207 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/1572/files/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| palaviv | https://github.com/palaviv |
| https://github.com/RustPython/RustPython/pull/1572#pullrequestreview-310417207 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| vm/src/stdlib/socket.rs | https://github.com/RustPython/RustPython/pull/1572/files/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a |
| palaviv | https://github.com/palaviv |
| Nov 1, 2019 | https://github.com/RustPython/RustPython/pull/1572#discussion_r341546164 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| vm/src/stdlib/socket.rs | https://github.com/RustPython/RustPython/pull/1572/files/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a |
| palaviv | https://github.com/palaviv |
| Nov 1, 2019 | https://github.com/RustPython/RustPython/pull/1572#discussion_r341547076 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
|
| https://github.com/coolreader18 |
| Address feedback | https://github.com/RustPython/RustPython/pull/1572/commits/e563945979e90d32c72eaba754127bf8e5271e3d |
| e563945 | https://github.com/RustPython/RustPython/pull/1572/commits/e563945979e90d32c72eaba754127bf8e5271e3d |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/8b6fabd4fdc6bb131f3a1098d82ee6d604abc2af..e563945979e90d32c72eaba754127bf8e5271e3d |
| 8b6fabd | https://github.com/RustPython/RustPython/commit/8b6fabd4fdc6bb131f3a1098d82ee6d604abc2af |
| e563945 | https://github.com/RustPython/RustPython/commit/e563945979e90d32c72eaba754127bf8e5271e3d |
|
Compare
| https://github.com/RustPython/RustPython/compare/8b6fabd4fdc6bb131f3a1098d82ee6d604abc2af..e563945979e90d32c72eaba754127bf8e5271e3d |
| November 1, 2019 22:42 | https://github.com/RustPython/RustPython/pull/1572#event-2764670342 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| 24cc679 | https://github.com/RustPython/RustPython/commit/24cc67980c3300bd6a9fe08e0c0242aeeff54a95 |
| Nov 2, 2019 | https://github.com/RustPython/RustPython/pull/1572#event-2764817148 |
| https://github.com/palaviv |
| palaviv | https://github.com/palaviv |
| Nov 2, 2019 | https://github.com/RustPython/RustPython/pull/1572#issuecomment-549063679 |
| @coolreader18 | https://github.com/coolreader18 |
| #1580 | https://github.com/RustPython/RustPython/pull/1580 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| November 2, 2019 18:49 | https://github.com/RustPython/RustPython/pull/1572#event-2765469565 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Nov 2, 2019 | https://github.com/RustPython/RustPython/pull/1572#issuecomment-549075543 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F1572 |
|
| https://github.com/palaviv |
|
palaviv
| https://github.com/palaviv |
|
| https://github.com/RustPython/RustPython/pull/1572/files/460e1497ffdabfdc9d6989c6c1cc004bdc6f5fd9 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/1572 |
|
| https://github.com/coolreader18 |
|
| https://github.com/palaviv |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |