Title: `ExceptionGroup.subgroup()` returns a fully matching nested subclass group unchanged instead of calling `derive()` · Issue #9576 · RustPython/RustPython · GitHub
Open Graph Title: `ExceptionGroup.subgroup()` returns a fully matching nested subclass group unchanged instead of calling `derive()` · Issue #9576 · RustPython/RustPython
X Title: `ExceptionGroup.subgroup()` returns a fully matching nested subclass group unchanged instead of calling `derive()` · Issue #9576 · RustPython/RustPython
Description: Summary subgroup() returns a nested exception group subclass as the same object when all of its leaves match, without calling derive(). split() does call derive(), so eg.split(c)[0] and eg.subgroup(c) disagree. The docs for derive() say:...
Open Graph Description: Summary subgroup() returns a nested exception group subclass as the same object when all of its leaves match, without calling derive(). split() does call derive(), so eg.split(c)[0] and eg.subgroup...
X Description: Summary subgroup() returns a nested exception group subclass as the same object when all of its leaves match, without calling derive(). split() does call derive(), so eg.split(c)[0] and eg.subgroup...
Opengraph URL: https://github.com/RustPython/RustPython/issues/9576
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`ExceptionGroup.subgroup()` returns a fully matching nested subclass group unchanged instead of calling `derive()`","articleBody":"## Summary\n\n`subgroup()` returns a nested exception group subclass as the same object when all of its leaves match, without calling `derive()`. `split()` does call `derive()`, so `eg.split(c)[0]` and `eg.subgroup(c)` disagree. The [docs for `derive()`](https://docs.python.org/3/library/exceptions.html#BaseExceptionGroup.derive) say: \"This method is used by subgroup() and split(), which are used in various contexts to break up an exception group. A subclass needs to override it in order to make subgroup() and split() return instances of the subclass rather than ExceptionGroup.\"\n\n## Reproducer\n\n```python\nclass MyEG(ExceptionGroup):\n pass\ninner = MyEG(\"inner\", [ValueError(1)])\neg = ExceptionGroup(\"outer\", [inner, TypeError(2)])\ns = eg.subgroup(ValueError)\nprint(\"subgroup:\", type(s.exceptions[0]).__name__, s.exceptions[0] is inner)\nm, r = eg.split(ValueError)\nprint(\"split: \", type(m.exceptions[0]).__name__, m.exceptions[0] is inner)\nprint(\"top: \", type(inner.subgroup(ValueError)).__name__)\n```\n\n## Expected\n\nCPython 3.15.2 (same on 3.12.16):\n\n```\nsubgroup: ExceptionGroup False\nsplit: ExceptionGroup False\ntop: ExceptionGroup\n```\n\n## Actual\n\nRustPython main (ef023bc):\n\n```\nsubgroup: MyEG True\nsplit: ExceptionGroup False\ntop: MyEG\n```\n\n## Cause\n\n`subgroup()` tracks whether anything was dropped and returns `zelf` when nothing was (`if !modified { return Ok(zelf.into()); }`), so a group whose leaves all match is never passed to `derive()` ([exception_group.rs#L126-L161](https://github.com/RustPython/RustPython/blob/18fc82bc6327e9a4f5e5bbdcbecb5c65c29ce95f/crates/vm/src/exception_group.rs#L126-L161)). `split()` right below has no such shortcut. CPython only returns the group itself when the condition matches the group as a whole; otherwise it rebuilds every partially or fully matching nested group with `derive()`, for `split()` and `subgroup()` alike ([exceptions.c#L1067-L1100](https://github.com/python/cpython/blob/3d6d2a63a23ee4d340ed8df6de0bd70ef175c4cf/Objects/exceptions.c#L1067-L1100), [#L1154-L1157](https://github.com/python/cpython/blob/3d6d2a63a23ee4d340ed8df6de0bd70ef175c4cf/Objects/exceptions.c#L1154-L1157), [#L1209-L1233](https://github.com/python/cpython/blob/3d6d2a63a23ee4d340ed8df6de0bd70ef175c4cf/Objects/exceptions.c#L1209-L1233)). Dropping the `modified` shortcut and always calling `derive_and_copy_attributes` when `matching` is non-empty would match CPython. PyPy had the same shortcut and just removed it this way (pypy/pypy#5717).\n\n`test_exception_group.NestedExceptionGroupSubclassSplitTest.test_split_BaseExceptionGroup_subclass_no_derive_new_override` passes because for `subgroup()` it only checks the leaves.\n\n\u003csub>Drafted with help from Claude Code; I reviewed and checked it before posting.\u003c/sub>\n","author":{"url":"https://github.com/taxor03","@type":"Person","name":"taxor03"},"datePublished":"2026-11-03T11:09:17Z","url":"https://github.com/RustPython/RustPython/issues/9576"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e20b121f-b9f1-6057-acb7-fe085f6c0221 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A190:1F927B:1532641:1BFDA06:6B01F737 |
| html-safe-nonce | 25939e244af172eca5d76f6c4361b785fdefaeac1f5c43ed9edab785b9304aa8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTkwOjFGOTI3QjoxNTMyNjQxOjFCRkRBMDY6NkIwMUY3MzciLCJ2aXNpdG9yX2lkIjoiNTg5MDg2MDk1NzUzMzU5OTU0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 77fd192571e00bc201009c2d7507a9d94a28bd29e9d6115ef59245e3e6b75b8d |
| hovercard-subject-tag | issue:6181350215 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/9576/issue_layout |
| twitter:image | https://opengraph.githubassets.com/efec47780ed083305cc23cbf602d1c81d1f08c8c174f6ec88c9f29d4e92063a7/RustPython/RustPython/issues/9576 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/efec47780ed083305cc23cbf602d1c81d1f08c8c174f6ec88c9f29d4e92063a7/RustPython/RustPython/issues/9576 |
| og:image:alt | Summary subgroup() returns a nested exception group subclass as the same object when all of its leaves match, without calling derive(). split() does call derive(), so eg.split(c)[0] and eg.subgroup... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | taxor03 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width