René's URL Explorer Experiment


Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython · GitHub

Open Graph Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython

X Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython

Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Reproduction import csv csv.get_dialect([]) R...

Open Graph Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro...

X Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro...

Opengraph URL: https://github.com/RustPython/RustPython/issues/9507

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error","articleBody":"## Feature\n\n`csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for any name that is not a `str`, but CPython looks the name up in a dict, so an unhashable name raises its hashing error.\n\n### Reproduction\n\n```python\nimport csv\ncsv.get_dialect([])\n```\n\n**RustPython:**\n\n```\n_csv.Error: argument 0 must be a string, not 'list'\n```\n\n**CPython:**\n\n```\nTypeError: cannot use 'list' as a dict key (unhashable type: 'list')\n```\n\n`csv.unregister_dialect([])` behaves the same, and a name whose `__hash__` raises `ValueError` gives `_csv.Error` instead of that `ValueError` in both functions.\n\n### Root cause\n\n[`get_dialect`](https://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L218-L230) and [`unregister_dialect`](https://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L232-L249) downcast `name` to `PyStr` and turn every other object into `_csv.Error` without hashing it. CPython's [`get_dialect_from_registry`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170) and [`_csv_unregister_dialect_impl`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666) pass the name to `PyDict_GetItemRef` and `PyDict_Pop`, which propagate a hashing error and leave `unknown dialect` for a clean miss.\n\n### Fix\n\nFor a name that is not a `str`, call `obj.hash(vm)?` and then return `_csv.Error(\"unknown dialect\")`, since the registry only holds `str` keys.\n\n### Environment\n\n- RustPython [713e14c](https://github.com/RustPython/RustPython/tree/713e14cfc78d06372c68a1804240de52a8340548) (Python 3.15.0 alpha), also reproduced on 0.4.0 and 0.6.1\n- CPython v3.15.2, v3.14.4 and v3.12.10 (3.12 prints `TypeError: unhashable type: 'list'`)\n- OS: macOS arm64 (713e14c), Debian 12 (0.4.0, 0.6.1)\n\n## Python Documentation or reference to CPython source code\n\n- CPython `get_dialect_from_registry`: [`Modules/_csv.c#L162-L170`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170) reports `unknown dialect` only when the lookup returns 0, so a hashing error (`-1`) propagates:\n\n  ```c\n  PyObject *dialect_obj;\n  if (PyDict_GetItemRef(module_state->dialects, name_obj, &dialect_obj) == 0) {\n      PyErr_SetString(module_state->error_obj, \"unknown dialect\");\n  }\n  return dialect_obj;\n  ```\n\n- CPython `_csv_unregister_dialect_impl`: [`Modules/_csv.c#L1652-L1666`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666) does the same with `PyDict_Pop`:\n\n  ```c\n  int rc = PyDict_Pop(module_state->dialects, name, NULL);\n  if (rc \u003c 0) {\n      return NULL;\n  }\n  if (rc == 0) {\n      PyErr_Format(module_state->error_obj, \"unknown dialect\");\n      return NULL;\n  }\n  ```\n\n- Documentation: [`csv.get_dialect`](https://docs.python.org/3.15/library/csv.html#csv.get_dialect) and [`csv.unregister_dialect`](https://docs.python.org/3.15/library/csv.html#csv.unregister_dialect)\n\nAI disclosure: this report was drafted with Claude Code (claude-opus-5-5) and reviewed by me before submission. The divergence comes from a differential-testing run against CPython 3.12, and every source reference above was checked against the linked revisions.","author":{"url":"https://github.com/jseop-lim","@type":"Person","name":"jseop-lim"},"datePublished":"2026-11-01T03:44:47Z","url":"https://github.com/RustPython/RustPython/issues/9507"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:efb9aca6-348b-2558-6b7d-eb035fd238d5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id888A:5D487:F871A5:149FD2A:6B01DDF5
html-safe-nonce07708df2bf3b9df10190cdfb6baae2f2a96ab218a39f2fdbd2168a4223e10e0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODhBOjVENDg3OkY4NzFBNToxNDlGRDJBOjZCMDFEREY1IiwidmlzaXRvcl9pZCI6IjMwMzM5NTI3NjIxMTIxMDU5NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3d5b43f42dfca998e27c865432d131a8a56f241edbbe1252e9ce5050cdc8e56b
hovercard-subject-tagissue:6142902623
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/9507/issue_layout
twitter:imagehttps://opengraph.githubassets.com/75625ffe6c92189a42306e90535d1dfe459d08de272a920d232a47ebbf8e4ec5/RustPython/RustPython/issues/9507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75625ffe6c92189a42306e90535d1dfe459d08de272a920d232a47ebbf8e4ec5/RustPython/RustPython/issues/9507
og:image:altFeature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejseop-lim
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/RustPython/RustPython/issues/9507#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fissues%2F9507
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fissues%2F9507
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/issues/9507
Reloadhttps://github.com/RustPython/RustPython/issues/9507
Reloadhttps://github.com/RustPython/RustPython/issues/9507
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
New issuehttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/9507
New issuehttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/9507
#9514https://github.com/RustPython/RustPython/pull/9514
csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing errorhttps://github.com/RustPython/RustPython/issues/9507#top
#9514https://github.com/RustPython/RustPython/pull/9514
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
https://github.com/jseop-lim
jseop-limhttps://github.com/jseop-lim
on Nov 1, 2026https://github.com/RustPython/RustPython/issues/9507#issue-6142902623
get_dialecthttps://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L218-L230
unregister_dialecthttps://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L232-L249
get_dialect_from_registryhttps://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170
_csv_unregister_dialect_implhttps://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666
713e14chttps://github.com/RustPython/RustPython/tree/713e14cfc78d06372c68a1804240de52a8340548
713e14chttps://github.com/RustPython/RustPython/commit/713e14cfc78d06372c68a1804240de52a8340548
Modules/_csv.c#L162-L170https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170
Modules/_csv.c#L1652-L1666https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666
csv.get_dialecthttps://docs.python.org/3.15/library/csv.html#csv.get_dialect
csv.unregister_dialecthttps://docs.python.org/3.15/library/csv.html#csv.unregister_dialect
jseop-limhttps://github.com/jseop-lim
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
on Nov 1, 2026https://github.com/RustPython/RustPython/issues/9507#event-34812399605
youknowonehttps://github.com/youknowone
completedhttps://github.com/RustPython/RustPython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#9514https://github.com/RustPython/RustPython/pull/9514
on Nov 1, 2026https://github.com/RustPython/RustPython/issues/9507#event-34823102706
Sign up for freehttps://github.com/signup?return_to=https://github.com/RustPython/RustPython/issues/9507
Sign in to commenthttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/9507
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.