Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython · GitHub
Open Graph Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython
X Title: `csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error · Issue #9507 · RustPython/RustPython
Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Reproduction import csv csv.get_dialect([]) R...
Open Graph Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro...
X Description: Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro...
Opengraph URL: https://github.com/RustPython/RustPython/issues/9507
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for an unhashable name instead of the hashing error","articleBody":"## Feature\n\n`csv.get_dialect()` and `csv.unregister_dialect()` raise `csv.Error` for any name that is not a `str`, but CPython looks the name up in a dict, so an unhashable name raises its hashing error.\n\n### Reproduction\n\n```python\nimport csv\ncsv.get_dialect([])\n```\n\n**RustPython:**\n\n```\n_csv.Error: argument 0 must be a string, not 'list'\n```\n\n**CPython:**\n\n```\nTypeError: cannot use 'list' as a dict key (unhashable type: 'list')\n```\n\n`csv.unregister_dialect([])` behaves the same, and a name whose `__hash__` raises `ValueError` gives `_csv.Error` instead of that `ValueError` in both functions.\n\n### Root cause\n\n[`get_dialect`](https://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L218-L230) and [`unregister_dialect`](https://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L232-L249) downcast `name` to `PyStr` and turn every other object into `_csv.Error` without hashing it. CPython's [`get_dialect_from_registry`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170) and [`_csv_unregister_dialect_impl`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666) pass the name to `PyDict_GetItemRef` and `PyDict_Pop`, which propagate a hashing error and leave `unknown dialect` for a clean miss.\n\n### Fix\n\nFor a name that is not a `str`, call `obj.hash(vm)?` and then return `_csv.Error(\"unknown dialect\")`, since the registry only holds `str` keys.\n\n### Environment\n\n- RustPython [713e14c](https://github.com/RustPython/RustPython/tree/713e14cfc78d06372c68a1804240de52a8340548) (Python 3.15.0 alpha), also reproduced on 0.4.0 and 0.6.1\n- CPython v3.15.2, v3.14.4 and v3.12.10 (3.12 prints `TypeError: unhashable type: 'list'`)\n- OS: macOS arm64 (713e14c), Debian 12 (0.4.0, 0.6.1)\n\n## Python Documentation or reference to CPython source code\n\n- CPython `get_dialect_from_registry`: [`Modules/_csv.c#L162-L170`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170) reports `unknown dialect` only when the lookup returns 0, so a hashing error (`-1`) propagates:\n\n ```c\n PyObject *dialect_obj;\n if (PyDict_GetItemRef(module_state->dialects, name_obj, &dialect_obj) == 0) {\n PyErr_SetString(module_state->error_obj, \"unknown dialect\");\n }\n return dialect_obj;\n ```\n\n- CPython `_csv_unregister_dialect_impl`: [`Modules/_csv.c#L1652-L1666`](https://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666) does the same with `PyDict_Pop`:\n\n ```c\n int rc = PyDict_Pop(module_state->dialects, name, NULL);\n if (rc \u003c 0) {\n return NULL;\n }\n if (rc == 0) {\n PyErr_Format(module_state->error_obj, \"unknown dialect\");\n return NULL;\n }\n ```\n\n- Documentation: [`csv.get_dialect`](https://docs.python.org/3.15/library/csv.html#csv.get_dialect) and [`csv.unregister_dialect`](https://docs.python.org/3.15/library/csv.html#csv.unregister_dialect)\n\nAI disclosure: this report was drafted with Claude Code (claude-opus-5-5) and reviewed by me before submission. The divergence comes from a differential-testing run against CPython 3.12, and every source reference above was checked against the linked revisions.","author":{"url":"https://github.com/jseop-lim","@type":"Person","name":"jseop-lim"},"datePublished":"2026-11-01T03:44:47Z","url":"https://github.com/RustPython/RustPython/issues/9507"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:efb9aca6-348b-2558-6b7d-eb035fd238d5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 888A:5D487:F871A5:149FD2A:6B01DDF5 |
| html-safe-nonce | 07708df2bf3b9df10190cdfb6baae2f2a96ab218a39f2fdbd2168a4223e10e0a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODhBOjVENDg3OkY4NzFBNToxNDlGRDJBOjZCMDFEREY1IiwidmlzaXRvcl9pZCI6IjMwMzM5NTI3NjIxMTIxMDU5NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3d5b43f42dfca998e27c865432d131a8a56f241edbbe1252e9ce5050cdc8e56b |
| hovercard-subject-tag | issue:6142902623 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/9507/issue_layout |
| twitter:image | https://opengraph.githubassets.com/75625ffe6c92189a42306e90535d1dfe459d08de272a920d232a47ebbf8e4ec5/RustPython/RustPython/issues/9507 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/75625ffe6c92189a42306e90535d1dfe459d08de272a920d232a47ebbf8e4ec5/RustPython/RustPython/issues/9507 |
| og:image:alt | Feature csv.get_dialect() and csv.unregister_dialect() raise csv.Error for any name that is not a str, but CPython looks the name up in a dict, so an unhashable name raises its hashing error. Repro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jseop-lim |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width