Title: Review issues that appear resolved for closure · Issue #8982 · RustPython/RustPython · GitHub
Open Graph Title: Review issues that appear resolved for closure · Issue #8982 · RustPython/RustPython
X Title: Review issues that appear resolved for closure · Issue #8982 · RustPython/RustPython
Description: Summary Please review these 25 issues for closure. Based on the checks described below, their reported problems appear to be resolved in main (at f39b054b9c8c). While looking for issues to work on, I spent time investigating problems tha...
Open Graph Description: Summary Please review these 25 issues for closure. Based on the checks described below, their reported problems appear to be resolved in main (at f39b054b9c8c). While looking for issues to work on,...
X Description: Summary Please review these 25 issues for closure. Based on the checks described below, their reported problems appear to be resolved in main (at f39b054b9c8c). While looking for issues to work on,...
Opengraph URL: https://github.com/RustPython/RustPython/issues/8982
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review issues that appear resolved for closure","articleBody":"## Summary\n\nPlease review these 25 issues for closure. Based on the checks described below, their reported problems appear to be resolved in main (at [f39b054b9c8c](https://github.com/RustPython/RustPython/commit/f39b054b9c8cbbf884f53123eef028131789990c)).\nWhile looking for issues to work on, I spent time investigating problems that appeared to be resolved. Closing these issues would help contributors find remaining work and avoid repeating the same investigation.\n\nI focused on issues with clear reproduction steps and directly checkable results. I used OpenAI Codex (GPT-6 Astra) extensively to investigate them, run checks, and draft the reports. I reviewed the results, manually checked some cases, and repeated checks where useful.\n\nChecks were performed on October 5–6, 2026, on macOS, using native ARM64 and x86_64/Rosetta RustPython builds, with CPython 3.14.6 for behavioral comparisons. The [environment record](https://github.com/YangSiJun528/RustPython/blob/f919ecd4ef6a372c812dce53fec5b8aa259f70eb/tools/issue-repros/recheck/ENVIRONMENT.md) and individual reports document the environments and limitations.\n\nThe [verification records](https://github.com/YangSiJun528/RustPython/blob/f919ecd4ef6a372c812dce53fec5b8aa259f70eb/tools/issue-repros/README.md) include reproduction steps, observed results, and limitations for each issue. These recommendations cover only the reported problems and the behavior tested. I have not reviewed every underlying fix at the code level.\n\n## Details\n\n### [#2527 — REPL expressions inside blocks](https://github.com/RustPython/RustPython/issues/2527)\n\nIn an actual interactive REPL, the original loop now displays `0` through `9`, and the file-write block displays `5`, matching CPython.\n\n- Related changes: [PR #7067](https://github.com/RustPython/RustPython/pull/7067): display interactive expressions in nested blocks.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/2527/README.md).\n\n### [#3418 — Native OrderedDict export](https://github.com/RustPython/RustPython/issues/3418)\n\n`from _collections import OrderedDict` now succeeds. Ordering, `move_to_end`, `popitem`, reverse iteration and equality checks agree with CPython.\n\n- Related changes: [PR #8780](https://github.com/RustPython/RustPython/pull/8780): native OrderedDict and class-method descriptors.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/3418/README.md).\n\n### [#3430 — ElementTree parsing valid XML](https://github.com/RustPython/RustPython/issues/3430)\n\n`etree.XML(\"\u003croot>\u003c/root>\")` now parses successfully without the reported `TypeError`. Valid XML samples with children, text, attributes, namespaces and UTF-8 also agree with CPython.\n\n- Related changes: [PR #6582](https://github.com/RustPython/RustPython/pull/6582): accept None as the parser encoding; [PR #8741](https://github.com/RustPython/RustPython/pull/8741): native ElementTree parsing.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/3430/README.md).\n\n### [#3846 — Disassembly support used by modulefinder](https://github.com/RustPython/RustPython/issues/3846)\n\n`dis.opmap`, `dis.EXTENDED_ARG` and `dis._unpack_opargs` now work with actual bytecode. `modulefinder` correctly analyzes the tested local import graph, and all 17 original `ModuleFinderTest` tests pass.\n\n- Related changes: [PR #5377](https://github.com/RustPython/RustPython/pull/5377): provide dis exports and bytecode/import scanning.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/3846/README.md).\n\n### [#4506 — SymPy import with the reported versions](https://github.com/RustPython/RustPython/issues/4506)\n\nSymPy 1.11.1 with mpmath 1.2.1 now imports successfully. The previously failing `is_commutative` assignment in `power.py` executes, and the reported `Pow` path succeeds.\n\n- Related changes: [PR #6390](https://github.com/RustPython/RustPython/pull/6390): install declared slot descriptors even over inherited attributes.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4506/README.md).\n\n### [#4527 — Finalization of a global object](https://github.com/RustPython/RustPython/issues/4527)\n\nThe original global-object example now calls `__del__` and prints `deleted!` during normal interpreter shutdown, with exit code `0` and no stderr.\n\n- Related changes: [PR #6934](https://github.com/RustPython/RustPython/pull/6934): module finalization during shutdown.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4527/README.md).\n\n### [#4541 — Safe path flags and path insertion](https://github.com/RustPython/RustPython/issues/4541)\n\n`-P` and `PYTHONSAFEPATH` now suppress automatic unsafe path insertion for scripts, `-c`, `-m` and the interactive REPL. Symlink, `-E` and `-I` checks also agree with CPython.\n\n- Related changes: [PR #4611](https://github.com/RustPython/RustPython/pull/4611): connect -P, the environment and safe_path flags; [PR #5049](https://github.com/RustPython/RustPython/pull/5049): condition automatic path insertion on safe_path; [PR #8605](https://github.com/RustPython/RustPython/pull/8605): resolve script paths for path insertion.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4541/README.md).\n\n### [#4690 — Native class-method descriptor type](https://github.com/RustPython/RustPython/issues/4690)\n\nThe raw `dict.__dict__[\"fromkeys\"]` descriptor now has type `classmethod_descriptor`, while the bound `dict.fromkeys` has type `builtin_function_or_method`, matching CPython. Descriptor binding and the additional native descriptors checked agree with CPython.\n\n- Related changes: [PR #8780](https://github.com/RustPython/RustPython/pull/8780): native OrderedDict and class-method descriptors.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4690/README.md).\n\n### [#4762 — Negative dynamic format width](https://github.com/RustPython/RustPython/issues/4762)\n\n`'%*s' % (-5, 'abc')` now returns `'abc '`, preserving the required two trailing spaces. Positive, zero and additional negative widths also agree with CPython.\n\n- Related changes: [PR #4766](https://github.com/RustPython/RustPython/pull/4766): left alignment for negative dynamic widths.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4762/README.md).\n\n### [#4769 — Deque subclass pickle state](https://github.com/RustPython/RustPython/issues/4769)\n\nThe original deque subclass regression test now passes. Pickle protocols 0–5 preserve subclass type, contents, `maxlen`, instance attributes and slots.\n\n- Related changes: [PR #7699](https://github.com/RustPython/RustPython/pull/7699): include `__getstate__` in deque reduction.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4769/README.md).\n\n### [#4784 — README API documentation link](https://github.com/RustPython/RustPython/issues/4784)\n\nThe README documentation link now serves the RustPython API documentation, including crate and API entries. The retrieved page identifies RustPython 0.6.0.\n\n- Documentation: [Published API documentation](https://docs.rs/rustpython/latest/rustpython/).\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4784/README.md).\n\n### [#4786 — Surrogate in a type name](https://github.com/RustPython/RustPython/issues/4786)\n\nThe original surrogate in the type name is preserved, and creating the type raises `UnicodeEncodeError`, matching CPython. The uncaught exception correctly exits with code `1`.\n\n- Related changes: [PR #5629](https://github.com/RustPython/RustPython/pull/5629): retain surrogate literals; [PR #6547](https://github.com/RustPython/RustPython/pull/6547): validate type names as UTF-8.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4786/README.md).\n\n### [#4856 — Lambda in a class decorator](https://github.com/RustPython/RustPython/issues/4856)\n\nThe original class-decorator example now compiles without the reported Rust compiler panic. Running the supplied source still raises `NameError` for the undefined `BaseFTests` in both interpreters; valid `mock.patch` and nested-capture examples execute successfully.\n\n- Related changes: [PR #8138](https://github.com/RustPython/RustPython/pull/8138): visit class decorators before entering their class scope.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4856/README.md).\n\n### [#4907 — Await in an async comprehension](https://github.com/RustPython/RustPython/issues/4907)\n\nThe original async function now compiles. The example in the issue comment also runs through an actual asyncio event loop, completes both awaited sleeps and prints `lc done`.\n\n- Related changes: [PR #5334](https://github.com/RustPython/RustPython/pull/5334): compile await inside an async comprehension.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4907/README.md).\n\n### [#4908 — AST round trip for a starred subscript](https://github.com/RustPython/RustPython/issues/4908)\n\nThe original starred subscript now unparses to valid Python syntax and reparses successfully. Additional slice and starred-subscript combinations preserve the AST structure.\n\n- Related changes: [PR #5121](https://github.com/RustPython/RustPython/pull/5121): valid subscript-tuple unparsing.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4908/README.md).\n\n### [#4937 — Email Subject with an unknown encoding](https://github.com/RustPython/RustPython/issues/4937)\n\nThe original email `Subject` with the unknown `X` encoding is now returned without `KeyError`. Additional unknown-encoding and malformed-header cases were also checked.\n\n- Related changes: [PR #5663](https://github.com/RustPython/RustPython/pull/5663): unknown encoded-word recovery.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4937/README.md).\n\n### [#4950 — Bool numeric format codes](https://github.com/RustPython/RustPython/issues/4950)\n\n`False` and `True` now format like CPython for the originally reported format codes, the comment’s `n` and `d` codes, and the tested width and precision combinations.\n\n- Related changes: [PR #5012](https://github.com/RustPython/RustPython/pull/5012): update the parser/format dependency · [Parser PR #91](https://github.com/RustPython/Parser/pull/91).\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4950/README.md).\n\n### [#4970 — Locale formatting with LC_ALL unset](https://github.com/RustPython/RustPython/issues/4970)\n\nWith `LC_ALL` unset and `LANG` and `LC_NUMERIC` set to `en_US.UTF-8`, the original `test_locale` and the integer/float locale tests pass without skips or expected failures.\n\n- Related changes: [PR #7350](https://github.com/RustPython/RustPython/pull/7350): use locale grouping, separator and decimal-point data.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/4970/README.md).\n\n### [#5179 — Builtin buffer methods](https://github.com/RustPython/RustPython/issues/5179)\n\nThe builtin and subclass types tested now expose the expected buffer methods. Writable access, release and resizing after release agree with CPython; resizing while a buffer is exported is correctly blocked.\n\n- Related changes: [PR #8523](https://github.com/RustPython/RustPython/pull/8523): PEP 688 methods and managed buffer exports.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/5179/README.md).\n\n### [#5656 — Invalid escape warning in a bytes literal](https://github.com/RustPython/RustPython/issues/5656)\n\nCompiling the original bytes literal now emits the required `SyntaxWarning` for the invalid escape while preserving the bytes value. Treating the warning as an error also works.\n\n- Related changes: [PR #7164](https://github.com/RustPython/RustPython/pull/7164): warn about invalid string and bytes escapes.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/5656/README.md).\n\n### [#5699 — Blockers for colored tracebacks](https://github.com/RustPython/RustPython/issues/5699)\n\nAll four reported blockers now work: class patterns, `frame.f_builtins`, `sys.stdlib_module_names` and `except*`. Actual uncaught exceptions produce colored tracebacks, including builtin and missing-stdlib suggestions, matching CPython in the tested cases.\n\n- Related changes: [PR #6110](https://github.com/RustPython/RustPython/pull/6110): class-pattern code generation; [PR #6568](https://github.com/RustPython/RustPython/pull/6568): provide both frame.f_builtins and sys.stdlib_module_names; [PR #6530](https://github.com/RustPython/RustPython/pull/6530): except* code generation and exception-group handling.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/5699/README.md).\n\n### [#6429 — Py_GIL_DISABLED configuration value](https://github.com/RustPython/RustPython/issues/6429)\n\n`sysconfig.get_config_var(\"Py_GIL_DISABLED\")` now returns the defined value `1` in the verified POSIX RustPython build.\n\n- Related changes: [PR #6428](https://github.com/RustPython/RustPython/pull/6428): expose the build-time Py_GIL_DISABLED value.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/6429/README.md).\n\n### [#6697 — Symbol-table error while importing pytest](https://github.com/RustPython/RustPython/issues/6697)\n\nThe original function with a generator expression inside `finally` now compiles and runs without the reported symbol-table error. The real pytest 9.1.1 `pytester.py` module compiles and imports, its affected `pytest_runtest_protocol` body passes a controlled execution check, and a small run through `pytest.console_main` reports `2 passed`. This verifies the reported compiler/import blocker; it does not establish that the full xonsh test suite passes.\n\n- Related changes: [PR #8507](https://github.com/RustPython/RustPython/pull/8507): preserve symbol-table cursors when compiling an extra copy of a `finally` block.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/6697/README.md).\n\n### [#8052 — Ellipsis type name](https://github.com/RustPython/RustPython/issues/8052)\n\nThe type name is now `ellipsis`, and its representation is `\u003cclass 'ellipsis'>`, matching CPython. The type alias and existing JSON regression tests also pass.\n\n- Related changes: [PR #8580](https://github.com/RustPython/RustPython/pull/8580): correct the Ellipsis type name.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/8052/README.md).\n\n### [#8494 — Classmethod and staticmethod annotations](https://github.com/RustPython/RustPython/issues/8494)\n\n`classmethod` and `staticmethod` now cache `__annotations__` and `__annotate__` on the wrapper. Assignment and deletion leave the wrapped function unchanged. The module-level example from the issue, a separate function-local variant and the original regression test pass.\n\n- Related changes: [PR #8701](https://github.com/RustPython/RustPython/pull/8701): cache and assign annotation attributes on the wrapper.\n- [Reproduction and results](https://github.com/YangSiJun528/RustPython/blob/resolved-issue-reproducers/tools/issue-repros/recheck/cases/8494/README.md).\n","author":{"url":"https://github.com/YangSiJun528","@type":"Person","name":"YangSiJun528"},"datePublished":"2026-10-06T06:16:58Z","url":"https://github.com/RustPython/RustPython/issues/8982"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:58ce2460-0e03-5b51-e1b9-4e3c4bb87b68 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C97E:F5AA9:21AFD71:2DCECD8:6B002447 |
| html-safe-nonce | c76164c4cf468e9aee7a9df97f23ab4fa484c2ad894cab5da5c8c456680517ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTdFOkY1QUE5OjIxQUZENzE6MkRDRUNEODo2QjAwMjQ0NyIsInZpc2l0b3JfaWQiOiIzMTE2ODk3MjkwNzkxNDI5MTkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7bb02a25cdb0a87dac7ac313ee1121cce7e595799df9dfc49c8023ec70e5d4a7 |
| hovercard-subject-tag | issue:5723894128 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/8982/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9d146eebb125fc0c0aed31562941ad8623d1f77518f3e569ac87ede610a6cd3c/RustPython/RustPython/issues/8982 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9d146eebb125fc0c0aed31562941ad8623d1f77518f3e569ac87ede610a6cd3c/RustPython/RustPython/issues/8982 |
| og:image:alt | Summary Please review these 25 issues for closure. Based on the checks described below, their reported problems appear to be resolved in main (at f39b054b9c8c). While looking for issues to work on,... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | YangSiJun528 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width