Title: `format()` does not support locales for 'n' presentation type · Issue #5181 · RustPython/RustPython · GitHub
Open Graph Title: `format()` does not support locales for 'n' presentation type · Issue #5181 · RustPython/RustPython
X Title: `format()` does not support locales for 'n' presentation type · Issue #5181 · RustPython/RustPython
Description: Feature There are a number of options available for formatting integers using the format() API. The default is 'd'. There is a closely related alternative formatting 'n' which works the same, but uses the locale settings to insert the co...
Open Graph Description: Feature There are a number of options available for formatting integers using the format() API. The default is 'd'. There is a closely related alternative formatting 'n' which works the same, but u...
X Description: Feature There are a number of options available for formatting integers using the format() API. The default is 'd'. There is a closely related alternative formatting 'n' which works...
Opengraph URL: https://github.com/RustPython/RustPython/issues/5181
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`format()` does not support locales for 'n' presentation type","articleBody":"## Feature\r\nThere are a number of options available for formatting integers using the `format()` API. The default is `'d'`. There is a closely related alternative formatting `'n'` which works the same, but uses the locale settings to insert the correct separators. For example, `format(123456789, 'n') == '123,456,789'` (I am in the US, so my locale specifies `,` instead of `.`).\r\n\r\nThe current implementation does not include the separator, and therefore `test_locale` in `test_format.py` is failing.\r\n\r\nI see two ways forward:\r\n1. Make RustPython/Parser/format aware of `libc::locale`. This would involve adding a dependency on libc.\r\n2. In `int.rs`, get the locale info and pass it to `rustpython_parse::FormatSpec`. This would involve adding an alternative constructor to the RustPython/Parser/format `FormatSpec` that also accepts locale info. \r\n\r\n## Python Documentation or reference to CPython source code\r\nhttps://docs.python.org/3/library/string.html#formatspec, specifically the 'n' presentation type.\r\n","author":{"url":"https://github.com/dchiquito","@type":"Person","name":"dchiquito"},"datePublished":"2024-02-24T18:25:08Z","url":"https://github.com/RustPython/RustPython/issues/5181"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2fb43dd7-4786-4972-60c9-ec2751c022ce |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BAE6:3DB50A:536A8B:701EE8:6B0030A4 |
| html-safe-nonce | 9de54ad3663b30e4984c9fcc84ea9794e1440dbe4db598c83e0425d401c3042d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUU2OjNEQjUwQTo1MzZBOEI6NzAxRUU4OjZCMDAzMEE0IiwidmlzaXRvcl9pZCI6IjM4MTE0MTkzODQwMjc1NTgwNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 030d48eb1c32a0d235f35978ebe0eefa7c5bdf14ab0119a6634311929ebb05ce |
| hovercard-subject-tag | issue:2152434167 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/5181/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b49b7aae39202eb23b1574b71c19096774834e8c5375bfebb6f3b6ca749b7869/RustPython/RustPython/issues/5181 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b49b7aae39202eb23b1574b71c19096774834e8c5375bfebb6f3b6ca749b7869/RustPython/RustPython/issues/5181 |
| og:image:alt | Feature There are a number of options available for formatting integers using the format() API. The default is 'd'. There is a closely related alternative formatting 'n' which works the same, but u... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dchiquito |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width