Title: cformat star asterisk should behave differently when given negative sign · Issue #4762 · RustPython/RustPython · GitHub
Open Graph Title: cformat star asterisk should behave differently when given negative sign · Issue #4762 · RustPython/RustPython
X Title: cformat star asterisk should behave differently when given negative sign · Issue #4762 · RustPython/RustPython
Description: In string formatting, a print-f style format specifier can have its amount and precision formatted by variable value through use of star asterik(%*s). In cformat_bytes and cformat_string, through try_update_quantity_from_tuple, try_updat...
Open Graph Description: In string formatting, a print-f style format specifier can have its amount and precision formatted by variable value through use of star asterik(%*s). In cformat_bytes and cformat_string, through t...
X Description: In string formatting, a print-f style format specifier can have its amount and precision formatted by variable value through use of star asterik(%*s). In cformat_bytes and cformat_string, through t...
Opengraph URL: https://github.com/RustPython/RustPython/issues/4762
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"cformat star asterisk should behave differently when given negative sign","articleBody":"In string formatting, a print-f style format specifier can have its amount and precision formatted by variable value through use of star asterik(%*s).\r\n\r\nIn cformat_bytes and cformat_string, through try_update_quantity_from_tuple, try_update_quantity_from_element is used to update quantity if possible, but it makes the assumption that its behavior should be the same regardless of the sign value of the given element.\r\n\r\n```python\r\nif let Some(i) = width_obj.payload::\u003cPyInt>() {\r\n let i = i.try_to_primitive::\u003ci32>(vm)?.unsigned_abs();\r\n Ok(CFormatQuantity::Amount(i as usize))\r\n}\r\n```\r\n\r\nHowever, that assumption is false, as an amount can be preceded by a negative sign, and it should make the resulting string left adjusted, according to format specifier rule.\r\nhttps://docs.python.org/3/library/stdtypes.html#old-string-formatting\r\n\r\n```python\r\nassert('%*s' % (-5, 'abc') == 'abc ')\r\n```\r\n\r\nThis issue makes this test to fail.\r\n\r\nI think this issue can be resolved by checking the sign of the element and adding the minus sign accordingly. \r\n\r\nI'm working on the fix at the moment.","author":{"url":"https://github.com/MegasKomnenos","@type":"Person","name":"MegasKomnenos"},"datePublished":"2023-03-25T10:20:35Z","url":"https://github.com/RustPython/RustPython/issues/4762"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:07e33223-8d52-85fd-8dd5-1e885433299d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8908:3CBF1A:201734C:2BEF32C:6B002722 |
| html-safe-nonce | 93c27f58fb7f31ef707f409feb6e6ce96608ab9514b479d843cdf3da436b3386 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTA4OjNDQkYxQToyMDE3MzRDOjJCRUYzMkM6NkIwMDI3MjIiLCJ2aXNpdG9yX2lkIjoiNTU4MjAyMTg5Mzc3NjQ4NDEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cb110eb507a8e1ceeca536b5e2277a9f2d3ee869b962d3b14610c40b919a9cc3 |
| hovercard-subject-tag | issue:1640463336 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/4762/issue_layout |
| twitter:image | https://opengraph.githubassets.com/32aea4ae5f14089cf9dfc2a922dc11a56a764d5f898dba52246645544413f629/RustPython/RustPython/issues/4762 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32aea4ae5f14089cf9dfc2a922dc11a56a764d5f898dba52246645544413f629/RustPython/RustPython/issues/4762 |
| og:image:alt | In string formatting, a print-f style format specifier can have its amount and precision formatted by variable value through use of star asterik(%*s). In cformat_bytes and cformat_string, through t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MegasKomnenos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width