Title: [RFC] Rust name or Python name? · Issue #3284 · RustPython/RustPython · GitHub
Open Graph Title: [RFC] Rust name or Python name? · Issue #3284 · RustPython/RustPython
X Title: [RFC] Rust name or Python name? · Issue #3284 · RustPython/RustPython
Description: Summary This is only about python objects like #[pymodule], #[pyclass], #[pyfunction], #[pymethod] and #[pyproperty]. Sometimes python names are not fit for rust naming convention. Though we can specify the name with (name = "") attribut...
Open Graph Description: Summary This is only about python objects like #[pymodule], #[pyclass], #[pyfunction], #[pymethod] and #[pyproperty]. Sometimes python names are not fit for rust naming convention. Though we can sp...
X Description: Summary This is only about python objects like #[pymodule], #[pyclass], #[pyfunction], #[pymethod] and #[pyproperty]. Sometimes python names are not fit for rust naming convention. Though we can sp...
Opengraph URL: https://github.com/RustPython/RustPython/issues/3284
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[RFC] Rust name or Python name?","articleBody":"## Summary\r\n\r\nThis is only about python objects like `#[pymodule]`, `#[pyclass]`, `#[pyfunction]`, `#[pymethod]` and `#[pyproperty]`.\r\nSometimes python names are not fit for rust naming convention.\r\n\r\n1. Though we can specify the name with `(name = \"\")` attributes, we also need to decide how we give names for its rust side API.\r\n2. There are also python names conflict to rust keywords. They also need a special rule because we normally cannot name them same in Rust.\r\n\r\n## Detailed Explanation\r\n\r\nList of unmatching names.\r\n\r\n1. Python type `int` is type `PyInt` in Rust API.\r\n2. Python function `posix.WIFSIGNALED` is `posix::wifsignaled` in Rust.\r\n3. Python type `_struct.error` is PyTypeRef object `pystruct::error_type` in Rust.\r\n4. Python type `_weakref.ReferenceType` is a function returning PyTypeRef `_weakref::reference_type` in Rust.\r\n4. Python variable `sys.api_version` is const `sys::API_VERSION` in Rust.\r\n5. Python variable `dis.COMPILER_FLAG_NAMES` is a function returning PyDictRef `dis::compiler_flag_names` in Rust.\r\n\r\nWe must handle types differently.\r\nFor example, we can expose `\u0026PyTypeRef` for `builtins::int()` but `PyInt` through `builtins::PyInt`.\r\n\r\nWe can choose one of these kind of options for other names:\r\n1. Strictly follow Python names unless it is impossible.\r\n - The names will not conflict.\r\n - Some names will be `r#` prefixed in Rust. They would need human-friendly aliases.\r\n2. Follow Python names as much as possible but with exceptions by its paired Rust type.\r\n - For example, `_weakref.ReferenceType` and `int` are both type in Python but `PyTypeRef` instance and `PyInt` struct for each in Rust. Similar for sys.api_version and dis.COMPILER_FLAG_NAMES\r\n3. Export a python-name aliased module separately. This can be generated by `derive` macros.\r\n - For this choice, we can optionally suggest more consistency.\r\n 1. We can expose variable always through a function call. A function to return a const will be generated.\r\n 2. We can attach emitted `vm` parameter again to functions.\r\n - Still types will be problem.\r\n\r\nList of keyword conflict.\r\n1. `struct` module.\r\n - The exact python name is `_struct`\r\n2. `mod` operator.\r\n - The exact python name is `__mod__`\r\n3. `match` function.\r\n4. `type` type.\r\n5. `enum` module.\r\n\r\nList of confusing non-keyword names.\r\n1. `bool` types\r\n2. `str` types\r\n3. `Iterator` for python and rust\r\n\r\nExample of solutions\r\n1. Always keep python name using `r#`. But allow alias.\r\n2. Add additional `_` suffix for conflicting type. `match` will be `match_`. But allow `r#` alias.\r\n3. Add `py` prefix like current `pybool`, `pytype`, `pystruct`.\r\n\r\n\u003c!-- Elaborate on your suggestion in all its details --\u003e\r\n\r\n## Drawbacks, Rationale, and Alternatives\r\n\r\n\u003c!-- What drawbacks might this solution have? Why do you feel it is necessary? What other options might there be to solving this problem? --\u003e\r\n\r\n## Unresolved Questions\r\n\r\n\u003c!-- What would you like feedback on for fleshing out your suggestion? --\u003e\r\nEverything. Any dicision will give concrete idea about public API design.","author":{"url":"https://github.com/youknowone","@type":"Person","name":"youknowone"},"datePublished":"2021-10-12T20:08:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/3284/RustPython/issues/3284"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6d350465-2bd4-915d-5a4e-d28c0a7f6d16 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 912C:62C58:6F1574:9D7626:696F8729 |
| html-safe-nonce | f64b329a1a793e81a250533d40f4098babb01ed791e84ce40e33612221ad5e4e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTJDOjYyQzU4OjZGMTU3NDo5RDc2MjY6Njk2Rjg3MjkiLCJ2aXNpdG9yX2lkIjoiNTE3NzI0ODQ2MDQ4OTg1MjcxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5a69d520abdbc63c422e49c007bb46f93e710a099faed05b6392245c75e241db |
| hovercard-subject-tag | issue:1024289890 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/3284/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fd134f7ec733232ee6747153000dcf01ddb1770883b480cbb5b222fc7f74751f/RustPython/RustPython/issues/3284 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fd134f7ec733232ee6747153000dcf01ddb1770883b480cbb5b222fc7f74751f/RustPython/RustPython/issues/3284 |
| og:image:alt | Summary This is only about python objects like #[pymodule], #[pyclass], #[pyfunction], #[pymethod] and #[pyproperty]. Sometimes python names are not fit for rust naming convention. Though we can sp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | c1b02b4e3a8edff2fe0bd71b0551654be66034591c7ab65aaaaf61a6096862d3 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a1073fcc34432ac33cec03885ff2d96920686de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width