Title: Some failures in whats_left.sh: method inheritance not as expected · Issue #2732 · RustPython/RustPython · GitHub
Open Graph Title: Some failures in whats_left.sh: method inheritance not as expected · Issue #2732 · RustPython/RustPython
X Title: Some failures in whats_left.sh: method inheritance not as expected · Issue #2732 · RustPython/RustPython
Description: Feature The whats_left.sh script generates a list of incompatibilities by comparing signatures with inspect.signature(). I think one source of mismatches is because of how builtin object inherit (or don't inherit) from object. I don't ye...
Open Graph Description: Feature The whats_left.sh script generates a list of incompatibilities by comparing signatures with inspect.signature(). I think one source of mismatches is because of how builtin object inherit (o...
X Description: Feature The whats_left.sh script generates a list of incompatibilities by comparing signatures with inspect.signature(). I think one source of mismatches is because of how builtin object inherit (o...
Opengraph URL: https://github.com/RustPython/RustPython/issues/2732
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Some failures in whats_left.sh: method inheritance not as expected","articleBody":"## Feature\r\n\r\nThe `whats_left.sh` script generates a list of incompatibilities by comparing signatures with `inspect.signature()`. I think one source of mismatches is because of how builtin object inherit (or don't inherit) from `object`. I don't yet understand how RustPython is doing this so I'm documenting the issue here, but I could write a PR with some help.\r\n\r\n### Description\r\n\r\nAs an example: `sys.__loader__` is listed by `whats_left` because `signature()` returns a ValueError. The CPython signature is `()`, which is the default signature of `object`.\r\n\r\nIn both CPython and RustPython `inspect.signature` is calling `inspect._signature_from_callable()` ([code](https://github.com/RustPython/RustPython/blob/master/Lib/inspect.py#L2206)), which eventually gets to [this block](https://github.com/RustPython/RustPython/blob/master/Lib/inspect.py#L2367-L2373).\r\n\r\nThe class is an instance of `_frozen_importlib.BuiltinImporter` which has no `__init__` or `__new__` method defined. In CPython, both of those methods are the same as the `object` methods (using the `is` test, e.g. the same memory address). In RustPython the `__new__` method is different. I would guess that something about the class definition is creating a separate `__new__` method even though there shouldn't be one.","author":{"url":"https://github.com/jamestwebber","@type":"Person","name":"jamestwebber"},"datePublished":"2021-07-11T16:39:21Z","url":"https://github.com/RustPython/RustPython/issues/2732"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:adc8a223-70ce-38d0-fd49-6a233fc1a034 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 82FA:34CAB:3BEB440:4C94FC8:6B02153D |
| html-safe-nonce | 3f9888958d29e77a6f283c9ff9c20839605d8787cf9710b502f687c3ed985ee8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkZBOjM0Q0FCOjNCRUI0NDA6NEM5NEZDODo2QjAyMTUzRCIsInZpc2l0b3JfaWQiOiIyNzc5MTMzNjM2NjM1NjYxNjI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 75a8c9b1b49295c9a52c52dd16af024fb0f27c3209a3f003ea2145c90537478e |
| hovercard-subject-tag | issue:941490203 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/2732/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ac5897f389fcd25dfad4d9a2e450b5e80dd9502325369662f52e663ba3026c96/RustPython/RustPython/issues/2732 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ac5897f389fcd25dfad4d9a2e450b5e80dd9502325369662f52e663ba3026c96/RustPython/RustPython/issues/2732 |
| og:image:alt | Feature The whats_left.sh script generates a list of incompatibilities by comparing signatures with inspect.signature(). I think one source of mismatches is because of how builtin object inherit (o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jamestwebber |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width