René's URL Explorer Experiment


Title: `round(number, digits)` is incorrect for non-zero `digits` · Issue #1554 · RustPython/RustPython · GitHub

Open Graph Title: `round(number, digits)` is incorrect for non-zero `digits` · Issue #1554 · RustPython/RustPython

X Title: `round(number, digits)` is incorrect for non-zero `digits` · Issue #1554 · RustPython/RustPython

Description: round with non-zero digits is notoriously hard to implement correctly, and I think #1521 underestimates the difficulty. The following script produces a lot of counterexamples in RustPython but none in Python 3 (at least after 10M trials)...

Open Graph Description: round with non-zero digits is notoriously hard to implement correctly, and I think #1521 underestimates the difficulty. The following script produces a lot of counterexamples in RustPython but none...

X Description: round with non-zero digits is notoriously hard to implement correctly, and I think #1521 underestimates the difficulty. The following script produces a lot of counterexamples in RustPython but none...

Opengraph URL: https://github.com/RustPython/RustPython/issues/1554

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`round(number, digits)` is incorrect for non-zero `digits`","articleBody":"`round` with non-zero digits is [notoriously hard to implement correctly](https://news.ycombinator.com/item?id=20816827), and I think #1521 underestimates the difficulty. The following script produces a lot of counterexamples in RustPython but none in Python 3 (at least after 10M trials):\r\n\r\n```python\r\nfrom random import random\r\n\r\ntrial = 0\r\nwhile True:\r\n    trial += 1\r\n    if trial % 10000 == 0: print(trial)\r\n\r\n    num = random()\r\n\r\n    # produces a single integral digit, `.` and 52+ fractional digits.\r\n    # unlike str, `%f` retains fractional digits of the true value.\r\n    #\r\n    # note: while not specified, the implementation of `random.random`\r\n    # ensures that those fractional digits contain all significant digits.\r\n    # this is pretty important for determining a midpoint for Banker's rounding;\r\n    # if it's not the case, simply change the number of frac digits to 1100+.\r\n    num_str = '%.60f' % num\r\n\r\n    # TODO: RustPython doesn't yet have random.randint\r\n    digits = int(1 + random() * 16)\r\n\r\n    # same to `int(num_str * 10**digits)`, but exact\r\n    scaled = int(num_str[0] + num_str[2:2+digits], 10)\r\n\r\n    # same to `round(num_str * 10**digits)`, but exact\r\n    scaled_and_rounded = scaled\r\n    if num_str[2+digits] >= '5':\r\n        # Banker's rounding: when `num` is equally close to both rounded values, prefer even\r\n        is_midpoint = all(c == '0' for c in num_str[3+digits:])\r\n        if not is_midpoint or scaled % 2 != 0: scaled_and_rounded += 1\r\n\r\n    # simulate `round(num, digits)`\r\n    scaled_and_rounded_str = ('%0' + str(1+digits) + 'd') % scaled_and_rounded\r\n    rounded = float(scaled_and_rounded_str[0] + '.' + scaled_and_rounded_str[1:])\r\n\r\n    rounded_impl = round(num, digits)\r\n    if rounded != rounded_impl:\r\n        print(f'failed: round({num_str[:2+digits]}_{num_str[2+digits:5+digits]}..., {digits}) = expected {rounded}, got {rounded_impl}')\r\n```\r\n\r\nExample output in RustPython:\r\n\r\n```\r\nfailed: round(0.3965324291450832_427..., 16) = expected 0.3965324291450832, got 0.3965324291450833\r\nfailed: round(0.289032886419551_493..., 15) = expected 0.289032886419551, got 0.289032886419552\r\nfailed: round(0.3364255023393837_307..., 16) = expected 0.3364255023393837, got 0.3364255023393838\r\nfailed: round(0.1182629781749734_432..., 16) = expected 0.1182629781749734, got 0.1182629781749735\r\nfailed: round(0.2254041491428512_289..., 16) = expected 0.2254041491428512, got 0.2254041491428513\r\nfailed: round(0.781000838713878_486..., 15) = expected 0.781000838713878, got 0.781000838713879\r\n```\r\n\r\nIt should be noted that the string representation of `round(num, digits)` doesn't need to be correctly rounded. In fact, it might not be possible at all. Python's implementation only tries to return *a* floating point number closest to the true rounded value and probably it is the best possible result when you have to return floating point numbers.\r\n\r\nImplementation-wise I think there is no way easier than converting a number to the stringy value and back, as Python does. Note that the stringy value doesn't need to be an actual string, it just has to be a value that can be easily converted to decimal digits. (Rust has an unstable interface to those stringy values, but they are exposed just for tests.) As we have BigInts as a given, we probably should make use of them.","author":{"url":"https://github.com/lifthrasiir","@type":"Person","name":"lifthrasiir"},"datePublished":"2019-10-21T13:07:50Z","url":"https://github.com/RustPython/RustPython/issues/1554"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4cf72fbe-c5b8-4050-b5fa-d3f6ad6d1585
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC1C2:2F9718:2FA4DAA:3FE59C7:6B01F308
html-safe-nonceb24ebe1b67a2acda09573a08979727094da8961d6159a73615e9e9de0fcbbf26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUMyOjJGOTcxODoyRkE0REFBOjNGRTU5Qzc6NkIwMUYzMDgiLCJ2aXNpdG9yX2lkIjoiNzI5OTI5NTg5MDU1NTEzODgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac609060795375157ea4a2379ee6938c89a4e360b83a91d3b117cd2c601486a692
hovercard-subject-tagissue:509950710
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/1554/issue_layout
twitter:imagehttps://opengraph.githubassets.com/89643c2d23a911a4c0fcd729a2639bc2f85e6e85318e191c818909dfd1a2ed3e/RustPython/RustPython/issues/1554
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/89643c2d23a911a4c0fcd729a2639bc2f85e6e85318e191c818909dfd1a2ed3e/RustPython/RustPython/issues/1554
og:image:altround with non-zero digits is notoriously hard to implement correctly, and I think #1521 underestimates the difficulty. The following script produces a lot of counterexamples in RustPython but none...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelifthrasiir
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/RustPython/RustPython/issues/1554#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fissues%2F1554
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fissues%2F1554
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/issues/1554
Reloadhttps://github.com/RustPython/RustPython/issues/1554
Reloadhttps://github.com/RustPython/RustPython/issues/1554
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
New issuehttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/1554
New issuehttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/1554
round(number, digits) is incorrect for non-zero digitshttps://github.com/RustPython/RustPython/issues/1554#top
A-stdlibhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22A-stdlib%22
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
https://github.com/lifthrasiir
lifthrasiirhttps://github.com/lifthrasiir
on Oct 21, 2019https://github.com/RustPython/RustPython/issues/1554#issue-509950710
notoriously hard to implement correctlyhttps://news.ycombinator.com/item?id=20816827
#1521https://github.com/RustPython/RustPython/pull/1521
lifthrasiirhttps://github.com/lifthrasiir
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
on Oct 21, 2019https://github.com/RustPython/RustPython/issues/1554#event-2729587728
youknowonehttps://github.com/youknowone
A-stdlibhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22A-stdlib%22
on Apr 18, 2022https://github.com/RustPython/RustPython/issues/1554#event-6447375284
https://github.com/youknowone
youknowonehttps://github.com/youknowone
on Jul 9, 2026https://github.com/RustPython/RustPython/issues/1554#issuecomment-4925075469
#7761https://github.com/RustPython/RustPython/pull/7761
youknowonehttps://github.com/youknowone
completedhttps://github.com/RustPython/RustPython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 9, 2026https://github.com/RustPython/RustPython/issues/1554#event-27764686706
Sign up for freehttps://github.com/signup?return_to=https://github.com/RustPython/RustPython/issues/1554
Sign in to commenthttps://github.com/login?return_to=https://github.com/RustPython/RustPython/issues/1554
A-stdlibhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22A-stdlib%22
C-compatA discrepancy between RustPython and CPythonhttps://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3A%22C-compat%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.