Title: Removing the old import · Issue #1100 · RustPython/RustPython · GitHub
Open Graph Title: Removing the old import · Issue #1100 · RustPython/RustPython
X Title: Removing the old import · Issue #1100 · RustPython/RustPython
Description: Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import to work (_io, _thread). For example in ...
Open Graph Description: Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import...
X Description: Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import...
Opengraph URL: https://github.com/RustPython/RustPython/issues/1100
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Removing the old import","articleBody":"Now that we can import using `importlib` I would like to remove the old import (`import::import_module`). The problem is that some of the modules that use the old import are needed for `importlib` import to work (`_io`, `_thread`). For example in `io_open` we import `io` using the old import so we can create an instance of `FileIO`. We can't use the new import as in that phase it is not initialized yet.\r\nHow do you think we should solve this problem? Should we remove all use of `import` in the modules used by `importlib`? This will require us to have a struct that implements `PyValue` for every class.","author":{"url":"https://github.com/palaviv","@type":"Person","name":"palaviv"},"datePublished":"2019-07-03T15:23:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1100/RustPython/issues/1100"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:724cd40e-9eee-2352-620e-2a63cd2002d0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B0C4:182F17:69D898:968CA7:6A5A0458 |
| html-safe-nonce | 8fb6c527024b1741d8cf47cbd7020e7dc9fa578c830019c8e02e6f6454c7a2e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEM0OjE4MkYxNzo2OUQ4OTg6OTY4Q0E3OjZBNUEwNDU4IiwidmlzaXRvcl9pZCI6IjMyMDI1MzMyMjIwNjEzMTEwNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ba3865a47f6b927f1fe496fd255c6bcd3916fce24c63f78dabe9aac49c9aacc2 |
| hovercard-subject-tag | issue:463815628 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/RustPython/RustPython/1100/issue_layout |
| twitter:image | https://opengraph.githubassets.com/20f1a85553b394d4ec0fd3f3470483649544f49d7323b0754fbff05d7ca31141/RustPython/RustPython/issues/1100 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/20f1a85553b394d4ec0fd3f3470483649544f49d7323b0754fbff05d7ca31141/RustPython/RustPython/issues/1100 |
| og:image:alt | Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | palaviv |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8c2fe7351e4e987cb8f75e2425a0b895d807779bc4c2d3c312be0a54082219f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 491710c7a8eecca9d0a06bd157646f2685d8c87b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width