Title: Fix strict linking on MacOS by jeroen · Pull Request #207 · RcppCore/RcppParallel · GitHub
Open Graph Title: Fix strict linking on MacOS by jeroen · Pull Request #207 · RcppCore/RcppParallel
X Title: Fix strict linking on MacOS by jeroen · Pull Request #207 · RcppCore/RcppParallel
Description: Fixes #206. This basically does the same as you already did on Windows here: RcppParallel/src/Makevars.in Lines 87 to 89 in 6f81716 # Linker needs access to the tbb dll; otherwise you get errors such as: # "undefined reference to `tbb::task_scheduler_init::terminate()'" PKG_LIBS += -Ltbb/build/lib_release -ltbb -ltbbmalloc And likewise in tbbLdFlags(). In my own fork I added CI for Mac, so you can see that it failed on MacOS before this fix, and then passed afterwards: https://github.com/jeroen/RcppParallel/commits/master/
Open Graph Description: Fixes #206. This basically does the same as you already did on Windows here: RcppParallel/src/Makevars.in Lines 87 to 89 in 6f81716 ...
X Description: Fixes #206. This basically does the same as you already did on Windows here: RcppParallel/src/Makevars.in Lines 87 to 89 in 6f81716 ...
Opengraph URL: https://github.com/RcppCore/RcppParallel/pull/207
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:58b464ed-3199-0580-e869-8b15200a0935 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C170:2B2A66:6E1FBE:9A9CD6:6970AFAE |
| html-safe-nonce | eadd130cb7dedae593ca2b7cabbe71e168c1d43b85ada1dac07d6c0d837c3de6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTcwOjJCMkE2Njo2RTFGQkU6OUE5Q0Q2OjY5NzBBRkFFIiwidmlzaXRvcl9pZCI6IjQ2MzkyNjE1NDg0ODI3MDMyNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 43856f418a83de6a4822532266e07c4fa909b561f0f5c1537324a4246220710c |
| hovercard-subject-tag | pull_request:1663153642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RcppCore/RcppParallel/pull/207/checks |
| twitter:image | https://avatars.githubusercontent.com/u/216319?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/216319?s=400&v=4 |
| og:image:alt | Fixes #206. This basically does the same as you already did on Windows here: RcppParallel/src/Makevars.in Lines 87 to 89 in 6f81716 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8e0be80373b724b033cdf8a7b1f78bf5fb6a5d7a2182a9a403aa30894606e390 |
| turbo-cache-control | no-preview |
| go-import | github.com/RcppCore/RcppParallel git https://github.com/RcppCore/RcppParallel.git |
| octolytics-dimension-user_id | 5811336 |
| octolytics-dimension-user_login | RcppCore |
| octolytics-dimension-repository_id | 21576989 |
| octolytics-dimension-repository_nwo | RcppCore/RcppParallel |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21576989 |
| octolytics-dimension-repository_network_root_nwo | RcppCore/RcppParallel |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b8714db0002cf78dc2d2566571807e404d6cb817 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width