Title: Minor improvements by Tran-Antoine · Pull Request #17 · RLBot/RLBotJavaExample · GitHub
Open Graph Title: Minor improvements by Tran-Antoine · Pull Request #17 · RLBot/RLBotJavaExample
X Title: Minor improvements by Tran-Antoine · Pull Request #17 · RLBot/RLBotJavaExample
Description: This pull request brings a couple of changes in the example. They are not related to performance, but they rather improve the readability and the cleanliness of the code. In a nutshell, these changes are: Usage of a proper builder for the ControlsOutput class, instead of the withXXX methods directly in it. This should not affect performances since a single builder is created at runtime and is simply updated whenever a new building process occurs Addition of @Override annotations, which lead to better readability. It makes clearer the fact that the given method initially belongs to an upper class Generification of field declarations/return types. To respect the abstraction principle, it seems better in my opinion to declare Lists instead of ArrayLists Addition of toString() methods for Vector2 and Vector3, to ease the debugging Usage of primitives instead of wrappers (int instead of Integer), to avoid double object creation
Open Graph Description: This pull request brings a couple of changes in the example. They are not related to performance, but they rather improve the readability and the cleanliness of the code. In a nutshell, these chang...
X Description: This pull request brings a couple of changes in the example. They are not related to performance, but they rather improve the readability and the cleanliness of the code. In a nutshell, these chang...
Opengraph URL: https://github.com/RLBot/RLBotJavaExample/pull/17
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:3fabc474-c0b2-e176-dc33-198f401f35d5 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 8FE2:14F335:870235:B417B6:69740B87 |
| html-safe-nonce | 76cf711c997b29fd8252f3732d83475bfadf39f08121fdfb9bf6d81810919142 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkUyOjE0RjMzNTo4NzAyMzU6QjQxN0I2OjY5NzQwQjg3IiwidmlzaXRvcl9pZCI6IjM0MDExNzIyNDY4NTA3MDIyMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f9166c6b03d1553ccac14ad8f898e3a4150101b3928bab61041504acc3885958 |
| hovercard-subject-tag | pull_request:342423866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RLBot/RLBotJavaExample/pull/17/checks |
| twitter:image | https://avatars.githubusercontent.com/u/31257370?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31257370?s=400&v=4 |
| og:image:alt | This pull request brings a couple of changes in the example. They are not related to performance, but they rather improve the readability and the cleanliness of the code. In a nutshell, these chang... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 59b702da6e0daafaa39128183fb631c1ac58292fa7c764b7482070a04fb5b4a1 |
| turbo-cache-control | no-preview |
| go-import | github.com/RLBot/RLBotJavaExample git https://github.com/RLBot/RLBotJavaExample.git |
| octolytics-dimension-user_id | 36465262 |
| octolytics-dimension-user_login | RLBot |
| octolytics-dimension-repository_id | 125761265 |
| octolytics-dimension-repository_nwo | RLBot/RLBotJavaExample |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 125761265 |
| octolytics-dimension-repository_network_root_nwo | RLBot/RLBotJavaExample |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3cb518f5e73629eee4767718742673274eb03bd7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width