René's URL Explorer Experiment


Title: Fix min/max functions with generators, and 'None' default by gazpachoking · Pull Request #514 · PythonCharmers/python-future · GitHub

Open Graph Title: Fix min/max functions with generators, and 'None' default by gazpachoking · Pull Request #514 · PythonCharmers/python-future

X Title: Fix min/max functions with generators, and 'None' default by gazpachoking · Pull Request #514 · PythonCharmers/python-future

Description: I allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses: There is an issue with the min/max functions consuming the first argument of iterators that cann...

Open Graph Description: I allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses: There is an issue with the min/max functions consuming the first argument of iterators that cann...

X Description: I allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses: There is an issue with the min/max functions consuming the first argument of iterators that cann...

Opengraph URL: https://github.com/PythonCharmers/python-future/pull/514

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e26304e8-4907-a4a2-a6ae-13ac98de32ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC2A:18C2EF:7EE9B3:A8A8BE:69697911
html-safe-nonce13676790a0df98346073c218176fef74b6be45ebc6ea379a7567601839a8b735
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzJBOjE4QzJFRjo3RUU5QjM6QThBOEJFOjY5Njk3OTExIiwidmlzaXRvcl9pZCI6IjkwNTIzODE4MDEzNjIzMjM3MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac27ac261813b527708d47ada9d3c0c3f99127e497a7e916b34259b188e49da44f
hovercard-subject-tagpull_request:329454596
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PythonCharmers/python-future/514/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90587d591361bb413db75e3ce7537c45851d1ec2a2bb73db1163bb74c5b1ffec/PythonCharmers/python-future/pull/514
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90587d591361bb413db75e3ce7537c45851d1ec2a2bb73db1163bb74c5b1ffec/PythonCharmers/python-future/pull/514
og:image:altI allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses: There is an issue with the min/max functions consuming the first argument of iterators that cann...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegazpachoking
hostnamegithub.com
expected-hostnamegithub.com
Nonec6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881
turbo-cache-controlno-preview
go-importgithub.com/PythonCharmers/python-future git https://github.com/PythonCharmers/python-future.git
octolytics-dimension-user_id3365815
octolytics-dimension-user_loginPythonCharmers
octolytics-dimension-repository_id11403699
octolytics-dimension-repository_nwoPythonCharmers/python-future
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id11403699
octolytics-dimension-repository_network_root_nwoPythonCharmers/python-future
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release212e3e3d3298bf5b313830edfd2399e869f7ea76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PythonCharmers/python-future/pull/514#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PythonCharmers%2Fpython-future
Reloadhttps://github.com/PythonCharmers/python-future/pull/514
Reloadhttps://github.com/PythonCharmers/python-future/pull/514
Reloadhttps://github.com/PythonCharmers/python-future/pull/514
PythonCharmers https://github.com/PythonCharmers
python-futurehttps://github.com/PythonCharmers/python-future
Notifications https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future
Fork 295 https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future
Star 1.2k https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future
Code https://github.com/PythonCharmers/python-future
Issues 184 https://github.com/PythonCharmers/python-future/issues
Pull requests 5 https://github.com/PythonCharmers/python-future/pulls
Actions https://github.com/PythonCharmers/python-future/actions
Projects 0 https://github.com/PythonCharmers/python-future/projects
Wiki https://github.com/PythonCharmers/python-future/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/PythonCharmers/python-future/security
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
Insights https://github.com/PythonCharmers/python-future/pulse
Code https://github.com/PythonCharmers/python-future
Issues https://github.com/PythonCharmers/python-future/issues
Pull requests https://github.com/PythonCharmers/python-future/pulls
Actions https://github.com/PythonCharmers/python-future/actions
Projects https://github.com/PythonCharmers/python-future/projects
Wiki https://github.com/PythonCharmers/python-future/wiki
Security https://github.com/PythonCharmers/python-future/security
Insights https://github.com/PythonCharmers/python-future/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPythonCharmers%2Fpython-future%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPythonCharmers%2Fpython-future%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/PythonCharmers/python-future/pull/514#issue-comment-box
jmadlerhttps://github.com/jmadler
PythonCharmers:masterhttps://github.com/PythonCharmers/python-future/tree/master
gazpachoking:fix_min_maxhttps://github.com/gazpachoking/python-future/tree/fix_min_max
Fix min/max functions with generators, and 'None' default https://github.com/PythonCharmers/python-future/pull/514#top
jmadlerhttps://github.com/jmadler
PythonCharmers:masterhttps://github.com/PythonCharmers/python-future/tree/master
gazpachoking:fix_min_maxhttps://github.com/gazpachoking/python-future/tree/fix_min_max
Conversation 4 https://github.com/PythonCharmers/python-future/pull/514
Commits 5 https://github.com/PythonCharmers/python-future/pull/514/commits
Checks 0 https://github.com/PythonCharmers/python-future/pull/514/checks
Files changed https://github.com/PythonCharmers/python-future/pull/514/files
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.co/hiddenchars
https://github.com/PythonCharmers/python-future/pull/{{ revealButtonHref }}
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
Oct 17, 2019https://github.com/PythonCharmers/python-future/pull/514#issue-508711719
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
max() over itertools.ifilter() is broken in 0.18.0 #510https://github.com/PythonCharmers/python-future/issues/510
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
Oct 17, 2019https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543375994
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/gazpachoking
Add test for min/max with generators.https://github.com/PythonCharmers/python-future/pull/514/commits/f60f67269a861c3ff19dbee17342789a49a02cde
f60f672https://github.com/PythonCharmers/python-future/pull/514/commits/f60f67269a861c3ff19dbee17342789a49a02cde
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
force-pushedhttps://github.com/PythonCharmers/python-future/compare/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c..f60f67269a861c3ff19dbee17342789a49a02cde
a6b1b8ahttps://github.com/PythonCharmers/python-future/commit/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c
f60f672https://github.com/PythonCharmers/python-future/commit/f60f67269a861c3ff19dbee17342789a49a02cde
Compare https://github.com/PythonCharmers/python-future/compare/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c..f60f67269a861c3ff19dbee17342789a49a02cde
October 18, 2019 01:17https://github.com/PythonCharmers/python-future/pull/514#event-2723218120
https://github.com/gazpachoking
Fix behavior of new min/max with generators.https://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172
fixhttps://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172
PythonCharmers#510https://github.com/PythonCharmers/python-future/issues/510
03f94a3https://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
October 18, 2019 01:52https://github.com/PythonCharmers/python-future/pull/514#event-2723267601
gazpachokinghttps://github.com/gazpachoking
October 18, 2019 09:24https://github.com/PythonCharmers/python-future/pull/514#commits-pushed-b64245c
https://github.com/gazpachoking
Move max test to appropriate test methodhttps://github.com/PythonCharmers/python-future/pull/514/commits/b64245c8444d93aee6862bb0cd2361ddfe431eea
b64245chttps://github.com/PythonCharmers/python-future/pull/514/commits/b64245c8444d93aee6862bb0cd2361ddfe431eea
https://github.com/gazpachoking
Fix min/max functions not allowing 'None' as defaulthttps://github.com/PythonCharmers/python-future/pull/514/commits/dbc74ad81b384897970edd65fef1bc53ddee5acb
dbc74adhttps://github.com/PythonCharmers/python-future/pull/514/commits/dbc74ad81b384897970edd65fef1bc53ddee5acb
https://github.com/gazpachoking
Make new min/max error message consistent builtin error messagehttps://github.com/PythonCharmers/python-future/pull/514/commits/f4926e51c940ef9afb4c94038c48b8a5382d04a2
f4926e5https://github.com/PythonCharmers/python-future/pull/514/commits/f4926e51c940ef9afb4c94038c48b8a5382d04a2
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
Oct 18, 2019https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543775748
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
Oct 18, 2019https://github.com/PythonCharmers/python-future/pull/514#event-2725141334
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
Oct 18, 2019https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543778794
https://travis-ci.org/PythonCharmers/python-future/builds/599676065https://travis-ci.org/PythonCharmers/python-future/builds/599676065
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/megies
megieshttps://github.com/megies
Oct 21, 2019 https://github.com/PythonCharmers/python-future/pull/514#ref-issue-508086275
max() over itertools.ifilter() is broken in 0.18.0 #510 https://github.com/PythonCharmers/python-future/issues/510
https://github.com/megies
megieshttps://github.com/megies
Oct 21, 2019https://github.com/PythonCharmers/python-future/pull/514#issuecomment-544540386
#510https://github.com/PythonCharmers/python-future/issues/510
#510 (comment)https://github.com/PythonCharmers/python-future/issues/510#issuecomment-544539787
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/megies
megieshttps://github.com/megies
Oct 21, 2019 https://github.com/PythonCharmers/python-future/pull/514#ref-issue-510003249
Current CI test fails in min/max caused by recent future obspy/obspy#2486 https://github.com/obspy/obspy/issues/2486
https://github.com/jmadler
jmadlerhttps://github.com/jmadler
228a297https://github.com/PythonCharmers/python-future/commit/228a29765a66d8beebf403592a9be977e78f3716
Oct 24, 2019https://github.com/PythonCharmers/python-future/pull/514#event-2742511018
https://github.com/gazpachoking
gazpachokinghttps://github.com/gazpachoking
December 6, 2019 04:28https://github.com/PythonCharmers/python-future/pull/514#event-2860125732
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514
Please reload this pagehttps://github.com/PythonCharmers/python-future/pull/514
https://github.com/gazpachoking
https://github.com/megies
https://github.com/jmadler
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.