| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e26304e8-4907-a4a2-a6ae-13ac98de32ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC2A:18C2EF:7EE9B3:A8A8BE:69697911 |
| html-safe-nonce | 13676790a0df98346073c218176fef74b6be45ebc6ea379a7567601839a8b735 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzJBOjE4QzJFRjo3RUU5QjM6QThBOEJFOjY5Njk3OTExIiwidmlzaXRvcl9pZCI6IjkwNTIzODE4MDEzNjIzMjM3MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 27ac261813b527708d47ada9d3c0c3f99127e497a7e916b34259b188e49da44f |
| hovercard-subject-tag | pull_request:329454596 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PythonCharmers/python-future/514/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/90587d591361bb413db75e3ce7537c45851d1ec2a2bb73db1163bb74c5b1ffec/PythonCharmers/python-future/pull/514 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/90587d591361bb413db75e3ce7537c45851d1ec2a2bb73db1163bb74c5b1ffec/PythonCharmers/python-future/pull/514 |
| og:image:alt | I allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses:
There is an issue with the min/max functions consuming the first argument of iterators that cann... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gazpachoking |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881 |
| turbo-cache-control | no-preview |
| go-import | github.com/PythonCharmers/python-future git https://github.com/PythonCharmers/python-future.git |
| octolytics-dimension-user_id | 3365815 |
| octolytics-dimension-user_login | PythonCharmers |
| octolytics-dimension-repository_id | 11403699 |
| octolytics-dimension-repository_nwo | PythonCharmers/python-future |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 11403699 |
| octolytics-dimension-repository_network_root_nwo | PythonCharmers/python-future |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 212e3e3d3298bf5b313830edfd2399e869f7ea76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/PythonCharmers/python-future/pull/514#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PythonCharmers%2Fpython-future |
| Reload | https://github.com/PythonCharmers/python-future/pull/514 |
| Reload | https://github.com/PythonCharmers/python-future/pull/514 |
| Reload | https://github.com/PythonCharmers/python-future/pull/514 |
|
PythonCharmers
| https://github.com/PythonCharmers |
| python-future | https://github.com/PythonCharmers/python-future |
|
Notifications
| https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future |
|
Fork
295
| https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future |
|
Star
1.2k
| https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future |
|
Code
| https://github.com/PythonCharmers/python-future |
|
Issues
184
| https://github.com/PythonCharmers/python-future/issues |
|
Pull requests
5
| https://github.com/PythonCharmers/python-future/pulls |
|
Actions
| https://github.com/PythonCharmers/python-future/actions |
|
Projects
0
| https://github.com/PythonCharmers/python-future/projects |
|
Wiki
| https://github.com/PythonCharmers/python-future/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/PythonCharmers/python-future/security |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
|
Insights
| https://github.com/PythonCharmers/python-future/pulse |
|
Code
| https://github.com/PythonCharmers/python-future |
|
Issues
| https://github.com/PythonCharmers/python-future/issues |
|
Pull requests
| https://github.com/PythonCharmers/python-future/pulls |
|
Actions
| https://github.com/PythonCharmers/python-future/actions |
|
Projects
| https://github.com/PythonCharmers/python-future/projects |
|
Wiki
| https://github.com/PythonCharmers/python-future/wiki |
|
Security
| https://github.com/PythonCharmers/python-future/security |
|
Insights
| https://github.com/PythonCharmers/python-future/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FPythonCharmers%2Fpython-future%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FPythonCharmers%2Fpython-future%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/PythonCharmers/python-future/pull/514#issue-comment-box |
| jmadler | https://github.com/jmadler |
| PythonCharmers:master | https://github.com/PythonCharmers/python-future/tree/master |
| gazpachoking:fix_min_max | https://github.com/gazpachoking/python-future/tree/fix_min_max |
|
Fix min/max functions with generators, and 'None' default
| https://github.com/PythonCharmers/python-future/pull/514#top |
| jmadler | https://github.com/jmadler |
| PythonCharmers:master | https://github.com/PythonCharmers/python-future/tree/master |
| gazpachoking:fix_min_max | https://github.com/gazpachoking/python-future/tree/fix_min_max |
|
Conversation
4
| https://github.com/PythonCharmers/python-future/pull/514 |
|
Commits
5
| https://github.com/PythonCharmers/python-future/pull/514/commits |
|
Checks
0
| https://github.com/PythonCharmers/python-future/pull/514/checks |
|
Files changed
| https://github.com/PythonCharmers/python-future/pull/514/files |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| https://github.co/hiddenchars |
| https://github.com/PythonCharmers/python-future/pull/{{ revealButtonHref }} |
|
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| Oct 17, 2019 | https://github.com/PythonCharmers/python-future/pull/514#issue-508711719 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| max() over itertools.ifilter() is broken in 0.18.0 #510 | https://github.com/PythonCharmers/python-future/issues/510 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| Oct 17, 2019 | https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543375994 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
|
| https://github.com/gazpachoking |
| Add test for min/max with generators. | https://github.com/PythonCharmers/python-future/pull/514/commits/f60f67269a861c3ff19dbee17342789a49a02cde |
| f60f672 | https://github.com/PythonCharmers/python-future/pull/514/commits/f60f67269a861c3ff19dbee17342789a49a02cde |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| force-pushed | https://github.com/PythonCharmers/python-future/compare/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c..f60f67269a861c3ff19dbee17342789a49a02cde |
| a6b1b8a | https://github.com/PythonCharmers/python-future/commit/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c |
| f60f672 | https://github.com/PythonCharmers/python-future/commit/f60f67269a861c3ff19dbee17342789a49a02cde |
|
Compare
| https://github.com/PythonCharmers/python-future/compare/a6b1b8aa859f4c09f6a49f165e33130dbd67b73c..f60f67269a861c3ff19dbee17342789a49a02cde |
| October 18, 2019 01:17 | https://github.com/PythonCharmers/python-future/pull/514#event-2723218120 |
|
| https://github.com/gazpachoking |
| Fix behavior of new min/max with generators. | https://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172 |
| fix | https://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172 |
| PythonCharmers#510 | https://github.com/PythonCharmers/python-future/issues/510 |
| 03f94a3 | https://github.com/PythonCharmers/python-future/pull/514/commits/03f94a325251f4ef19d4b4caabc72a5a88c60172 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| October 18, 2019 01:52 | https://github.com/PythonCharmers/python-future/pull/514#event-2723267601 |
| gazpachoking | https://github.com/gazpachoking |
| October 18, 2019 09:24 | https://github.com/PythonCharmers/python-future/pull/514#commits-pushed-b64245c |
|
| https://github.com/gazpachoking |
| Move max test to appropriate test method | https://github.com/PythonCharmers/python-future/pull/514/commits/b64245c8444d93aee6862bb0cd2361ddfe431eea |
| b64245c | https://github.com/PythonCharmers/python-future/pull/514/commits/b64245c8444d93aee6862bb0cd2361ddfe431eea |
|
| https://github.com/gazpachoking |
| Fix min/max functions not allowing 'None' as default | https://github.com/PythonCharmers/python-future/pull/514/commits/dbc74ad81b384897970edd65fef1bc53ddee5acb |
| dbc74ad | https://github.com/PythonCharmers/python-future/pull/514/commits/dbc74ad81b384897970edd65fef1bc53ddee5acb |
|
| https://github.com/gazpachoking |
| Make new min/max error message consistent builtin error message | https://github.com/PythonCharmers/python-future/pull/514/commits/f4926e51c940ef9afb4c94038c48b8a5382d04a2 |
| f4926e5 | https://github.com/PythonCharmers/python-future/pull/514/commits/f4926e51c940ef9afb4c94038c48b8a5382d04a2 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| Oct 18, 2019 | https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543775748 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| Oct 18, 2019 | https://github.com/PythonCharmers/python-future/pull/514#event-2725141334 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| Oct 18, 2019 | https://github.com/PythonCharmers/python-future/pull/514#issuecomment-543778794 |
| https://travis-ci.org/PythonCharmers/python-future/builds/599676065 | https://travis-ci.org/PythonCharmers/python-future/builds/599676065 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| https://github.com/megies |
| megies | https://github.com/megies |
|
Oct 21, 2019
| https://github.com/PythonCharmers/python-future/pull/514#ref-issue-508086275 |
|
max() over itertools.ifilter() is broken in 0.18.0
#510
| https://github.com/PythonCharmers/python-future/issues/510 |
| https://github.com/megies |
| megies | https://github.com/megies |
| Oct 21, 2019 | https://github.com/PythonCharmers/python-future/pull/514#issuecomment-544540386 |
| #510 | https://github.com/PythonCharmers/python-future/issues/510 |
| #510 (comment) | https://github.com/PythonCharmers/python-future/issues/510#issuecomment-544539787 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
| https://github.com/megies |
| megies | https://github.com/megies |
|
Oct 21, 2019
| https://github.com/PythonCharmers/python-future/pull/514#ref-issue-510003249 |
|
Current CI test fails in min/max caused by recent future
obspy/obspy#2486
| https://github.com/obspy/obspy/issues/2486 |
| https://github.com/jmadler |
| jmadler | https://github.com/jmadler |
| 228a297 | https://github.com/PythonCharmers/python-future/commit/228a29765a66d8beebf403592a9be977e78f3716 |
| Oct 24, 2019 | https://github.com/PythonCharmers/python-future/pull/514#event-2742511018 |
| https://github.com/gazpachoking |
| gazpachoking | https://github.com/gazpachoking |
| December 6, 2019 04:28 | https://github.com/PythonCharmers/python-future/pull/514#event-2860125732 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPythonCharmers%2Fpython-future%2Fpull%2F514 |
| Please reload this page | https://github.com/PythonCharmers/python-future/pull/514 |
|
| https://github.com/gazpachoking |
|
| https://github.com/megies |
|
| https://github.com/jmadler |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |