Title: Make fuller use of Serilog · Issue #680 · PowerShell/PowerShellEditorServices · GitHub
Open Graph Title: Make fuller use of Serilog · Issue #680 · PowerShell/PowerShellEditorServices
X Title: Make fuller use of Serilog · Issue #680 · PowerShell/PowerShellEditorServices
Description: Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it. @SeeminglyScience suggested we should instead implement an ITextFormatter for the various things we want to lo...
Open Graph Description: Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it. @SeeminglyScience suggested we should instead implement an ITextFormat...
X Description: Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it. @SeeminglyScience suggested we should instead implement an ITextFormat...
Opengraph URL: https://github.com/PowerShell/PowerShellEditorServices/issues/680
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make fuller use of Serilog","articleBody":"Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it.\r\n\r\n@SeeminglyScience suggested we should instead implement an `ITextFormatter` for the various things we want to log.\r\n\r\nIn the original Serilog migration I made the following choices:\r\n* Contain Serilog references in a single part of the code\r\n* Maintain the old log level system rather than Serilog's\r\n* Use the `ILogger` interface still\r\n\r\nSerilog has fairly rich functionality but because of the way its named-argument string templating works, I'm not sure it can be used indirectly.\r\n\r\nBut a good use of Serilog would probably involve us using it directly, with its log levels, and ideally using the log-level-named methods (`logger.Verbose`, `logger.Error`, etc.).\r\n\r\nWith this, we would probably want to use Serilog's `ILogger` rather than our own implementation.\r\n\r\nWe should also migrate the testing away from writing a text file and toward making test sink for Serilog.","author":{"url":"https://github.com/rjmholt","@type":"Person","name":"rjmholt"},"datePublished":"2018-06-07T17:16:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/680/PowerShellEditorServices/issues/680"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1da4cfa5-a3fa-9a92-1ec2-7b3d58821bfc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C87C:1FE9B0:2814D:34003:6A580E4F |
| html-safe-nonce | 3acdbf9653238ead2f9e74f0a2d2fb6702af11128735704c6be8acc89e3fcedd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODdDOjFGRTlCMDoyODE0RDozNDAwMzo2QTU4MEU0RiIsInZpc2l0b3JfaWQiOiI3NTgwNzk2MTczMjAxOTY4NzE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b6e994124eeaa01d0cbe4d887a1cc0bb3b5ee00900d867ff0511881049ec7ca1 |
| hovercard-subject-tag | issue:330363156 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/PowerShell/PowerShellEditorServices/680/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1f45c23e45762fca934a92820741a82df977c168dfb7d6d99a6da963e8f34a7a/PowerShell/PowerShellEditorServices/issues/680 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f45c23e45762fca934a92820741a82df977c168dfb7d6d99a6da963e8f34a7a/PowerShell/PowerShellEditorServices/issues/680 |
| og:image:alt | Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it. @SeeminglyScience suggested we should instead implement an ITextFormat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rjmholt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShellEditorServices git https://github.com/PowerShell/PowerShellEditorServices.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 36031537 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShellEditorServices |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36031537 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShellEditorServices |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3fb1f684e7a833eb1b2d01d39875a2b52cb4fe9b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width