René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bring launch sequencing in line with DAP spec","articleBody":"### Prerequisites\r\n\r\n- [X] I have written a descriptive issue title.\r\n- [X] I have searched all [issues](https://github.com/PowerShell/PowerShellEditorServices/issues?q=is%3Aissue) to ensure it has not already been requested.\r\n\r\n### Summary\r\n\r\nCurrently, our DAP conversation doesn't follow the spec explicitly in terms of conversation.\r\n\r\nWhat is supposed to happen:\r\n1. Initialize is sent and server responds, then responds with capabilities\r\n1. Launch is sent by client after receiving capabilities. **should be held and deferred until configurationDone**\r\n1. Server sends initialized event (preferably when ready to receive launch requests)\r\n3. Client does config after initialized \r\n4. Configuration is done (breakpoints etc.)\r\n5. launch request is now responded to after configuration is completed\r\n\r\nIn actuality, we respond to the launch request immediately before configuration\r\n![image](https://github.com/user-attachments/assets/6d9ebc27-922a-4c0b-a6bb-b674ba0695fd)\r\n\r\nThe spec states:\r\n```\r\nOnce the debug adapter is ready to receive configuration from the client, it sends an initialized event to the client. As described above, the client sends zero or more configuration-related requests before sending a configurationDone request.\r\n\r\nAfter the response to configurationDone is sent, the debug adapter may respond to the launch or attach request, and then the debug session has started.\r\n```\r\n\r\n### Proposed Design\r\n\r\nWe need to hold the launch response until after configurationDone is completed. Fixing this would likely be part of a larger refactor to fix the odd behavior of scripts being started directly within configurationDone handler, rather than configurationDone triggering an event or otherwise to start/release any pending launch messages.\r\n\r\nAs part of this, because the spec currently does not allow multiplexing requests over a single adapter channel, the launch/attach should singleton and throw an error if any additional launch/attach requests are made until the existing one completes.\r\n\r\n### Implementation Idea\r\nWhen a launch task is started, a `TaskCompletionSource` or otherwise should be started and awaited, and the configurationDone handler will complete that task, enabling the launch task to resume and return its startup response.","author":{"url":"https://github.com/JustinGrote","@type":"Person","name":"JustinGrote"},"datePublished":"2024-10-15T00:19:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/2191/PowerShellEditorServices/issues/2191"}