René's URL Explorer Experiment


Title: Cleanup COM interfaces in jump list code - fix PreserveSig attributes by weltkante · Pull Request #9899 · PowerShell/PowerShell · GitHub

Open Graph Title: Cleanup COM interfaces in jump list code - fix PreserveSig attributes by weltkante · Pull Request #9899 · PowerShell/PowerShell

X Title: Cleanup COM interfaces in jump list code - fix PreserveSig attributes by weltkante · Pull Request #9899 · PowerShell/PowerShell

Description: PR Summary Correction of wrong/unnecessary COM interop attributes PR Context While reviewing the JumpList COM interop code for #9295 I noticed that several [PreserveSig] attributes were wrong. The methods which got the attribute wrong were never called, so this is not a direct fix for the issue, its just to prevent future problems should they ever be called. Also there were some unnecessary [MethodImpl] attributes which are not supposed to be there, these are cleaned up. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed

Open Graph Description: PR Summary Correction of wrong/unnecessary COM interop attributes PR Context While reviewing the JumpList COM interop code for #9295 I noticed that several [PreserveSig] attributes were wrong. The ...

X Description: PR Summary Correction of wrong/unnecessary COM interop attributes PR Context While reviewing the JumpList COM interop code for #9295 I noticed that several [PreserveSig] attributes were wrong. The ...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/9899

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b22416e-2b7f-6409-8330-9573855a8bab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD71E:F27CE:26D86AC:360F3DA:6AFD4659
html-safe-noncecebbf7426e71034346dc2023d8396dfbc51938c403fcd331003700fc8b70c237
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzFFOkYyN0NFOjI2RDg2QUM6MzYwRjNEQTo2QUZENDY1OSIsInZpc2l0b3JfaWQiOiI3MjQyOTc2MTk0ODU1NzgxOTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0e202f568f3900b5ecd233416a3e35f85d4f0b182427cc8c6ccc72c95142095
hovercard-subject-tagpull_request:288249348
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/9899/files
twitter:imagehttps://avatars.githubusercontent.com/u/5845814?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5845814?s=400&v=4
og:image:altPR Summary Correction of wrong/unnecessary COM interop attributes PR Context While reviewing the JumpList COM interop code for #9295 I noticed that several [PreserveSig] attributes were wrong. The ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/9899/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9899%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9899%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/9899/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9899/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9899/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Andrew (anmenaga)https://github.com/anmenaga
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
weltkante:interop-fixhttps://github.com/weltkante/PowerShell/tree/interop-fix
Conversation 13 https://github.com/PowerShell/PowerShell/pull/9899
Commits 2 https://github.com/PowerShell/PowerShell/pull/9899/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/9899/checks
Files changed https://github.com/PowerShell/PowerShell/pull/9899/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9899/files
Cleanup COM interfaces in jump list code - fix PreserveSig attributes https://github.com/PowerShell/PowerShell/pull/9899/files#top
Show all changes 2 commits https://github.com/PowerShell/PowerShell/pull/9899/files
07a5dcd Fix PreserveSig attributes. Remove unnecessary MethodImpl attributes. weltkante Oct 12, 2019 https://github.com/PowerShell/PowerShell/pull/9899/commits/07a5dcdb2a0f70b6d48fb6c025f8f32d63f64c23
c478c06 Fix whitespace issue weltkante Oct 12, 2019 https://github.com/PowerShell/PowerShell/pull/9899/commits/c478c061ba2c1afbd7f7c658a64fd0fedad3109c
Clear filters https://github.com/PowerShell/PowerShell/pull/9899/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9899/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9899/files
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/ComInterfaces.cshttps://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
View file https://github.com/weltkante/PowerShell/blob/c478c061ba2c1afbd7f7c658a64fd0fedad3109c/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/ComInterfaces.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9899/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com/PowerShell/PowerShell/pull/9899/files#diff-4d1dae242b358bdfd77aa2199afb669d8ab5f5b0086747dbef016b44cf2a30d3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.