René's URL Explorer Experiment


Title: Fixing test run crash by not passing script block to the callback by daxian-dbw · Pull Request #9298 · PowerShell/PowerShell · GitHub

Open Graph Title: Fixing test run crash by not passing script block to the callback by daxian-dbw · Pull Request #9298 · PowerShell/PowerShell

X Title: Fixing test run crash by not passing script block to the callback by daxian-dbw · Pull Request #9298 · PowerShell/PowerShell

Description: PR Summary Fixing test run crash by not passing script block to the callback. Updated the test. Also updated the XML documentation of those asynchronous APIs to call out this. PR Context When calling the asynchronous APIs on the PowerShell class, the passed in callback could be invoked on a thread without the default Runspace. So if a delegate cast from script block is passed in, it would fail in such case. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Change is not breaking Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed

Open Graph Description: PR Summary Fixing test run crash by not passing script block to the callback. Updated the test. Also updated the XML documentation of those asynchronous APIs to call out this. PR Context When calli...

X Description: PR Summary Fixing test run crash by not passing script block to the callback. Updated the test. Also updated the XML documentation of those asynchronous APIs to call out this. PR Context When calli...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/9298

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93fb3ec3-7cd4-0c55-6e64-458b489ce002
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B30:6F11A:160B2B:1E19CA:6AFD8F2C
html-safe-noncebaa390ca4f92f20d494b9eb338f840f94b74fc82c4267466237d692eb0633773
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjMwOjZGMTFBOjE2MEIyQjoxRTE5Q0E6NkFGRDhGMkMiLCJ2aXNpdG9yX2lkIjoiNDI4Nzc4MTMyNzg4MjUyMjQxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceae3dfa1c5918d51c3f8ade2c8dcce697648b3cbdc810507aef7fea8746471dc
hovercard-subject-tagpull_request:267652714
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/9298/files
twitter:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
og:image:altPR Summary Fixing test run crash by not passing script block to the callback. Updated the test. Also updated the XML documentation of those asynchronous APIs to call out this. PR Context When calli...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/9298/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9298%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9298%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/9298/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9298/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9298/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
daxian-dbw:fixtesthttps://github.com/daxian-dbw/PowerShell/tree/fixtest
Conversation 0 https://github.com/PowerShell/PowerShell/pull/9298
Commits 2 https://github.com/PowerShell/PowerShell/pull/9298/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/9298/checks
Files changed https://github.com/PowerShell/PowerShell/pull/9298/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9298/files
Fixing test run crash by not passing script block to the callback https://github.com/PowerShell/PowerShell/pull/9298/files#top
Show all changes 2 commits https://github.com/PowerShell/PowerShell/pull/9298/files
a21f09c Fixing test run crash by not passing script block to the callback daxian-dbw Apr 5, 2019 https://github.com/PowerShell/PowerShell/pull/9298/commits/a21f09c7d01d0a9be1d639a48bcbd15d1ced45c3
6c8b43b Fix typos daxian-dbw Apr 5, 2019 https://github.com/PowerShell/PowerShell/pull/9298/commits/6c8b43bc43ca9bdae311b267e22c49912e0b652c
Clear filters https://github.com/PowerShell/PowerShell/pull/9298/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9298/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9298/files
PowerShell.cs https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
TaskBasedAsyncPowerShellAPI.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1e74270d0f123c5d1c7a735f0721f3c8556df8bbc13549cbef083be2e9b1f94d
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/hostifaces/PowerShell.cshttps://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
View file https://github.com/daxian-dbw/PowerShell/blob/6c8b43bc43ca9bdae311b267e22c49912e0b652c/src/System.Management.Automation/engine/hostifaces/PowerShell.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9298/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1a2a55afdcd1687f9622f5da69efad4887c8bafb21d89ca59fa74a3081b5b497
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/engine/Api/TaskBasedAsyncPowerShellAPI.Tests.ps1https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1e74270d0f123c5d1c7a735f0721f3c8556df8bbc13549cbef083be2e9b1f94d
View file https://github.com/daxian-dbw/PowerShell/blob/6c8b43bc43ca9bdae311b267e22c49912e0b652c/test/powershell/engine/Api/TaskBasedAsyncPowerShellAPI.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9298/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1e74270d0f123c5d1c7a735f0721f3c8556df8bbc13549cbef083be2e9b1f94d
https://github.com/PowerShell/PowerShell/pull/9298/files#diff-1e74270d0f123c5d1c7a735f0721f3c8556df8bbc13549cbef083be2e9b1f94d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.