René's URL Explorer Experiment


Title: Fix Get-Module -FullyQualifiedName option to work with paths by pougetat · Pull Request #9101 · PowerShell/PowerShell · GitHub

Open Graph Title: Fix Get-Module -FullyQualifiedName option to work with paths by pougetat · Pull Request #9101 · PowerShell/PowerShell

X Title: Fix Get-Module -FullyQualifiedName option to work with paths by pougetat · Pull Request #9101 · PowerShell/PowerShell

Description: PR Summary This PR "fixes" the current behavior for get-module with -FullyQualifiedName specified and containing a path. Unfortunately this does mean that this PR is a breaking change. To illustrate the current behavior and the new behavior we can look at the following example : /Foo/1.0/Foo.psd1 /Foo/2.0/Foo.psd1 Get-module -ListAvailable -FullyQualifiedName @{ModuleName = "/Foo"; ModuleVersion = "2.0"} This will return both modules since "/Foo" is not correctly matched to either .psd1 file and the current behavior is to skip the version checks and simply return the modules. With this PR the names are correctly matched and the version checks can take place thus resulting in only one module being returned. PR Context This PR is related to the following issues : #8936 (meta-issue tracking refactoring work on module commandlets in general) #8262 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Change is not breaking Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. User-facing changes Not Applicable OR Documentation needed Issue filed: #8262 Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Add [feature] to your commit messages if the change is significant or affects feature tests

Open Graph Description: PR Summary This PR "fixes" the current behavior for get-module with -FullyQualifiedName specified and containing a path. Unfortunately this does mean that this PR is a breaking change. To...

X Description: PR Summary This PR "fixes" the current behavior for get-module with -FullyQualifiedName specified and containing a path. Unfortunately this does mean that this PR is a breaking ch...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/9101

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8970a00b-9b0c-f976-98da-8ef748938ef7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACDE:1A06A1:28B60F:3B5CFD:6AFD78BE
html-safe-noncede6b9200b9501d7e3a8cb816dfba2dbc9cc626f3153be4616584aee2b9e48ab9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0RFOjFBMDZBMToyOEI2MEY6M0I1Q0ZEOjZBRkQ3OEJFIiwidmlzaXRvcl9pZCI6IjI0ODk2Nzk2NTQzNjU3ODgzNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9dbd1118b477586c741bb30337decc36f7fe62a3f83dc71a00a010c418b763ff
hovercard-subject-tagpull_request:259761193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/9101/files
twitter:imagehttps://avatars.githubusercontent.com/u/13721697?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13721697?s=400&v=4
og:image:altPR Summary This PR "fixes" the current behavior for get-module with -FullyQualifiedName specified and containing a path. Unfortunately this does mean that this PR is a breaking change. To...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None544ff6b59bd215c4609120f6e334dbd0b00d34fb6f8bc03a476f72256998887e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release71c92f8b27ec5e9aa6f6477b4e067a4727fc9edb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/9101/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9101%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9101%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/9101/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9101/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/9101/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
pougetat:improve-getmodulehttps://github.com/pougetat/PowerShell/tree/improve-getmodule
Conversation 14 https://github.com/PowerShell/PowerShell/pull/9101
Commits 7 https://github.com/PowerShell/PowerShell/pull/9101/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/9101/checks
Files changed https://github.com/PowerShell/PowerShell/pull/9101/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9101/files
Fix Get-Module -FullyQualifiedName option to work with paths https://github.com/PowerShell/PowerShell/pull/9101/files#top
Show all changes 7 commits https://github.com/PowerShell/PowerShell/pull/9101/files
9925dbf Get-Module with FullyQualifiedName does not skip extra checks anymore throwaway774 Mar 10, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/9925dbf45c4bffc88aea6c374fcb540d76d60966
42f6fc7 clean up throwaway774 Mar 10, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/42f6fc7b888e02bae4dd392fffaf533c4bf0a94a
44b4a91 fixing coding style throwaway774 Mar 10, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/44b4a91d10a752ad9a66aa519561e72a4dbc8174
c90216d Fixing coding style throwaway774 Mar 10, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/c90216d4fd0b931dbe1ba1484d3c27ec80f64f3a
3870d87 Fixing coding style throwaway774 Mar 10, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/3870d875b98e1f3182e608af129adf5ee21627e6
c1b7237 Remove Linq expression throwaway774 Mar 29, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/c1b723716ee0afedf3e71f9fc88459aa758efb6d
6b9ed6f Fixing coding style throwaway774 Mar 29, 2019 https://github.com/PowerShell/PowerShell/pull/9101/commits/6b9ed6fb35fc280ea9bf7420ab51b0f7b1c60e07
Clear filters https://github.com/PowerShell/PowerShell/pull/9101/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9101/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9101/files
GetModuleCommand.cs https://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
ModuleIntrinsics.cs https://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Get-Module.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/9101/files#diff-36826812c1d7b7a63c5df9dd439d8d8732ca9db26ef0c03ddb411c84e47ffcef
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Modules/GetModuleCommand.cshttps://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
View file https://github.com/pougetat/PowerShell/blob/6b9ed6fb35fc280ea9bf7420ab51b0f7b1c60e07/src/System.Management.Automation/engine/Modules/GetModuleCommand.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9101/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
Travis Plunk (TravisEz13)https://github.com/TravisEz13
Aug 8, 2019https://github.com/PowerShell/PowerShell/pull/9101/files#r312248865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/9101/files
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
View file https://github.com/pougetat/PowerShell/blob/6b9ed6fb35fc280ea9bf7420ab51b0f7b1c60e07/src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9101/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1https://github.com/PowerShell/PowerShell/pull/9101/files#diff-36826812c1d7b7a63c5df9dd439d8d8732ca9db26ef0c03ddb411c84e47ffcef
View file https://github.com/pougetat/PowerShell/blob/6b9ed6fb35fc280ea9bf7420ab51b0f7b1c60e07/test/powershell/Modules/Microsoft.PowerShell.Core/Get-Module.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/9101/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-36826812c1d7b7a63c5df9dd439d8d8732ca9db26ef0c03ddb411c84e47ffcef
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-36826812c1d7b7a63c5df9dd439d8d8732ca9db26ef0c03ddb411c84e47ffcef
https://github.com/PowerShell/PowerShell/pull/9101/files#diff-36826812c1d7b7a63c5df9dd439d8d8732ca9db26ef0c03ddb411c84e47ffcef
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.