| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:230c85cf-ce5e-3a7e-5931-634c6a43183a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A498:19658F:2FD778:448AAD:6AFD6699 |
| html-safe-nonce | 445bee8a64ecae3adc6a6727c9ed3057b00a64f715721654b9f7b7eab661ea75 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDk4OjE5NjU4RjoyRkQ3Nzg6NDQ4QUFEOjZBRkQ2Njk5IiwidmlzaXRvcl9pZCI6IjQzMDc1NDU1OTkxNDc1OTk1MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4e740eb0ad3c5bf84da2ed08524d86e792a736dde835c34ce9c3f2c3d1268997 |
| hovercard-subject-tag | pull_request:259570749 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PowerShell/9091/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/488b67cc119bbb377369b845cd4e56b4043802919d0e77065a35b7d234f1b900/PowerShell/PowerShell/pull/9091 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/488b67cc119bbb377369b845cd4e56b4043802919d0e77065a35b7d234f1b900/PowerShell/PowerShell/pull/9091 |
| og:image:alt | PR Summary
The old implementation used a for loop with lots of if statements to parse a csv string, which is used in the import-alias cmdlet. I think the old implementation is bug sensitive and har... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SytzeAndr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42a67d7c7488271ca8d7e6dc3942424e6de3bff43b1ed4a9c6f0e1a69b73b389 |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5c3779ac05f3590d8d7ea0c02b14e678ae8179ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/PowerShell/PowerShell/pull/9091#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9091 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9091 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPowerShell |
| Reload | https://github.com/PowerShell/PowerShell/pull/9091 |
| Reload | https://github.com/PowerShell/PowerShell/pull/9091 |
| Reload | https://github.com/PowerShell/PowerShell/pull/9091 |
| PowerShell | https://github.com/PowerShell |
| PowerShell | https://github.com/PowerShell/PowerShell |
| Code | https://github.com/PowerShell/PowerShell |
| Issues1.3k (1.3k) | https://github.com/PowerShell/PowerShell/issues |
| Pull requests365 (365) | https://github.com/PowerShell/PowerShell/pulls |
| Discussions | https://github.com/PowerShell/PowerShell/discussions |
| Actions | https://github.com/PowerShell/PowerShell/actions |
| Projects | https://github.com/PowerShell/PowerShell/projects |
| Security and quality3 (3) | https://github.com/PowerShell/PowerShell/security |
| Insights | https://github.com/PowerShell/PowerShell/insights |
| https://github.com/PowerShell/PowerShell |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| Geweldig:csv_refactor | https://github.com/Geweldig/PowerShell/tree/csv_refactor |
| Conversation | https://github.com/PowerShell/PowerShell/pull/9091 |
| Commits95 (95) | https://github.com/PowerShell/PowerShell/pull/9091/commits |
| Checks | https://github.com/PowerShell/PowerShell/pull/9091/checks |
| Files changed | https://github.com/PowerShell/PowerShell/pull/9091/files |
| csv parser used in import alias refactor | https://github.com/PowerShell/PowerShell/pull/9091#top |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| Geweldig:csv_refactor | https://github.com/Geweldig/PowerShell/tree/csv_refactor |
|
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Mar 8, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issue-418911242 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| PR has a meaningful title | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Summarized changes | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Change is not breaking | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes |
| Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Work in Progress | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress |
| Documentation needed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Make sure you've added a new test if existing tests do not effectively test the code changed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting |
| Add [feature] to your commit messages if the change is significant or affects feature tests | https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| March 8, 2019 19:25 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-ff086e5 |
|
| https://github.com/SytzeAndr |
| regex expression to read csv string and ignore quotes | https://github.com/PowerShell/PowerShell/pull/9091/commits/ff086e5a70cd6fb0f352b9571420ea03f0b8207e |
| ff086e5 | https://github.com/PowerShell/PowerShell/pull/9091/commits/ff086e5a70cd6fb0f352b9571420ea03f0b8207e |
|
| https://github.com/SytzeAndr |
| added reference | https://github.com/PowerShell/PowerShell/pull/9091/commits/232f28eec075e557e966c0332c727e4fa1b730bb |
| 232f28e | https://github.com/PowerShell/PowerShell/pull/9091/commits/232f28eec075e557e966c0332c727e4fa1b730bb |
|
| https://github.com/SytzeAndr |
| cleanup and delimiter set included | https://github.com/PowerShell/PowerShell/pull/9091/commits/ff2f7342751df45475d8d39f22eb0b3799756780 |
| ff2f734 | https://github.com/PowerShell/PowerShell/pull/9091/commits/ff2f7342751df45475d8d39f22eb0b3799756780 |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| James Truher (JamesWTruher) | https://github.com/JamesWTruher |
| Paul Higinbotham (PaulHigin) | https://github.com/PaulHigin |
| code owners | https://github.com/PowerShell/PowerShell/blob/b23e835d2d80bd45dfee324f5a7e74ab07b7bcb9/.github/CODEOWNERS#L32 |
| March 8, 2019 18:49 | https://github.com/PowerShell/PowerShell/pull/9091#event-2190872428 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
| Mar 8, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471034834 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://cla.opensource.microsoft.com/PowerShell/PowerShell?pullRequest=9091 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| March 8, 2019 19:54 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-8de7476 |
|
| https://github.com/SytzeAndr |
| code comment issues from CI fixed | https://github.com/PowerShell/PowerShell/pull/9091/commits/8de7476364cfc7719487fab86111b7094f52c91d |
| 8de7476 | https://github.com/PowerShell/PowerShell/pull/9091/commits/8de7476364cfc7719487fab86111b7094f52c91d |
|
| https://github.com/SytzeAndr |
| removed comment that gave CI issues, since it is not really necessary | https://github.com/PowerShell/PowerShell/pull/9091/commits/9fe3089919949378559be34d8c6b272fabb56877 |
| 9fe3089 | https://github.com/PowerShell/PowerShell/pull/9091/commits/9fe3089919949378559be34d8c6b272fabb56877 |
| https://github.com/vexx32 |
| Rain Sallow (/u/ta11ow) (vexx32) | https://github.com/vexx32 |
| Mar 8, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471040868 |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| March 8, 2019 20:08 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-43aa935 |
|
| https://github.com/SytzeAndr |
| removal of toArray and wrong String usage | https://github.com/PowerShell/PowerShell/pull/9091/commits/43aa9357c60e6f96049eccb5946c38205ed73ccf |
| 43aa935 | https://github.com/PowerShell/PowerShell/pull/9091/commits/43aa9357c60e6f96049eccb5946c38205ed73ccf |
|
| https://github.com/SytzeAndr |
| returns empty collection when conditions met | https://github.com/PowerShell/PowerShell/pull/9091/commits/021c63137c27a9358e49cc275fc5699bfc9ad202 |
| 021c631 | https://github.com/PowerShell/PowerShell/pull/9091/commits/021c63137c27a9358e49cc275fc5699bfc9ad202 |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Mar 8, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471044784 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
| Mar 9, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471144909 |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Mar 9, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471197136 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Ilya (@iSazonov) | https://github.com/iSazonov |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/powercode |
| Staffan Gustafsson (powercode) | https://github.com/powercode |
| Mar 9, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471206248 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/powercode |
| Staffan Gustafsson (powercode) | https://github.com/powercode |
| Mar 9, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-471208161 |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| March 12, 2019 13:10 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-643a759 |
|
| https://github.com/SytzeAndr |
| implementation with reader | https://github.com/PowerShell/PowerShell/pull/9091/commits/643a75917bc886205a54790564db8d4634feef71 |
| 643a759 | https://github.com/PowerShell/PowerShell/pull/9091/commits/643a75917bc886205a54790564db8d4634feef71 |
|
| https://github.com/SytzeAndr |
| implementation with reader | https://github.com/PowerShell/PowerShell/pull/9091/commits/77a32ea8a6a5c8a69976bfa765f6a148545fbd55 |
| 77a32ea | https://github.com/PowerShell/PowerShell/pull/9091/commits/77a32ea8a6a5c8a69976bfa765f6a148545fbd55 |
|
| https://github.com/SytzeAndr |
| codefactor warnings | https://github.com/PowerShell/PowerShell/pull/9091/commits/472416158d1b7ccb6cedf8627837ae8dd4126625 |
| 4724161 | https://github.com/PowerShell/PowerShell/pull/9091/commits/472416158d1b7ccb6cedf8627837ae8dd4126625 |
|
| https://github.com/SytzeAndr |
| more codefactor suggestions | https://github.com/PowerShell/PowerShell/pull/9091/commits/1854f5351a2bac7c3bafd85316a2aa4859633e95 |
| 1854f53 | https://github.com/PowerShell/PowerShell/pull/9091/commits/1854f5351a2bac7c3bafd85316a2aa4859633e95 |
|
| https://github.com/SytzeAndr |
| more codefactor suggestions regarding wrongly placed brackets and com… | https://github.com/PowerShell/PowerShell/pull/9091/commits/d1c90f72295cdbc25a5e5def20884c17bbd60d9a |
| d1c90f7 | https://github.com/PowerShell/PowerShell/pull/9091/commits/d1c90f72295cdbc25a5e5def20884c17bbd60d9a |
|
| https://github.com/SytzeAndr |
| more codefactor regarding brackets | https://github.com/PowerShell/PowerShell/pull/9091/commits/a3573ee70511810c58a33c34c7a615901f7a7ef3 |
| a3573ee | https://github.com/PowerShell/PowerShell/pull/9091/commits/a3573ee70511810c58a33c34c7a615901f7a7ef3 |
|
| https://github.com/SytzeAndr |
| remove commented code | https://github.com/PowerShell/PowerShell/pull/9091/commits/823c5332f7e3eb11e2ce463aacaabdc2ecdd4776 |
| 823c533 | https://github.com/PowerShell/PowerShell/pull/9091/commits/823c5332f7e3eb11e2ce463aacaabdc2ecdd4776 |
|
| https://github.com/SytzeAndr |
| added a stringbuilder | https://github.com/PowerShell/PowerShell/pull/9091/commits/6de892fbd8284ca762c90a51b0d26b6d722b3bec |
| 6de892f | https://github.com/PowerShell/PowerShell/pull/9091/commits/6de892fbd8284ca762c90a51b0d26b6d722b3bec |
|
| https://github.com/SytzeAndr |
| rename for clarity | https://github.com/PowerShell/PowerShell/pull/9091/commits/40b7d856a81378f44f88690fb2538149a88f4c43 |
| 40b7d85 | https://github.com/PowerShell/PowerShell/pull/9091/commits/40b7d856a81378f44f88690fb2538149a88f4c43 |
|
| https://github.com/SytzeAndr |
| consistency with brackets | https://github.com/PowerShell/PowerShell/pull/9091/commits/2ca1eecb61bf3553ba387087c62a39d01140d1bd |
| 2ca1eec | https://github.com/PowerShell/PowerShell/pull/9091/commits/2ca1eecb61bf3553ba387087c62a39d01140d1bd |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Mar 12, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-472136915 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Stringbuilder | https://docs.microsoft.com/en-us/dotnet/api/system.text.stringbuilder?view=netcore-2.2 |
| Staffan Gustafsson (@powercode) | https://github.com/powercode |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/Geweldig |
| Bram Crielaard (Geweldig) | https://github.com/Geweldig |
|
Mar 12, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-213594084 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/2ca1eecb61bf3553ba387087c62a39d01140d1bd |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/Csv.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/2ca1eecb61bf3553ba387087c62a39d01140d1bd#diff-5b99ac31c374118f0810147b9f65e2ffd18334f7fe79c150ab04cff2ff3a7272 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/Csv.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/2ca1eecb61bf3553ba387087c62a39d01140d1bd#diff-5b99ac31c374118f0810147b9f65e2ffd18334f7fe79c150ab04cff2ff3a7272 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Mar 13, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-472351171 |
| Bram Crielaard (@Geweldig) | https://github.com/Geweldig |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
| https://github.com/SytzeAndr |
| Implemented changes | https://github.com/PowerShell/PowerShell/pull/9091/commits/229fd2a9988165a15c42d4b4b7c9dda18ca3f628 |
| @Geweldig | https://github.com/Geweldig |
| suggested | https://github.com/PowerShell/PowerShell/pull/9091/commits/229fd2a9988165a15c42d4b4b7c9dda18ca3f628 |
| 229fd2a | https://github.com/PowerShell/PowerShell/pull/9091/commits/229fd2a9988165a15c42d4b4b7c9dda18ca3f628 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| May 12, 2019 16:43 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-76d1992 |
|
| https://github.com/SytzeAndr |
| failing tests, the problem is that options is checked before the four… | https://github.com/PowerShell/PowerShell/pull/9091/commits/76d1992718f70f196e3d8cf106453a7ebf5c50b3 |
| 76d1992 | https://github.com/PowerShell/PowerShell/pull/9091/commits/76d1992718f70f196e3d8cf106453a7ebf5c50b3 |
|
| https://github.com/SytzeAndr |
| changed order of error checking, now tests pass | https://github.com/PowerShell/PowerShell/pull/9091/commits/82c882f45fed426cec5f79edb46bbfe3f030a256 |
| 82c882f | https://github.com/PowerShell/PowerShell/pull/9091/commits/82c882f45fed426cec5f79edb46bbfe3f030a256 |
|
| https://github.com/SytzeAndr |
| got rid of the try catch | https://github.com/PowerShell/PowerShell/pull/9091/commits/4ac3f917cd0a5dc799e29280dd05342e60420a39 |
| 4ac3f91 | https://github.com/PowerShell/PowerShell/pull/9091/commits/4ac3f917cd0a5dc799e29280dd05342e60420a39 |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| May 12, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-491607892 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
|
May 13, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-236469387 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1 | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-31d68e1cedaa16792486116772100ae24c1dcee4ba449f8b29c5cd753d4703f7 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1 | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-31d68e1cedaa16792486116772100ae24c1dcee4ba449f8b29c5cd753d4703f7 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1 | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-31d68e1cedaa16792486116772100ae24c1dcee4ba449f8b29c5cd753d4703f7 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| May 13, 2019 13:42 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-cffef01 |
|
| https://github.com/SytzeAndr |
|
| https://github.com/iSazonov |
| Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Imp… | https://github.com/PowerShell/PowerShell/pull/9091/commits/cffef0138d57d2786c7b2b3433c3887433e238e8 |
| cffef01 | https://github.com/PowerShell/PowerShell/pull/9091/commits/cffef0138d57d2786c7b2b3433c3887433e238e8 |
|
| https://github.com/SytzeAndr |
| small suggestions fix | https://github.com/PowerShell/PowerShell/pull/9091/commits/98538ea786f6898f2b3db0acc357779b441b7f47 |
| 98538ea | https://github.com/PowerShell/PowerShell/pull/9091/commits/98538ea786f6898f2b3db0acc357779b441b7f47 |
|
| https://github.com/SytzeAndr |
| reverted alias tests to master version | https://github.com/PowerShell/PowerShell/pull/9091/commits/e1e967133f4d68d7b56893556f7fab23b7838d91 |
| e1e9671 | https://github.com/PowerShell/PowerShell/pull/9091/commits/e1e967133f4d68d7b56893556f7fab23b7838d91 |
|
| https://github.com/SytzeAndr |
| typo in implementation, build broke | https://github.com/PowerShell/PowerShell/pull/9091/commits/255dc56790d42fe3b94c8ab6ea637fa147443bcc |
| 255dc56 | https://github.com/PowerShell/PowerShell/pull/9091/commits/255dc56790d42fe3b94c8ab6ea637fa147443bcc |
|
| https://github.com/SytzeAndr |
| removed unnecessary checks | https://github.com/PowerShell/PowerShell/pull/9091/commits/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd |
| d9d8f37 | https://github.com/PowerShell/PowerShell/pull/9091/commits/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd |
| https://github.com/TravisEz13 |
| Travis Plunk (TravisEz13) | https://github.com/TravisEz13 |
| Andrew (anmenaga) | https://github.com/anmenaga |
| Jun 21, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#event-2429001243 |
| https://github.com/TravisEz13 |
| Travis Plunk (TravisEz13) | https://github.com/TravisEz13 |
|
CL-General
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ACL-General |
| Jun 25, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#event-2438792635 |
| https://github.com/anmenaga |
| Andrew (anmenaga) | https://github.com/anmenaga |
| Jul 8, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-509411191 |
| Ilya (@iSazonov) | https://github.com/iSazonov |
| Dongbo Wang (@daxian-dbw) | https://github.com/daxian-dbw |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
|
Jul 9, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-259288266 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/4ac3f917cd0a5dc799e29280dd05342e60420a39#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/anmenaga |
| Andrew (anmenaga) | https://github.com/anmenaga |
|
Jul 12, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-261439488 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd |
| Andrew (anmenaga) | https://github.com/anmenaga |
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-261439488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| July 13, 2019 14:53 | https://github.com/PowerShell/PowerShell/pull/9091#commits-pushed-fe0e253 |
|
| https://github.com/SytzeAndr |
|
| https://github.com/iSazonov |
| Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Imp… | https://github.com/PowerShell/PowerShell/pull/9091/commits/fe0e2539bc7b8458a81e8f9e4c98dac112bb49ed |
| fe0e253 | https://github.com/PowerShell/PowerShell/pull/9091/commits/fe0e2539bc7b8458a81e8f9e4c98dac112bb49ed |
|
| https://github.com/SytzeAndr |
| ReadOnlySpan suggestion | https://github.com/PowerShell/PowerShell/pull/9091/commits/39d9f51a04dfd9c981f1950901fe8c1dfca15709 |
| 39d9f51 | https://github.com/PowerShell/PowerShell/pull/9091/commits/39d9f51a04dfd9c981f1950901fe8c1dfca15709 |
|
| https://github.com/SytzeAndr |
| made methods static | https://github.com/PowerShell/PowerShell/pull/9091/commits/e521cd162675fa31a5e1bae6e33083e091104c99 |
| e521cd1 | https://github.com/PowerShell/PowerShell/pull/9091/commits/e521cd162675fa31a5e1bae6e33083e091104c99 |
|
| https://github.com/SytzeAndr |
| made methods non static | https://github.com/PowerShell/PowerShell/pull/9091/commits/27937efce344b94d636679e4f2c9b5a8fe2580cb |
| 27937ef | https://github.com/PowerShell/PowerShell/pull/9091/commits/27937efce344b94d636679e4f2c9b5a8fe2580cb |
| https://github.com/SytzeAndr |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Jul 13, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-511127572 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (@SytzeAndr) | https://github.com/SytzeAndr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
| https://github.com/SytzeAndr |
| space after if, codefactor issue | https://github.com/PowerShell/PowerShell/pull/9091/commits/8c59dac83c4df3edb41be398f0c83517bfd80e14 |
| 8c59dac | https://github.com/PowerShell/PowerShell/pull/9091/commits/8c59dac83c4df3edb41be398f0c83517bfd80e14 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
|
Jul 15, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-261630149 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/8c59dac83c4df3edb41be398f0c83517bfd80e14 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/8c59dac83c4df3edb41be398f0c83517bfd80e14#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Ilya (iSazonov) | https://github.com/iSazonov |
| Jul 15, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r303286644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Jul 18, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r305108569 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Andrew (anmenaga) | https://github.com/anmenaga |
| Jul 25, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r307504812 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Ilya (@iSazonov) | https://github.com/iSazonov |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Ilya (iSazonov) | https://github.com/iSazonov |
| Jul 26, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r307580996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Sytze Andringa (SytzeAndr) | https://github.com/SytzeAndr |
| Jul 27, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r307965404 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/anmenaga |
| Andrew (anmenaga) | https://github.com/anmenaga |
| Jul 25, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-515217980 |
| Dongbo Wang (@daxian-dbw) | https://github.com/daxian-dbw |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
| https://github.com/SytzeAndr |
| i -> i + 1 in while check | https://github.com/PowerShell/PowerShell/pull/9091/commits/d13b879c767f2ecce4e0cdcba8f38978e0383180 |
| d13b879 | https://github.com/PowerShell/PowerShell/pull/9091/commits/d13b879c767f2ecce4e0cdcba8f38978e0383180 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
|
Jul 29, 2019
| https://github.com/PowerShell/PowerShell/pull/9091#pullrequestreview-267575792 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/9091/files/d13b879c767f2ecce4e0cdcba8f38978e0383180 |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImportAliasCommand.cs | https://github.com/PowerShell/PowerShell/pull/9091/files/d13b879c767f2ecce4e0cdcba8f38978e0383180#diff-fbae875c531006cb5f8524de6769377edbe6691fd16ab8722a8cb1df59885fce |
| Ilya (iSazonov) | https://github.com/iSazonov |
| Jul 29, 2019 | https://github.com/PowerShell/PowerShell/pull/9091#discussion_r308062396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
Review - Needed
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Review%20-%20Needed%22 |
| May 27, 2020 | https://github.com/PowerShell/PowerShell/pull/9091#event-3376078432 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| May 27, 2020 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-634381684 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
| May 27, 2020 | https://github.com/PowerShell/PowerShell/pull/9091#issuecomment-634458293 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
| May 27, 2020 | https://github.com/PowerShell/PowerShell/pull/9091#event-3376598394 |
| https://github.com/iSazonov |
| Ilya (iSazonov) | https://github.com/iSazonov |
|
Review - Needed
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3A%22Review%20-%20Needed%22 |
| May 27, 2020 | https://github.com/PowerShell/PowerShell/pull/9091#event-3376599095 |
| https://github.co/hiddenchars |
| https://github.com/PowerShell/PowerShell/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F9091 |
|
| https://github.com/daxian-dbw |
|
Dongbo Wang (daxian-dbw)
| https://github.com/daxian-dbw |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/fa3ee33051a3d75a7c748e9e586f76e671ee81e9 |
|
| https://github.com/iSazonov |
|
Ilya (iSazonov)
| https://github.com/iSazonov |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/d13b879c767f2ecce4e0cdcba8f38978e0383180 |
|
| https://github.com/JamesWTruher |
|
James Truher (JamesWTruher)
| https://github.com/JamesWTruher |
|
| https://github.com/PaulHigin |
|
Paul Higinbotham (PaulHigin)
| https://github.com/PaulHigin |
|
| https://github.com/powercode |
|
Staffan Gustafsson (powercode)
| https://github.com/powercode |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/fa3ee33051a3d75a7c748e9e586f76e671ee81e9 |
|
| https://github.com/Geweldig |
|
Bram Crielaard (Geweldig)
| https://github.com/Geweldig |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/2ca1eecb61bf3553ba387087c62a39d01140d1bd |
|
| https://github.com/anmenaga |
|
Andrew (anmenaga)
| https://github.com/anmenaga |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/8c59dac83c4df3edb41be398f0c83517bfd80e14 |
|
| https://github.com/vexx32 |
|
Rain Sallow (/u/ta11ow) (vexx32)
| https://github.com/vexx32 |
|
| https://github.com/PowerShell/PowerShell/pull/9091/files/d9d8f37733f1ee84cb96d71781fd85d7de3f6cfd |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
| https://github.com/anmenaga |
|
Andrew (anmenaga)
| https://github.com/anmenaga |
|
CL-General
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ACL-General |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/9091 |
|
| https://github.com/SytzeAndr |
|
| https://github.com/msftclas |
|
| https://github.com/vexx32 |
|
| https://github.com/iSazonov |
|
| https://github.com/powercode |
|
| https://github.com/LMiljak |
|
| https://github.com/daxian-dbw |
|
| https://github.com/anmenaga |
|
| https://github.com/Geweldig |
|
| https://github.com/TravisEz13 |
|
| https://github.com/SteveL-MSFT |
|
| https://github.com/adityapatwardhan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |