René's URL Explorer Experiment


Title: Refactor ConvertTo-Json cmdlet tests by xtqqczze · Pull Request #8593 · PowerShell/PowerShell · GitHub

Open Graph Title: Refactor ConvertTo-Json cmdlet tests by xtqqczze · Pull Request #8593 · PowerShell/PowerShell

X Title: Refactor ConvertTo-Json cmdlet tests by xtqqczze · Pull Request #8593 · PowerShell/PowerShell

Description: ConvertTo-Json.Tests.ps1 PR Summary Newtonsoft.Json.Linq.Jproperty should be converted to Json properly test Refactor for speed and clarity. StopProcessing should succeed test Avoid 10 second sleep before timing out. Existing test waits for ConvertTo-Json to write to verbose stream, which times out. Avoid 100 millisecond sleep Wait until Stopped state instead. Refactor for speed and clarity. Refactor and reformat: add using namespace statements use single quotes where possible avoid pipeline where possible PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Change is not breaking Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready. User-facing changes Not Applicable OR User-facing Documentation needed Issue filed - Issue link: Testing - New and feature Not Applicable or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Add [feature] if the change is significant or affects feature tests

Open Graph Description: ConvertTo-Json.Tests.ps1 PR Summary Newtonsoft.Json.Linq.Jproperty should be converted to Json properly test Refactor for speed and clarity. StopProcessing should succeed test Avoid 10 second ...

X Description: ConvertTo-Json.Tests.ps1 PR Summary Newtonsoft.Json.Linq.Jproperty should be converted to Json properly test Refactor for speed and clarity. StopProcessing should succeed test Avoid 10 second ...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/8593

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8956601-d86e-8037-d77a-973f53602ee0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8186:1AC24:1175A69:1980FDA:6A561D3E
html-safe-nonce927566ed3a8218db973988500617ef40c19bb8c3f79ee56c7fd8d4fb647b6f54
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTg2OjFBQzI0OjExNzVBNjk6MTk4MEZEQTo2QTU2MUQzRSIsInZpc2l0b3JfaWQiOiI4Mjk4MTQ4ODAwNzU1MDE0OTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc9fe568bb1d6b698e0df9ddd70cf14c83118eb129818c3c4c92be471fe7f3afd
hovercard-subject-tagpull_request:242417528
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/8593/files
twitter:imagehttps://avatars.githubusercontent.com/u/45661989?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45661989?s=400&v=4
og:image:altConvertTo-Json.Tests.ps1 PR Summary Newtonsoft.Json.Linq.Jproperty should be converted to Json properly test Refactor for speed and clarity. StopProcessing should succeed test Avoid 10 second ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneeeb71977be324ce2bc7c4afd597296b8e3527d8922ad94632edd7a7296f8031b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3e7957744c8a44d05ff1e464dc5d119e60b98fae
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/8593/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F8593%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F8593%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/8593/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/8593/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/8593/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8593/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
xtqqczzehttps://github.com/xtqqczze
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
xtqqczze:ConvertTo-Json.Testshttps://github.com/xtqqczze/PowerShell-PowerShell/tree/ConvertTo-Json.Tests
Conversation 11 https://github.com/PowerShell/PowerShell/pull/8593
Commits 10 https://github.com/PowerShell/PowerShell/pull/8593/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/8593/checks
Files changed https://github.com/PowerShell/PowerShell/pull/8593/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8593/files
Refactor ConvertTo-Json cmdlet tests https://github.com/PowerShell/PowerShell/pull/8593/files#top
Show all changes 10 commits https://github.com/PowerShell/PowerShell/pull/8593/files
d747776 Use ForEach operator instead of Foreach-Object xtqqczze Jan 4, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/d74777631c5155ea349a429b342abce87d37c8be
d496b55 Wait for running state rather than a verbose message xtqqczze Jan 4, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/d496b5509669483e2f7a4bc9cacde005a049a7e1
bbf3dcb Wait for invocation to stop. xtqqczze Jan 4, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/bbf3dcb3dc2a51d2e9a8f140d6e2ecc6bedf4472
cf700cc [Feature] Refactor and reformat xtqqczze Jan 5, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/cf700cccc09a688d6b8db60dbe20369f861d2f27
57c8f0d Write to the verbose stream and wait for that instead xtqqczze Jan 5, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/57c8f0dc8d2460b7816a9e020de6ff421977745d
a302c2c [Feature] Add comment xtqqczze Jan 5, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/a302c2c4006a583139181208a04e3db70afd79ac
5d703be Wait to ensure ConvertTo-Json has started processing xtqqczze Jan 10, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/5d703befaeb9e22d5c120178bb8d9dcc320e2b30
c3ec12c Move ForEach out of script xtqqczze Jan 11, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/c3ec12cde076f7fd405138e90176726f983c4d8b
dbb33af Use default timeout interval for Wait-UntilTrue and adjust sleep time xtqqczze Jan 11, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/dbb33af013e4de9e89f35f100256d9180313dc22
a3ce062 [Feature] Empty commit for CI xtqqczze Jan 12, 2019 https://github.com/PowerShell/PowerShell/pull/8593/commits/a3ce06225588b018b5804dda9a2ffceb59acdb84
Clear filters https://github.com/PowerShell/PowerShell/pull/8593/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8593/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8593/files
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1https://github.com/PowerShell/PowerShell/pull/8593/files#diff-1bcc931af6dd57913ccd0a4554390216386a6ed86bc97d5b8b3c8ce861bf4fa3
View file https://github.com/xtqqczze/PowerShell-PowerShell/blob/a3ce06225588b018b5804dda9a2ffceb59acdb84/test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/8593/{{ revealButtonHref }}
SteveL-MSFThttps://github.com/SteveL-MSFT
Jan 10, 2019https://github.com/PowerShell/PowerShell/pull/8593/files#r246604155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8593/files
https://github.com/PowerShell/PowerShell/pull/8593/files#diff-1bcc931af6dd57913ccd0a4554390216386a6ed86bc97d5b8b3c8ce861bf4fa3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.