René's URL Explorer Experiment


Title: Fix incorrect name check when autoloading required modules by rjmholt · Pull Request #8218 · PowerShell/PowerShell · GitHub

Open Graph Title: Fix incorrect name check when autoloading required modules by rjmholt · Pull Request #8218 · PowerShell/PowerShell

X Title: Fix incorrect name check when autoloading required modules by rjmholt · Pull Request #8218 · PowerShell/PowerShell

Description: PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

Open Graph Description: PR Summary Fixes #8204. The change I made in #7125 made the check too strict on the module we try to autoload it from requires and rejected it based on name. This PR removes that name check but als...

X Description: PR Summary Fixes #8204. The change I made in #7125 made the check too strict on the module we try to autoload it from requires and rejected it based on name. This PR removes that name check but als...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/8218

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3293722-cbb8-ce3d-a6f2-0e0595d8d5fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC1C:E6323:2B84:3754:6AFD45F0
html-safe-nonce8611b65427d3c710c48acd5fd193915860d0a058d372f8b1d0fc9c8caba7133e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzFDOkU2MzIzOjJCODQ6Mzc1NDo2QUZENDVGMCIsInZpc2l0b3JfaWQiOiI2NjA3MzE5NDU2MTA5NTE1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacef494f2127e81ae660e1b5234043c5e73b97a4e218a9fdd13d01550b03142a51
hovercard-subject-tagpull_request:229601817
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PowerShell/8218/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c77bcc8c062fe57384c9b4f9657a08dc015c271754fa0c3934910688ad7f025/PowerShell/PowerShell/pull/8218
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c77bcc8c062fe57384c9b4f9657a08dc015c271754fa0c3934910688ad7f025/PowerShell/PowerShell/pull/8218
og:image:altPR Summary Fixes #8204. The change I made in #7125 made the check too strict on the module we try to autoload it from requires and rejected it based on name. This PR removes that name check but als...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerjmholt
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-cache
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/8218#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F8218
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F8218
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/8218
Reloadhttps://github.com/PowerShell/PowerShell/pull/8218
Reloadhttps://github.com/PowerShell/PowerShell/pull/8218
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
https://github.com/PowerShell/PowerShell
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
rjmholt:fix-required-module-load-failurehttps://github.com/rjmholt/PowerShell/tree/fix-required-module-load-failure
Conversationhttps://github.com/PowerShell/PowerShell/pull/8218
Commits41 (41)https://github.com/PowerShell/PowerShell/pull/8218/commits
Checkshttps://github.com/PowerShell/PowerShell/pull/8218/checks
Files changedhttps://github.com/PowerShell/PowerShell/pull/8218/files
Fix incorrect name check when autoloading required moduleshttps://github.com/PowerShell/PowerShell/pull/8218#top
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
rjmholt:fix-required-module-load-failurehttps://github.com/rjmholt/PowerShell/tree/fix-required-module-load-failure
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issue-379041547
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
#8204https://github.com/PowerShell/PowerShell/issues/8204
#7125https://github.com/PowerShell/PowerShell/pull/7125
PR has a meaningful titlehttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission
Summarized changeshttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission
Change is not breakinghttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright headerhttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission
Work in Progresshttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress
Documentation neededhttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission
Make sure you've added a new test if existing tests do not effectively test the code changedhttps://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting
Add [feature] if the change is significant or affects feature testshttps://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/rjmholt
Skip name check when loading required moduleshttps://github.com/PowerShell/PowerShell/pull/8218/commits/c6dcb43e924d5490052f3fc4a79e07ba84e20c19
c6dcb43https://github.com/PowerShell/PowerShell/pull/8218/commits/c6dcb43e924d5490052f3fc4a79e07ba84e20c19
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Bruce Payette (BrucePay)https://github.com/BrucePay
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
code ownershttps://github.com/PowerShell/PowerShell/blob/4118fd2829cb1a0a64005bd5b84e08ca7ea354e2/.github/CODEOWNERS#L44
November 9, 2018 06:39https://github.com/PowerShell/PowerShell/pull/8218#event-1956136056
https://github.com/iSazonov
Ilya (iSazonov)https://github.com/iSazonov
Travis Plunk (TravisEz13)https://github.com/TravisEz13
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
November 9, 2018 06:43https://github.com/PowerShell/PowerShell/pull/8218#event-1956140730
https://github.com/iSazonov
Ilya (iSazonov)https://github.com/iSazonov
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#event-1956141052
https://github.com/bergmeister
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-437271522
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-437272096
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
November 8, 2018 23:47https://github.com/PowerShell/PowerShell/pull/8218#commits-pushed-4e693d2
https://github.com/rjmholt
[Feature] Fix null ref with max versionhttps://github.com/PowerShell/PowerShell/pull/8218/commits/4e693d2ac2209b9554025e967ae80c4e6fa58533
4e693d2https://github.com/PowerShell/PowerShell/pull/8218/commits/4e693d2ac2209b9554025e967ae80c4e6fa58533
https://github.com/rjmholt
[Feature] Fix path comparisons with required moduleshttps://github.com/PowerShell/PowerShell/pull/8218/commits/ae5c56b5a07f5a63981853f0a733c518c11e0ba1
ae5c56bhttps://github.com/PowerShell/PowerShell/pull/8218/commits/ae5c56b5a07f5a63981853f0a733c518c11e0ba1
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
force-pushedhttps://github.com/PowerShell/PowerShell/compare/3205e0d0ad7cd7add8e0290b77420f60a6a17e80..ae5c56b5a07f5a63981853f0a733c518c11e0ba1
3205e0dhttps://github.com/PowerShell/PowerShell/commit/3205e0d0ad7cd7add8e0290b77420f60a6a17e80
ae5c56bhttps://github.com/PowerShell/PowerShell/commit/ae5c56b5a07f5a63981853f0a733c518c11e0ba1
Compare https://github.com/PowerShell/PowerShell/compare/3205e0d0ad7cd7add8e0290b77420f60a6a17e80..ae5c56b5a07f5a63981853f0a733c518c11e0ba1
November 9, 2018 09:05https://github.com/PowerShell/PowerShell/pull/8218#event-1956351889
https://github.com/bergmeister
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-437306359
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
November 9, 2018 01:55https://github.com/PowerShell/PowerShell/pull/8218#commits-pushed-b3c9a87
https://github.com/rjmholt
[Feature] Match module when required path is base dirhttps://github.com/PowerShell/PowerShell/pull/8218/commits/b3c9a8753766d92714a78876964f9cffd400f492
b3c9a87https://github.com/PowerShell/PowerShell/pull/8218/commits/b3c9a8753766d92714a78876964f9cffd400f492
https://github.com/rjmholt
[Feature] Trim end of required module pathhttps://github.com/PowerShell/PowerShell/pull/8218/commits/5c04829a289c3351104fe21f3aab7ad13cc25d16
5c04829https://github.com/PowerShell/PowerShell/pull/8218/commits/5c04829a289c3351104fe21f3aab7ad13cc25d16
https://github.com/rjmholt
[Feature] Add testing for required module autoloading failurehttps://github.com/PowerShell/PowerShell/pull/8218/commits/28981dfadabbbb999faba23cdf8153cce999bf3a
28981dfhttps://github.com/PowerShell/PowerShell/pull/8218/commits/28981dfadabbbb999faba23cdf8153cce999bf3a
https://github.com/rjmholt
[Feature] Address CodeFactor issueshttps://github.com/PowerShell/PowerShell/pull/8218/commits/cea4dd56a8e8319c843e734deb147789daa61a22
cea4dd5https://github.com/PowerShell/PowerShell/pull/8218/commits/cea4dd56a8e8319c843e734deb147789daa61a22
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-437325085
PowerShell/src/System.Management.Automation/engine/CommandDiscovery.cshttps://github.com/PowerShell/PowerShell/blob/4118fd2829cb1a0a64005bd5b84e08ca7ea354e2/src/System.Management.Automation/engine/CommandDiscovery.cs#L307-L313
4118fd2https://github.com/PowerShell/PowerShell/commit/4118fd2829cb1a0a64005bd5b84e08ca7ea354e2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/adityapatwardhan
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
Nov 9, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-437465778
Rob Holt (@rjmholt)https://github.com/rjmholt
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/rjmholt
[Feature] Make relative paths work in module specification checkshttps://github.com/PowerShell/PowerShell/pull/8218/commits/b8e513aedce3cece109bdd781b5c28dc02f9f8f4
b8e513ahttps://github.com/PowerShell/PowerShell/pull/8218/commits/b8e513aedce3cece109bdd781b5c28dc02f9f8f4
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Francisco Gamino (Francisco-Gamino)https://github.com/Francisco-Gamino
code ownerhttps://github.com/PowerShell/PowerShell/blob/9894be9c60be12fddc3e61348e86b79a1af6b7c1/.github/CODEOWNERS#L51
November 9, 2018 20:16https://github.com/PowerShell/PowerShell/pull/8218#event-1957762350
Rob Holt (rjmholt)https://github.com/rjmholt
November 9, 2018 12:44https://github.com/PowerShell/PowerShell/pull/8218#commits-pushed-8a843ce
https://github.com/rjmholt
[Feature] Add copyright headerhttps://github.com/PowerShell/PowerShell/pull/8218/commits/8a843cefc112ce2287533fe533ada918d49bc609
8a843cehttps://github.com/PowerShell/PowerShell/pull/8218/commits/8a843cefc112ce2287533fe533ada918d49bc609
https://github.com/rjmholt
[Feature] Remove unused vars from testshttps://github.com/PowerShell/PowerShell/pull/8218/commits/fa950a1acbe8ef6a748527958bf10610e942d2e4
fa950a1https://github.com/PowerShell/PowerShell/pull/8218/commits/fa950a1acbe8ef6a748527958bf10610e942d2e4
https://github.com/rjmholt
[Feature] Add more testing for relative paths in fullyqualifiednameshttps://github.com/PowerShell/PowerShell/pull/8218/commits/2d9cf9cc191265c4939a4fda6c2bd0b98d5e4f53
2d9cf9chttps://github.com/PowerShell/PowerShell/pull/8218/commits/2d9cf9cc191265c4939a4fda6c2bd0b98d5e4f53
https://github.com/rjmholt
[Feature] Ensure required module path is absolute at autoloading timehttps://github.com/PowerShell/PowerShell/pull/8218/commits/55f8a7de5f3f65c4d07eb8c3438ab88967638107
55f8a7dhttps://github.com/PowerShell/PowerShell/pull/8218/commits/55f8a7de5f3f65c4d07eb8c3438ab88967638107
https://github.com/rjmholt
[Feature] Update Get-Module test to account for version ignoring quirkhttps://github.com/PowerShell/PowerShell/pull/8218/commits/d3b9651714dc0d65841b036e8b1aa7fd660375b9
d3b9651https://github.com/PowerShell/PowerShell/pull/8218/commits/d3b9651714dc0d65841b036e8b1aa7fd660375b9
https://github.com/rjmholt
[Feature] Reduce complexity of fix - normalize module spec path where…https://github.com/PowerShell/PowerShell/pull/8218/commits/980b8f052886c673501d4aa0941cc7eb331c5e3c
980b8f0https://github.com/PowerShell/PowerShell/pull/8218/commits/980b8f052886c673501d4aa0941cc7eb331c5e3c
https://github.com/rjmholt
[Feature] Revert further changeshttps://github.com/PowerShell/PowerShell/pull/8218/commits/0a414fff276ca09dd203696e92bef7e4ce0c2f20
0a414ffhttps://github.com/PowerShell/PowerShell/pull/8218/commits/0a414fff276ca09dd203696e92bef7e4ce0c2f20
https://github.com/rjmholt
[Feature] Add path normalization method to ModuleSpecificationhttps://github.com/PowerShell/PowerShell/pull/8218/commits/9163bc0239387324ddede98557abbcc67025ab04
9163bc0https://github.com/PowerShell/PowerShell/pull/8218/commits/9163bc0239387324ddede98557abbcc67025ab04
https://github.com/rjmholt
[Feature] Fix module specification method callhttps://github.com/PowerShell/PowerShell/pull/8218/commits/59cf3d1a1297dadc5de7b3c12a0943423a041a9b
59cf3d1https://github.com/PowerShell/PowerShell/pull/8218/commits/59cf3d1a1297dadc5de7b3c12a0943423a041a9b
https://github.com/rjmholt
[Feature] Revert unneeded changes - change to TODOs.https://github.com/PowerShell/PowerShell/pull/8218/commits/5b4bd9293c9496fce89fb8eeb10a4324f53ac857
5b4bd92https://github.com/PowerShell/PowerShell/pull/8218/commits/5b4bd9293c9496fce89fb8eeb10a4324f53ac857
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 12, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-438064371
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018 https://github.com/PowerShell/PowerShell/pull/8218#pullrequestreview-174134697
View reviewed changes https://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba
src/System.Management.Automation/engine/Modules/GetModuleCommand.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-9514470012e155563fe81cc2300d29e405f490198a381df0acfd4036d15976ae
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleSpecification.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-cb4cf11a85f0fd91df76c4b27f40aea26b6f004a353e1548fab24571ee60f2dc
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-e9589fb7f63dbabdd8b3b60abeea346e0d3a8cade0efbaa97b2edc688db627da
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r232865337
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r232874393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r233165586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r233228842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r233236840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-c6517c54cedee8a34579206ec718ff19ecde2a894e56d08fb20ae409c366c2aa
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
Rob Holt (rjmholt)https://github.com/rjmholt
November 12, 2018 18:48https://github.com/PowerShell/PowerShell/pull/8218#commits-pushed-5950e75
https://github.com/rjmholt
Make required name null check clearerhttps://github.com/PowerShell/PowerShell/pull/8218/commits/5950e754944498b89854bb6fad80fbbd3cfc88d6
5950e75https://github.com/PowerShell/PowerShell/pull/8218/commits/5950e754944498b89854bb6fad80fbbd3cfc88d6
https://github.com/rjmholt
Protect against path resolution failurehttps://github.com/PowerShell/PowerShell/pull/8218/commits/cbc650e76ab88591300b150380cc941316d6bc6b
cbc650ehttps://github.com/PowerShell/PowerShell/pull/8218/commits/cbc650e76ab88591300b150380cc941316d6bc6b
https://github.com/rjmholt
Fix Path.AltDirectorySeparatorChar misusehttps://github.com/PowerShell/PowerShell/pull/8218/commits/87a9704d6a6ed5fba3b81a88a55809ef387fbefe
87a9704https://github.com/PowerShell/PowerShell/pull/8218/commits/87a9704d6a6ed5fba3b81a88a55809ef387fbefe
https://github.com/rjmholt
[Feature] Fix non-const const assignmenthttps://github.com/PowerShell/PowerShell/pull/8218/commits/2378bb808cd988d6fed20b5f633c5b2cce80b781
2378bb8https://github.com/PowerShell/PowerShell/pull/8218/commits/2378bb808cd988d6fed20b5f633c5b2cce80b781
https://github.com/rjmholt
[Feature] Undo change to ModuleCmdletBase.IsRootedhttps://github.com/PowerShell/PowerShell/pull/8218/commits/9faf21ed8471ae05d54fe79d971bf1ce783378ce
9faf21ehttps://github.com/PowerShell/PowerShell/pull/8218/commits/9faf21ed8471ae05d54fe79d971bf1ce783378ce
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018 https://github.com/PowerShell/PowerShell/pull/8218#pullrequestreview-174517500
View reviewed changes https://github.com/PowerShell/PowerShell/pull/8218/files/cbc650e76ab88591300b150380cc941316d6bc6b
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/5950e754944498b89854bb6fad80fbbd3cfc88d6..cbc650e76ab88591300b150380cc941316d6bc6b#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/cbc650e76ab88591300b150380cc941316d6bc6b..87a9704d6a6ed5fba3b81a88a55809ef387fbefe#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
November 13, 2018 11:27https://github.com/PowerShell/PowerShell/pull/8218#commits-pushed-60ece17
[Feature] Improve TODOs in GetModuleCommand.cshttps://github.com/PowerShell/PowerShell/pull/8218/commits/60ece17bc52cffe6d2e966f066aeb0fc5b41267c
60ece17https://github.com/PowerShell/PowerShell/pull/8218/commits/60ece17bc52cffe6d2e966f066aeb0fc5b41267c
[Feature] Add comments to module path matching logichttps://github.com/PowerShell/PowerShell/pull/8218/commits/c21eb25e2713d25040f369260f77ae4a282d8169
c21eb25https://github.com/PowerShell/PowerShell/pull/8218/commits/c21eb25e2713d25040f369260f77ae4a282d8169
[Feature] Fix up path normalization codehttps://github.com/PowerShell/PowerShell/pull/8218/commits/336ba07c8dda18a590ff91c375acea81a52d6091
336ba07https://github.com/PowerShell/PowerShell/pull/8218/commits/336ba07c8dda18a590ff91c375acea81a52d6091
[Feature] Add extra fallback normalizationhttps://github.com/PowerShell/PowerShell/pull/8218/commits/30c07b8ee1b91499a02245484928f492e9e50b86
30c07b8https://github.com/PowerShell/PowerShell/pull/8218/commits/30c07b8ee1b91499a02245484928f492e9e50b86
[Feature] Fix IsModulePath check methodhttps://github.com/PowerShell/PowerShell/pull/8218/commits/e381a50d1d7b074e5365311072e5ac8edc50d418
e381a50https://github.com/PowerShell/PowerShell/pull/8218/commits/e381a50d1d7b074e5365311072e5ac8edc50d418
[Feature] Add full stop to satisfy code factorhttps://github.com/PowerShell/PowerShell/pull/8218/commits/93443450c0281019d2c64bfc3c14d8c50851cf46
9344345https://github.com/PowerShell/PowerShell/pull/8218/commits/93443450c0281019d2c64bfc3c14d8c50851cf46
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018 https://github.com/PowerShell/PowerShell/pull/8218#pullrequestreview-174595527
View reviewed changes https://github.com/PowerShell/PowerShell/pull/8218/files/93443450c0281019d2c64bfc3c14d8c50851cf46
src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/93443450c0281019d2c64bfc3c14d8c50851cf46#diff-127b1a58979f0695aff5b35c0407bb15db9596865840c1f2d58161856b5e1ae2
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cshttps://github.com/PowerShell/PowerShell/pull/8218/files/fc2b46d58bbd26efc1aca8ae802bd33a782a6aba#diff-e9589fb7f63dbabdd8b3b60abeea346e0d3a8cade0efbaa97b2edc688db627da
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#discussion_r233228842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
[Feature] Fix comment typohttps://github.com/PowerShell/PowerShell/pull/8218/commits/389b245cb4b4d18f946e2e6ba6a4b25286370703
389b245https://github.com/PowerShell/PowerShell/pull/8218/commits/389b245cb4b4d18f946e2e6ba6a4b25286370703
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Nov 13, 2018 https://github.com/PowerShell/PowerShell/pull/8218#pullrequestreview-174611513
View reviewed changes https://github.com/PowerShell/PowerShell/pull/8218/files/389b245cb4b4d18f946e2e6ba6a4b25286370703
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/PowerShell/PowerShell/pull/8218#pullrequestreview-174611513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/adityapatwardhan
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#issuecomment-438469255
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/adityapatwardhan
Aditya Patwardhan (adityapatwardhan)https://github.com/adityapatwardhan
aa76c68https://github.com/PowerShell/PowerShell/commit/aa76c6846d1374e1b96abf35074e8561b3837be7
Nov 13, 2018https://github.com/PowerShell/PowerShell/pull/8218#event-1964461419
ModuleSpecification/FullyQualifiedName usage does not handle paths well #8261 https://github.com/PowerShell/PowerShell/issues/8261
Get-Module [-ListAvailable] -FullyQualifiedName with path ignores other constraints #8262 https://github.com/PowerShell/PowerShell/issues/8262
https://github.com/bergmeister
Christoph Bergmeister (bergmeister)https://github.com/bergmeister
Nov 14, 2018 https://github.com/PowerShell/PowerShell/pull/8218#ref-issue-378510814
RequiredModules manifest property stopped working recently (noticed in daily build) #8204 https://github.com/PowerShell/PowerShell/issues/8204
https://github.com/iSazonov
Ilya (iSazonov)https://github.com/iSazonov
CL-Engine https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ACL-Engine
Jan 17, 2019https://github.com/PowerShell/PowerShell/pull/8218#event-2079219381
https://github.com/rjmholt
Rob Holt (rjmholt)https://github.com/rjmholt
Feb 21, 2019 https://github.com/PowerShell/PowerShell/pull/8218#ref-issue-412862184
Refactor ImportModule commandlet #8936 https://github.com/PowerShell/PowerShell/issues/8936
Thatgfsj (Thatgfsj)https://github.com/Thatgfsj
Aug 6, 2026 https://github.com/PowerShell/PowerShell/pull/8218#ref-commit-3b86f0b
https://github.com/rjmholt
https://github.com/adityapatwardhan
Fix incorrect name check when autoloading required modules (https://github.com/Thatgfsj-contribs/PowerShell/commit/3b86f0b84fedf768d3022b978f239a30a526a116
PowerShel…https://github.com/PowerShell/PowerShell/pull/8218
3b86f0bhttps://github.com/Thatgfsj-contribs/PowerShell/commit/3b86f0b84fedf768d3022b978f239a30a526a116
…l#8218https://github.com/PowerShell/PowerShell/pull/8218
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F8218
https://github.com/daxian-dbw
Dongbo Wang (daxian-dbw) https://github.com/daxian-dbw
https://github.com/PowerShell/PowerShell/pull/8218/files/389b245cb4b4d18f946e2e6ba6a4b25286370703
https://github.com/BrucePay
Bruce Payette (BrucePay) https://github.com/BrucePay
https://github.com/adityapatwardhan
Aditya Patwardhan (adityapatwardhan) https://github.com/adityapatwardhan
https://github.com/TravisEz13
Travis Plunk (TravisEz13) https://github.com/TravisEz13
https://github.com/Francisco-Gamino
Francisco Gamino (Francisco-Gamino) https://github.com/Francisco-Gamino
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/adityapatwardhan
Aditya Patwardhan (adityapatwardhan) https://github.com/adityapatwardhan
CL-Engine https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ACL-Engine
RequiredModules manifest property stopped working recently (noticed in daily build) https://github.com/PowerShell/PowerShell/issues/8204
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/8218
https://github.com/rjmholt
https://github.com/bergmeister
https://github.com/adityapatwardhan
https://github.com/daxian-dbw
https://github.com/iSazonov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.