René's URL Explorer Experiment


Title: Add Binary Parsing Support & Refactor TryGetNumberValue & ScanNumberHelper by vexx32 · Pull Request #7993 · PowerShell/PowerShell · GitHub

Open Graph Title: Add Binary Parsing Support & Refactor TryGetNumberValue & ScanNumberHelper by vexx32 · Pull Request #7993 · PowerShell/PowerShell

X Title: Add Binary Parsing Support & Refactor TryGetNumberValue & ScanNumberHelper by vexx32 · Pull Request #7993 · PowerShell/PowerShell

Description: PR Summary Fixes #7557 Adds support for binary parsing in format echoing hex: 0b11010110 Works with all existing type suffixes and multipliers. Supports arbitrary length parsing with n suffix using BigInteger; details below. Adds NumberFormat enum to specify hex/binary/base 10 for the tokenizer, replacing old bool hex. Adds n suffix for all numeric literals to support returning value as a BigInteger if requested. This bypasses the issue of large literals losing accuracy when they cast through double. Adds tests for all new behaviours. Binary / Hex Parsing Implementation Mimics old sign bit behaviour for int and long types. Sign bits accepted for 8 or 16-bit Hex parsing, and 8, 16, 32, 64 for binary. i.e., 0xFFFFFFFF -eq ([int]-1) and 0xFFFFFFFFFFFFFFFF -eq ([long]-1), but suffixing u creates int.MaxValue and long.MaxValue, respectively, instead. Sign bits higher than this are accepted for bigint-suffixed numerals: Hex: Bigint-suffixed hex treats the high bit of any literal with a length multiple of 8 as the sign bit Binary: Bigint-suffixed binary accepts sign bits at 96 and 128 chars, and from there on every 8 characters. Prefixing the literal with a 0 will bypass this and be treated as unsigned, e.g. 0b011111111 Specifying an unsigned suffix (or combination suffix that includes u) ignores sign bits, similar to how parsing a hex string using [Convert]::ToUint32() would do so. Supports negating literals using - prefix. This can result in positive numbers due to sign bits being permitted, just like hex literals. Refactored numeric tokenizer parsing New flow: Check for real (.01, 0.0, or 0e0 syntaxes) If the decimal suffix is present, TryParse directly into decimal. If the TryParse fails, TryGetNumberValue returns false. TryParse as Double, and apply multiplier to value. If the TryParse fails, TryGetNumberValue returns false. Check type suffixes and attempt to cast into appropriate type. This will return false if the value exceeds the specified type's bounds. Default to parsing as double where no suffix has been applied. Check number format. If binary, manually parse into BigInteger using optimized helper function to directly construct the BigInteger bytes from the string. If hex, TryParse into BigInteger using some special casing to retain original behaviours in int/long ranges. If neither binary nor hex, TryParse normally as a BigInteger. Apply multiplier value before attempting any casts to ensure type bounds can be appropriately checked without overflows. Check type suffixes. If a specific type suffix is used, check type bounds and attempt to parse into that type. If the value exceeds the type's available values, the parse fails. Otherwise, a straight cast is performed. If no suffix is used, the following types are bounds-checked, in order, resulting in the first successful test determining the type of the number. int long decimal (base-10 literals only) double (base-10 literals only) BigInteger for binary or hex literals. If the value is outside long range (for hex and binary) or double range (for base 10), the parse will fail; higher values must be explicitly requested using the n/N BigInteger suffix. This is a breaking change as binary literals are now read as numbers instead of generic tokens which could potentially have been used as function / cmdlet names or file names. Notes: Binary literal support was approved by the committee in #7557 The same issue is still under further discussion for underscore support in numeric literals and whether BigInteger parsing ought to be exposed to the user at all. Supporting underscore literals is a further breaking change causing some generic tokens like 1_000_000 to be read as numerals instead. Per Steve Lee (@SteveL-MSFT)'s comment this proposal was rejected. Removing underscore support or preventing standard parsing from accepting BigInteger ranges is a relatively trivial matter. It is my personal opinion that there is no particular reason not to hand the user a BigInteger when they enter a sufficiently large literal, but I will defer to the PowerShell Committee's judgement on this. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes) Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready. User-facing changes Not Applicable OR User-facing Documentation needed Issue filed - Issue link: MicrosoftDocs/PowerShell-Docs#2965 Testing - New and feature Not Applicable or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Add [feature] if the change is significant or affects feature tests /cc Ilya (@iSazonov) , Steve Lee (@SteveL-MSFT) as it pertains to the tagged-for-further-discussion #7557

Open Graph Description: PR Summary Fixes #7557 Adds support for binary parsing in format echoing hex: 0b11010110 Works with all existing type suffixes and multipliers. Supports arbitrary length parsing with n suffix usi...

X Description: PR Summary Fixes #7557 Adds support for binary parsing in format echoing hex: 0b11010110 Works with all existing type suffixes and multipliers. Supports arbitrary length parsing with n suffix usi...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/7993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4b12d7d8-9643-8348-396f-7280c51f1ba7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF5E:11BFC:261A8D4:351E4E9:6AFD4667
html-safe-nonceec3d7d6b17b8b2df458678bfecb1aee8e9993b2b03a3974e4c66a085a58df172
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjVFOjExQkZDOjI2MUE4RDQ6MzUxRTRFOTo2QUZENDY2NyIsInZpc2l0b3JfaWQiOiI3ODA1MTg0NDk3NjE5Mzg4MDA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8e350688b4219e6c4a0922d87c9f67e9e2c74335775e8ebed29a26235c890fe0
hovercard-subject-tagpull_request:222151965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/7993/files
twitter:imagehttps://avatars.githubusercontent.com/u/32407840?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/32407840?s=400&v=4
og:image:altPR Summary Fixes #7557 Adds support for binary parsing in format echoing hex: 0b11010110 Works with all existing type suffixes and multipliers. Supports arbitrary length parsing with n suffix usi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/7993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F7993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F7993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/7993/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/7993/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/7993/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Travis Plunk (TravisEz13)https://github.com/TravisEz13
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
vexx32:Tokenizer/Refactorhttps://github.com/vexx32/PowerShell/tree/Tokenizer/Refactor
Conversation 193 https://github.com/PowerShell/PowerShell/pull/7993
Commits 54 https://github.com/PowerShell/PowerShell/pull/7993/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/7993/checks
Files changed https://github.com/PowerShell/PowerShell/pull/7993/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Add Binary Parsing Support & Refactor TryGetNumberValue & ScanNumberHelper https://github.com/PowerShell/PowerShell/pull/7993/files#top
Show all changes 54 commits https://github.com/PowerShell/PowerShell/pull/7993/files
2ef76c9 Add generic utility functions for safely cross-converting numeric types vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/2ef76c9bf356270359b9de73b6f87501998a5d0e
d9e8e09 Add CharTraits flag for binary digit vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/d9e8e09fb715bfe90c6fe42abf1839e7131f2daa
76c1812 Add NumberSuffixFlags for BigInt vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/76c18124fddc46870798fb6d6bed9bbeb5780366
8628806 Add extended hex and binary parsing tests vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/8628806b3d40ed61b8f8fad06bc4dd5dc35616a5
fc9e5cd Fix decimal parsing issue where 0_00 would fail to parse vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/fc9e5cd348f8d8f48d103bf7ed96ca2713f2123d
2b00b64 Style & spacing fixes vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/2b00b649bb786f15a528dc6cdc911e99826d471a
c7c129f Trim complex logic & fix issues vexx32 Sep 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/c7c129fdfecf37bd2978f15358ce32f8da877f74
f737d30 Further parse optimizations vexx32 Oct 4, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/f737d3091c45e9726d47beb03d5f0b53e121ea6e
3e92c0d Introduce local for clarity in ScanNumberHelper vexx32 Oct 4, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/3e92c0d98603c69a86629f49709b0d7275aae2dd
dd558a3 Update parser tests for underscore formats vexx32 Oct 4, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/dd558a3c61b37c7f0422ef0bc7b40a5c9bbec638
5bbe98f Optimize ParseBinary & tokenizer parsing cases vexx32 Oct 4, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/5bbe98f956cc13a77da1aec2d1e5ba7f8c7db2c4
bbf76c5 Minor Fixes post-rebase vexx32 Oct 11, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/bbf76c5420b41e90dc2bc10cb531bb3f2e148b8f
738c33e Whitespace / style fixes for clarirt & StyleCop vexx32 Oct 12, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/738c33ede2a723c2eeb3bf9dfd86aec06120a917
4f68e43 Address review comments vexx32 Oct 12, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/4f68e43333eff55407bd2c7230c4086a1a54e3f5
52f7739 Refactor for efficiency per @iSazonov's recommendation vexx32 Oct 12, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/52f7739d93e4da589a245de9613d9ccedae7ff03
c537855 Update comment vexx32 Oct 12, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/c537855b6a22779ac52d93de0fb8e9aa01c4c1cc
26248e6 Update AsBigInt extension method vexx32 Oct 12, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/26248e6cb4288abd1f04cf02e45fe520f56bf922
dca6c6d Pre-insert leading 0 to hex literals in ScanNumberHelper vexx32 Oct 13, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/dca6c6d08c94cd60f39605c93d817814045e9931
d59fd89 Update ParseBinary to use spans throughout vexx32 Oct 14, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/d59fd892b1bed29ccd7bf6743fe1a585d93bac5b
5eb6bf6 Use stackalloc for small binary numerals vexx32 Oct 15, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/5eb6bf62017f037c85c1983bcd748e28b6e62a75
63ffd97 Add comments vexx32 Oct 15, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/63ffd976151235ab6855281ed938b43ca401c993
abc3e0b Fix glitch with `0b1` in binary parser vexx32 Oct 15, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/abc3e0bf73e95e56270a2898493587ef15ffe105
5d34f9e Rename variables for clarity vexx32 Oct 16, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/5d34f9ee1700906bbd6c238d6583ab426f5b12f1
f358087 Tidy and consolidate comments for binary parser vexx32 Oct 16, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/f35808794437d9c6e8e38f283cf4ac3990d515f7
f66218d Add comments and format code for readability vexx32 Oct 17, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/f66218d8c13f0f1ea2b28a8d50041545374f1dca
1dd414e Fix decimal literal parsing into double vexx32 Oct 22, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/1dd414e635476f75277f216ff3c500273ca3eadd
8223a6a Remove underscore parsing per Committee decision vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/8223a6af7df9fc5a26d59fcf4809215ada2186e3
e74c4a1 Use `n`/`N` suffix for bigint instead of `I` vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/e74c4a1161f1a93dd1999b43472cba55edd997c9
1c16a15 Restore test vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/1c16a150fff2b10ff37d94c31b7b13be77bfcd0c
d03a4b9 Prevent hex and binary automatically parsing as decimal vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/d03a4b9dcc492e599996549241c271a044af923c
8bbe0e3 Swap `i`->`n` bigint suffix in tests vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/8bbe0e36dcfb0bf5192a64aa214547e4461b7704
b1b246c Alphabetize using statements in Utils.cs vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/b1b246c59e881365a3e8e2822e627ac394680763
cccd610 Update CharTratis enum with proper documentation headers vexx32 Nov 29, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/cccd61058b3aaae4fbc14281fc66042aaf758b3e
f555a2f Re-add missing using statement vexx32 Dec 3, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/f555a2fb78ff9e40fc1e039eb7ca51c18f602f4e
6b72b94 Refactor to address review comments vexx32 Dec 4, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/6b72b94290b2ee04518c2534380b79a9c8954707
917af3d Define start index based on allocated bytes vexx32 Dec 5, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/917af3d1c51b2f8fe8843c65e7b50822819a0549
169d687 Revert refactor for readability vexx32 Dec 5, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/169d687dd3f6fe98c726d68397d04807db803b07
1b52625 Small refactor for readability and logical cohesion. vexx32 Dec 7, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/1b526252603c68385a9cb846c35cb7dc843bb93e
68f0a87 Replace variable name for readability vexx32 Dec 8, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/68f0a87d2206b0dc2cc63a00eef1e11905abfa1e
f7c16e5 Merge branch 'master' into Tokenizer/Refactor vexx32 Dec 20, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/f7c16e5e821bb68855eb7a3ccef77ed9087a4d67
6e1711b Merge branch 'master' into Tokenizer/Refactor vexx32 Dec 28, 2018 https://github.com/PowerShell/PowerShell/pull/7993/commits/6e1711b12ffc0178cc5264e06b8cbfb68cf5ddd9
5ecdf52 Merge branch 'master' into Tokenizer/Refactor vexx32 Jan 1, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/5ecdf52a811ab7d61c9407c0fb7e9ade394f9444
e08ad0b Merge branch 'master' into Tokenizer/Refactor vexx32 Jan 12, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/e08ad0bf63ef52b58017a2be33cb48172fa0c151
270f6a0 Merge branch 'master' into Tokenizer/Refactor vexx32 Jan 18, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/270f6a01501cf882842e48957cb27bc2d0332767
ecc37bd :white_check_mark: Update tests to use errorID vexx32 Jan 30, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/ecc37bd35b797cb81ca4834dc1224e974982da08
959e52c :pencil: Use correct ErrorID for should -throw vexx32 Jan 30, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/959e52c1211f1afda966a5b3d3a5ef1e65a1b819
99ec56d :pencil: Fix last failing test vexx32 Jan 30, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/99ec56d6f5a38d19827b17439927251c2b674cbc
091df16 :sparkles: Use suggested pattern for binary/decimal digits vexx32 Jan 31, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/091df16cd79648a1d1738b9599dbfbd540cf159a
684cc31 :white_check_mark: Add more tests for hex parsing vexx32 Jan 31, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/684cc31cd05d6324125be606b4b9851623bfd2a4
8822139 :recycle: Address Rob's feedback vexx32 Feb 12, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/882213996e0875362c173f7428bd7dd406a46f1a
ec2e105 :memo: Add comment to clarify why less readable method is used. vexx32 Feb 12, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/ec2e105e8da5839ea505194afcc4145a4e3cfb6a
07649fb Empty commit to restart CI vexx32 Feb 12, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/07649fbe9d219ac38480edf5ae84514f35c27e7b
c2c5e64 Merge branch 'Tokenizer/Refactor' of https://github.com/vexx32/PowerS… vexx32 Feb 12, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/c2c5e6423ba4bc36a87b74908a4207666b304950
4f4cf22 Merge branch 'master' into Tokenizer/Refactor vexx32 Mar 4, 2019 https://github.com/PowerShell/PowerShell/pull/7993/commits/4f4cf22e53fbb87101eecab7f4a1bddb6d87be50
Clear filters https://github.com/PowerShell/PowerShell/pull/7993/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Utils.cs https://github.com/PowerShell/PowerShell/pull/7993/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
CharTraits.cs https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
tokenizer.cs https://github.com/PowerShell/PowerShell/pull/7993/files#diff-52e11343509552477fbbb63d3123eaacb54b86748fa2330e2452422968ff9432
Parser.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/7993/files#diff-f4a377b74044c68cbaaa3d78ef8ca4b25a655f461dfe93609609a9919090c511
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Utils.cshttps://github.com/PowerShell/PowerShell/pull/7993/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
View file https://github.com/vexx32/PowerShell/blob/4f4cf22e53fbb87101eecab7f4a1bddb6d87be50/src/System.Management.Automation/engine/Utils.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/7993/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Oct 17, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r225779741
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Michael Klement (@mklement0)https://github.com/mklement0
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Oct 17, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r225914157
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Oct 17, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r225940643
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Rain Sallow (/u/ta11ow) (@vexx32)https://github.com/vexx32
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Oct 17, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r225946576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Oct 17, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r225969007
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Michael Klement (@mklement0)https://github.com/mklement0
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Michael Klement (mklement0)https://github.com/mklement0
Oct 24, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r227635309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Rain Sallow (/u/ta11ow) (@vexx32)https://github.com/vexx32
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Oct 24, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r227735200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 5, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239017966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Steve Lee (SteveL-MSFT)https://github.com/SteveL-MSFT
Feb 2, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r253238324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Feb 2, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r253244307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Dec 4, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r238531799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 4, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r238669482
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 5, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239113132
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ilya (@iSazonov)https://github.com/iSazonov
https://gist.github.com/vexx32/375d5553dfe3edee60cd9616228dd3a5https://gist.github.com/vexx32/375d5553dfe3edee60cd9616228dd3a5
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Dec 5, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239166487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 5, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239167985
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Dec 6, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239329153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 6, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239399313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Dec 6, 2018https://github.com/PowerShell/PowerShell/pull/7993/files#r239593058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ilya (@iSazonov)https://github.com/iSazonov
https://gist.github.com/vexx32/d2b7fff82f93635ea974bdbc0c26fa89https://gist.github.com/vexx32/d2b7fff82f93635ea974bdbc0c26fa89
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L49
src/System.Management.Automation/engine/parser/CharTraits.cshttps://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
View file https://github.com/vexx32/PowerShell/blob/4f4cf22e53fbb87101eecab7f4a1bddb6d87be50/src/System.Management.Automation/engine/parser/CharTraits.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/7993/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
Rob Holt (rjmholt)https://github.com/rjmholt
Feb 11, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255742611
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rob Holt (rjmholt)https://github.com/rjmholt
Feb 11, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255743331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Feb 12, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255764743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Rob Holt (@rjmholt)https://github.com/rjmholt
Ilya (@iSazonov)https://github.com/iSazonov
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Feb 12, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255790885
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Rob Holt (@rjmholt)https://github.com/rjmholt
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Rain Sallow (/u/ta11ow) (vexx32)https://github.com/vexx32
Feb 12, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255793449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
Ilya (iSazonov)https://github.com/iSazonov
Feb 12, 2019https://github.com/PowerShell/PowerShell/pull/7993/files#r255794160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
https://github.com/PowerShell/PowerShell/pull/7993/files#diff-c1474215963260a5fdd90751566011d4c5ceeaf5d28099e09a3128bf159ca585
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/7993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.