Title: Add support for parsing Link Header with variable whitespace by SteveL-MSFT · Pull Request #7322 · PowerShell/PowerShell · GitHub
Open Graph Title: Add support for parsing Link Header with variable whitespace by SteveL-MSFT · Pull Request #7322 · PowerShell/PowerShell
X Title: Add support for parsing Link Header with variable whitespace by SteveL-MSFT · Pull Request #7322 · PowerShell/PowerShell
Description: add support for variable whitespace in link header PR Summary Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace. The currently explicitly expect a single whitespace after the semicolon in the Link Header before the Rel property. Fix is to change the regex to allow for variable or no whitespace and associated tests to handle these two cases. Changed GetLink helper to support passing in whitespace to use. Fix #5667 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Change is not breaking Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready. User-facing changes Not Applicable OR User-facing Documentation needed Issue filed - Issue link: Testing - New and feature Not Applicable or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Add [feature] if the change is significant or affects feature tests
Open Graph Description: add support for variable whitespace in link header PR Summary Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace. The ...
X Description: add support for variable whitespace in link header PR Summary Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace. ...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/7322
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b2be0d5c-3800-e42c-1756-d6e6daaf6153 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBCC:7DC2D:253B86D:358AFE2:6A58F1AF |
| html-safe-nonce | 7e57454e93e3ce7c585bd6325e5a8b0fee4921c1b956b258be41b8b2490b9381 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkNDOjdEQzJEOjI1M0I4NkQ6MzU4QUZFMjo2QTU4RjFBRiIsInZpc2l0b3JfaWQiOiI0NTEzMzg3NjMxOTg5MDI3MjQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6789b79a5a39b618c2a177a9ba04d0a925dd898ec5db8c235dc60a01f8664ae6 |
| hovercard-subject-tag | pull_request:202940449 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/7322/files |
| twitter:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| og:image:alt | add support for variable whitespace in link header PR Summary Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace. The ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width