| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:31a02acc-7abd-884a-bf8d-945cb38e6a2c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC46:F01E1:24D4B83:319F36D:6A5471E2 |
| html-safe-nonce | dc4a234b3396512219fd1a5efe05bc0bf04afd12bb15035b7e9747d6981cd33b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQ2OkYwMUUxOjI0RDRCODM6MzE5RjM2RDo2QTU0NzFFMiIsInZpc2l0b3JfaWQiOiI3OTY5NTY5OTI1NTcxNTcyMTk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0d416ecfbcb1aa9bc0a35a4f8bd288960468c355e8aa852bea3488a10b68b1e2 |
| hovercard-subject-tag | pull_request:188291876 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PowerShell/6881/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12ad389159f5cb5e8f3bfdc41f2e8fbecab64cd3b7b53ddd857ee2b898d2ce56/PowerShell/PowerShell/pull/6881 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12ad389159f5cb5e8f3bfdc41f2e8fbecab64cd3b7b53ddd857ee2b898d2ce56/PowerShell/PowerShell/pull/6881 |
| og:image:alt | PR Summary
stop corrupting memory in libpsl-native SetDate
Addresses #6872 - the first step
PR Checklist
PR has a meaningful title
Use the present tense and imperative mood when describing your... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TravisEz13 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/PowerShell/PowerShell/pull/6881#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F6881 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F6881 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPowerShell |
| Reload | https://github.com/PowerShell/PowerShell/pull/6881 |
| Reload | https://github.com/PowerShell/PowerShell/pull/6881 |
| Reload | https://github.com/PowerShell/PowerShell/pull/6881 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
|
PowerShell
| https://github.com/PowerShell |
| PowerShell | https://github.com/PowerShell/PowerShell |
|
Notifications
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Fork
8.4k
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Star
54.4k
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Code
| https://github.com/PowerShell/PowerShell |
|
Issues
1.3k
| https://github.com/PowerShell/PowerShell/issues |
|
Pull requests
288
| https://github.com/PowerShell/PowerShell/pulls |
|
Discussions
| https://github.com/PowerShell/PowerShell/discussions |
|
Actions
| https://github.com/PowerShell/PowerShell/actions |
|
Projects
| https://github.com/PowerShell/PowerShell/projects |
|
Security and quality
3
| https://github.com/PowerShell/PowerShell/security |
|
Insights
| https://github.com/PowerShell/PowerShell/pulse |
|
Code
| https://github.com/PowerShell/PowerShell |
|
Issues
| https://github.com/PowerShell/PowerShell/issues |
|
Pull requests
| https://github.com/PowerShell/PowerShell/pulls |
|
Discussions
| https://github.com/PowerShell/PowerShell/discussions |
|
Actions
| https://github.com/PowerShell/PowerShell/actions |
|
Projects
| https://github.com/PowerShell/PowerShell/projects |
|
Security and quality
| https://github.com/PowerShell/PowerShell/security |
|
Insights
| https://github.com/PowerShell/PowerShell/pulse |
| TravisEz13 | https://github.com/TravisEz13 |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| TravisEz13:fix_psl_native | https://github.com/TravisEz13/PowerShell/tree/fix_psl_native |
| Conversation | https://github.com/PowerShell/PowerShell/pull/6881 |
| Commits5 (5) | https://github.com/PowerShell/PowerShell/pull/6881/commits |
| Checks | https://github.com/PowerShell/PowerShell/pull/6881/checks |
| Files changed | https://github.com/PowerShell/PowerShell/pull/6881/files |
| stop corrupting memory in libpsl-native SetDate | https://github.com/PowerShell/PowerShell/pull/6881#top |
| TravisEz13 | https://github.com/TravisEz13 |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| TravisEz13:fix_psl_native | https://github.com/TravisEz13/PowerShell/tree/fix_psl_native |
|
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
| May 16, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#issue-323431051 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| #6872 | https://github.com/PowerShell/PowerShell/issues/6872 |
| PR has a meaningful title | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Summarized changes | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Change is not breaking | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes |
| Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Work in Progress | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress |
| Documentation needed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Make sure you've added a new test if existing tests do not effectively test the code changed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting |
| Add [feature] if the change is significant or affects feature tests | https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| TravisEz13 | https://github.com/TravisEz13 |
| May 15, 2018 17:37 | https://github.com/PowerShell/PowerShell/pull/6881#commits-pushed-5313d79 |
|
| https://github.com/TravisEz13 |
| ignore pal_config.h | https://github.com/PowerShell/PowerShell/pull/6881/commits/5313d797e90cb113845094404b0ce165ec02ec90 |
| 5313d79 | https://github.com/PowerShell/PowerShell/pull/6881/commits/5313d797e90cb113845094404b0ce165ec02ec90 |
|
| https://github.com/TravisEz13 |
| Add comment to getstat not to use in managed code | https://github.com/PowerShell/PowerShell/pull/6881/commits/25d19a47fc71f806d573847dac6074b4ffb70dbf |
| 25d19a4 | https://github.com/PowerShell/PowerShell/pull/6881/commits/25d19a47fc71f806d573847dac6074b4ffb70dbf |
|
| https://github.com/TravisEz13 |
| update SetDate to use private struct to avoid memory corruption | https://github.com/PowerShell/PowerShell/pull/6881/commits/1c1b6648417885d2e8a192a666e17c7f25e7a94e |
| 1c1b664 | https://github.com/PowerShell/PowerShell/pull/6881/commits/1c1b6648417885d2e8a192a666e17c7f25e7a94e |
| PowerShell#6872 | https://github.com/PowerShell/PowerShell/issues/6872 |
|
| https://github.com/TravisEz13 |
| Add dan as a codeowner of libpsl-native | https://github.com/PowerShell/PowerShell/pull/6881/commits/a2ca44e7f645a734b866ea82ee890e81d6540dd3 |
| a2ca44e | https://github.com/PowerShell/PowerShell/pull/6881/commits/a2ca44e7f645a734b866ea82ee890e81d6540dd3 |
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
| joeyaiello | https://github.com/joeyaiello |
| code owner | https://github.com/PowerShell/PowerShell/blob/aa0af5ed56b2f23207be090f35382193a92ec382/.github/CODEOWNERS#L16 |
| May 16, 2018 00:43 | https://github.com/PowerShell/PowerShell/pull/6881#event-1628495093 |
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
| dantraMSFT | https://github.com/dantraMSFT |
| daxian-dbw | https://github.com/daxian-dbw |
| May 16, 2018 00:43 | https://github.com/PowerShell/PowerShell/pull/6881#event-1628495525 |
|
| https://github.com/TravisEz13 |
| fix CodeFactor issues | https://github.com/PowerShell/PowerShell/pull/6881/commits/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
| b88133e | https://github.com/PowerShell/PowerShell/pull/6881/commits/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
| https://github.com/dantraMSFT |
| dantraMSFT | https://github.com/dantraMSFT |
|
May 17, 2018
| https://github.com/PowerShell/PowerShell/pull/6881#pullrequestreview-120859748 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/6881/files/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
|
May 17, 2018
| https://github.com/PowerShell/PowerShell/pull/6881#ref-issue-323121436 |
|
Need psl-native library code review
#6874
| https://github.com/PowerShell/PowerShell/issues/6874 |
| https://github.com/iSazonov |
| iSazonov | https://github.com/iSazonov |
|
May 18, 2018
| https://github.com/PowerShell/PowerShell/pull/6881#pullrequestreview-121295611 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/6881/files/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
| src/libpsl-native/src/setdate.cpp | https://github.com/PowerShell/PowerShell/pull/6881/files/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576#diff-c4f0f61dc792902142f0bd2a4ac99e7d7d82d8c9567c39bf80ec4239517d396f |
| iSazonov | https://github.com/iSazonov |
| May 18, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#discussion_r189168467 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| stime | https://linux.die.net/man/2/stime |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| TravisEz13 | https://github.com/TravisEz13 |
| May 18, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#discussion_r189343234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @dantraMSFT | https://github.com/dantraMSFT |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| iSazonov | https://github.com/iSazonov |
| May 18, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#discussion_r189350994 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| iSazonov | https://github.com/iSazonov |
| May 31, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#discussion_r192031316 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #6962 | https://github.com/PowerShell/PowerShell/issues/6962 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| https://github.com/iSazonov |
| iSazonov | https://github.com/iSazonov |
| May 18, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#issuecomment-390288370 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
| b43d3e5 | https://github.com/PowerShell/PowerShell/commit/b43d3e5d00699e03b956fa0cd9a69b3dd9a0d904 |
| May 18, 2018 | https://github.com/PowerShell/PowerShell/pull/6881#event-1635038056 |
| https://github.com/TravisEz13 |
| TravisEz13 | https://github.com/TravisEz13 |
| May 18, 2018 19:56 | https://github.com/PowerShell/PowerShell/pull/6881#event-1635038182 |
| https://github.com/iSazonov |
| iSazonov | https://github.com/iSazonov |
|
May 24, 2023
| https://github.com/PowerShell/PowerShell/pull/6881#ref-pullrequest-1722566532 |
|
Remove the property disabling optimization
#19701
| https://github.com/PowerShell/PowerShell/pull/19701 |
| https://github.co/hiddenchars |
| https://github.com/PowerShell/PowerShell/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F6881 |
|
| https://github.com/iSazonov |
|
iSazonov
| https://github.com/iSazonov |
|
| https://github.com/PowerShell/PowerShell/pull/6881/files/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
|
| https://github.com/joeyaiello |
|
joeyaiello
| https://github.com/joeyaiello |
|
| https://github.com/daxian-dbw |
|
daxian-dbw
| https://github.com/daxian-dbw |
|
| https://github.com/dantraMSFT |
|
dantraMSFT
| https://github.com/dantraMSFT |
|
| https://github.com/PowerShell/PowerShell/pull/6881/files/b88133eb1e0ef0c767fe1b9c798c1a89b80e0576 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/6881 |
|
| https://github.com/TravisEz13 |
|
| https://github.com/iSazonov |
|
| https://github.com/dantraMSFT |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |