René's URL Explorer Experiment


Title: Msi installer: smoke test by bergmeister · Pull Request #6105 · PowerShell/PowerShell · GitHub

Open Graph Title: Msi installer: smoke test by bergmeister · Pull Request #6105 · PowerShell/PowerShell

X Title: Msi installer: smoke test by bergmeister · Pull Request #6105 · PowerShell/PowerShell

Description: PR Summary PR 6043 broke the installer (issue #6095). To prevent this from happening in the future, add a smoke test that installs the msi in appveyor build and make build fail if installation failed. It uses the exit code to determine the success. The reason why it does not fail in the current state is because as I pointed out here, the failing custom action is not returning its exit code. PR Checklist Note: Please mark anything not applicable to this PR NA. PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes NA User facing Documentation needed Issue filed - Issue link: NA Change is not breaking NA Make sure you've added a new test if existing tests do not effectively test the code changed Add [feature] if the change is significant or affects feature tests This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Open Graph Description: PR Summary PR 6043 broke the installer (issue #6095). To prevent this from happening in the future, add a smoke test that installs the msi in appveyor build and make build fail if installation fail...

X Description: PR Summary PR 6043 broke the installer (issue #6095). To prevent this from happening in the future, add a smoke test that installs the msi in appveyor build and make build fail if installation fail...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/6105

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:1d689c8c-74fa-23b2-f672-b8d5d713a96e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA45C:5502B:360B52E:47C4D31:6A655B10
html-safe-nonce2ada287a914ae47b9ff357433ca712d7474250f80ee473c16ffd87ac5650efed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDVDOjU1MDJCOjM2MEI1MkU6NDdDNEQzMTo2QTY1NUIxMCIsInZpc2l0b3JfaWQiOiI1OTcxOTgwOTc5ODAwNDY0MTQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3c5db989e3699b3ad68e285b5cec58a7abc46c3f486be28b0af88a9055897256
hovercard-subject-tagpull_request:167273366
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
twitter:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
og:image:altPR Summary PR 6043 broke the installer (issue #6095). To prevent this from happening in the future, add a smoke test that installs the msi in appveyor build and make build fail if installation fail...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F6105%2Fcommits%2Fd5e6a0b272d1fb37686ad62515197396b9e74c0f
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F6105%2Fcommits%2Fd5e6a0b272d1fb37686ad62515197396b9e74c0f
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Reloadhttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Reloadhttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.5k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.3k https://github.com/PowerShell/PowerShell/issues
Pull requests 291 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
TravisEz13https://github.com/TravisEz13
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
bergmeister:MsiInstallerSmokeTesthttps://github.com/bergmeister/PowerShell/tree/MsiInstallerSmokeTest
Conversation 22 https://github.com/PowerShell/PowerShell/pull/6105
Commits 6 https://github.com/PowerShell/PowerShell/pull/6105/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/6105/checks
Files changed https://github.com/PowerShell/PowerShell/pull/6105/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Msi installer: smoke test https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#top
Show all changes 6 commits https://github.com/PowerShell/PowerShell/pull/6105/files
2b7c10a add smoke test for msi installer bergmeister Feb 5, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/2b7c10aea1db2ddb5acda2d654bbf72739a06211
cef0a06 add -verbose switch and more logging bergmeister Feb 5, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/cef0a068a4a5044029dea66812cf5b9d505bb948
f6530b8 add blocking install bergmeister Feb 5, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/f6530b84f86f68b2199aaee2c4e0f70c977d6363
043076a forgot to return process. tidy up and make sure appveyor would really… bergmeister Feb 5, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/043076a9456c9b5310ab20cc6426227c8f497e3d
d5e6a0b address pr comment bergmeister Feb 5, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
da89fce Add comment to explain the call to 'SetShouldExit' daxian-dbw Feb 6, 2018 https://github.com/PowerShell/PowerShell/pull/6105/commits/da89fce3d1e4b9f08b19875de6a9b9a719cf5990
Clear filters https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Prev https://github.com/PowerShell/PowerShell/pull/6105/commits/043076a9456c9b5310ab20cc6426227c8f497e3d
Next https://github.com/PowerShell/PowerShell/pull/6105/commits/da89fce3d1e4b9f08b19875de6a9b9a719cf5990
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
https://github.com/bergmeister
bergmeisterhttps://github.com/PowerShell/PowerShell/commits?author=bergmeister
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L64
tools/appveyor.psm1https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#diff-dc48acb16cdba1b5d356b3036a474edd1aad289ef74c0d5dad04737767434af7
View file https://github.com/bergmeister/PowerShell/blob/d5e6a0b272d1fb37686ad62515197396b9e74c0f/tools/appveyor.psm1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/6105/commits/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#diff-dc48acb16cdba1b5d356b3036a474edd1aad289ef74c0d5dad04737767434af7
TravisEz13https://github.com/TravisEz13
Feb 6, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166157643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/PowerShell/DscResource.Tests/blob/f9e3dfd3eb9d7b6a9225e2cfba68b79ffe1cab36/AppVeyor.psm1#L459https://github.com/PowerShell/DscResource.Tests/blob/f9e3dfd3eb9d7b6a9225e2cfba68b79ffe1cab36/AppVeyor.psm1#L459
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
bergmeisterhttps://github.com/bergmeister
Feb 6, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166473490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.appveyor.com/project/bergmeister/powershell/build/v6.1.0-preview.281/testshttps://ci.appveyor.com/project/bergmeister/powershell/build/v6.1.0-preview.281/tests
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
TravisEz13https://github.com/TravisEz13
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166766258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
bergmeisterhttps://github.com/bergmeister
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166781579
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://ci.appveyor.com/project/bergmeister/powershell/build/v6.1.0-preview.282/tests
herehttps://github.com/bergmeister/PowerShell/commits/MsiInstallerSmokeTest2
https://user-images.githubusercontent.com/9250262/35945537-765128a8-0c58-11e8-93ff-223ad1552aec.png
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
TravisEz13https://github.com/TravisEz13
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166781972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
TravisEz13https://github.com/TravisEz13
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166782088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
bergmeisterhttps://github.com/bergmeister
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166782594
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
TravisEz13https://github.com/TravisEz13
Feb 7, 2018https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#r166783357
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f
https://github.com/PowerShell/PowerShell/pull/6105/commits/d5e6a0b272d1fb37686ad62515197396b9e74c0f#diff-dc48acb16cdba1b5d356b3036a474edd1aad289ef74c0d5dad04737767434af7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.