René's URL Explorer Experiment


Title: Add options to enable PSRemoting and register Windows Event Logging Manifest to MSI installer by bergmeister · Pull Request #5999 · PowerShell/PowerShell · GitHub

Open Graph Title: Add options to enable PSRemoting and register Windows Event Logging Manifest to MSI installer by bergmeister · Pull Request #5999 · PowerShell/PowerShell

X Title: Add options to enable PSRemoting and register Windows Event Logging Manifest to MSI installer by bergmeister · Pull Request #5999 · PowerShell/PowerShell

Description: PR Summary Closes #5979 This is an early working prototype on which I'd like to get feedback on please. It basically re-uses the existing custom dialog and adds 2 new checkboxes to run run RegisterManifest.ps1 and Enable-PSRemoting (with the first one being ticked by default) using the installed pwsh.exe. Questions to be discussed include e.g. how should pwsh.exe be called and how error should be handled. Currently PowerShell errors are getting ignored by WiX. PR Checklist Note: Please mark anything not applicable to this PR NA. PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes User facing Documentation needed Issue filed - Issue link: MicrosoftDocs/PowerShell-Docs#2007 Change is not breaking Make sure you've added a new test if existing tests do not effectively test the code changed [feature] Add [feature] if the change is significant or affects feature tests This PR is ready to merge and is not Work in Progress. I think the recently introduced installer regression should be reverted first before merging this. If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Open Graph Description: PR Summary Closes #5979 This is an early working prototype on which I'd like to get feedback on please. It basically re-uses the existing custom dialog and adds 2 new checkboxes to run run Regi...

X Description: PR Summary Closes #5979 This is an early working prototype on which I'd like to get feedback on please. It basically re-uses the existing custom dialog and adds 2 new checkboxes to run run ...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/5999

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73fce97e-7db3-1d38-cdda-894179f93d68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id907E:6E570:15ACA8:1DF8D5:6A553548
html-safe-nonce20ae13d39530595de6827554b4151e4e02240f826206bcf20e6fdee9e75f9e7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDdFOjZFNTcwOjE1QUNBODoxREY4RDU6NkE1NTM1NDgiLCJ2aXNpdG9yX2lkIjoiNzU5MDUzODY0MDc5MjgyNzIwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95635255190fa2c71565c7221a7d55666bea2b1619b2f0f1ca8a6d72156f5ecd
hovercard-subject-tagpull_request:164716353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/5999/files
twitter:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9250262?s=400&v=4
og:image:altPR Summary Closes #5979 This is an early working prototype on which I'd like to get feedback on please. It basically re-uses the existing custom dialog and adds 2 new checkboxes to run run Regi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release811f50b757204c6a1b4da0ea780075b3e1cc9e57
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/5999/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F5999%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F5999%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/5999/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/5999/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/5999/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
iSazonovhttps://github.com/iSazonov
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
bergmeister:WiX_registerManifest_EnablePsRemotinghttps://github.com/bergmeister/PowerShell/tree/WiX_registerManifest_EnablePsRemoting
Conversation 19 https://github.com/PowerShell/PowerShell/pull/5999
Commits 14 https://github.com/PowerShell/PowerShell/pull/5999/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/5999/checks
Files changed https://github.com/PowerShell/PowerShell/pull/5999/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
Add options to enable PSRemoting and register Windows Event Logging Manifest to MSI installer https://github.com/PowerShell/PowerShell/pull/5999/files#top
Show all changes 14 commits https://github.com/PowerShell/PowerShell/pull/5999/files
530b154 first simple prototype bergmeister Jan 22, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/530b154d3a3bee467eaa45ad8d9c0e767afb0966
80123a9 set default value of checkbox and make it work with elevation when ru… bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/80123a9b32c1a90baf4caea0cd9c82b164c6f4df
3f49cd4 Use -File param on powershell.exe instad of command bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/3f49cd4a2e140591c414d6501f462cebd086d996
15eb388 conditional logic to use first textbox value bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/15eb38893fa858286759baf0bef0dddf88dd2ae2
e4f200c simplify conditional logic bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/e4f200cffc53cbbcab3d9c58334a6fdaaa41c8c0
74349c4 revert custom action renaming, which broke silent install bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/74349c4573f780f3cdd351998ab39eb37c5a1884
9e65a65 Add 2nd custom action with test file and change checkbox text as requ… bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/9e65a652330b4f41ad33db2b4a720b5f7e03035a
140db9e call pwsh instead of powershell and assert against properties being 1 bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/140db9e6d552855cf243c2c181bb2e0d15e2101a
14c99a2 remove comment made during development bergmeister Jan 23, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/14c99a2e09adab439ef4b0b97047814bcb5f67db
63b207a Merge branch 'master' of https://github.com/PowerShell/PowerShell int… bergmeister Feb 17, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/63b207a1e84ae7cb7272f255e02323194187e7fe
26f5ae7 ignore return value because checkbox features are optional bergmeister Feb 17, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/26f5ae72d054cf8efef6fb06e1655600221ba14a
dbb7ebb Merge branch 'master' of https://github.com/PowerShell/PowerShell int… bergmeister Feb 19, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/dbb7ebbd93ed003bffa592edabf6d344dbe39759
ba98663 address PR feedback about formatting and wording bergmeister Feb 21, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/ba98663c1f0d1608522c47b6b2a43b34f308cd75
ccf17e1 Merge branch 'master' of https://github.com/PowerShell/PowerShell int… bergmeister Feb 21, 2018 https://github.com/PowerShell/PowerShell/pull/5999/commits/ccf17e130ce6ece68d174b76b42dc9b3cea500e5
Clear filters https://github.com/PowerShell/PowerShell/pull/5999/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
assets/Product.wxshttps://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
View file https://github.com/bergmeister/PowerShell/blob/ccf17e130ce6ece68d174b76b42dc9b3cea500e5/assets/Product.wxs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/5999/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
iSazonovhttps://github.com/iSazonov
Feb 21, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169663630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
bergmeisterhttps://github.com/bergmeister
Feb 21, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169754235
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
iSazonovhttps://github.com/iSazonov
Feb 21, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169767968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SteveL-MSFThttps://github.com/SteveL-MSFT
@TravisEz13https://github.com/TravisEz13
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
SteveL-MSFThttps://github.com/SteveL-MSFT
Feb 21, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169779708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
iSazonovhttps://github.com/iSazonov
Feb 22, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169855773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bergmeisterhttps://github.com/bergmeister
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
bergmeisterhttps://github.com/bergmeister
Feb 22, 2018https://github.com/PowerShell/PowerShell/pull/5999/files#r169876164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@iSazonovhttps://github.com/iSazonov
#6215https://github.com/PowerShell/PowerShell/issues/6215
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/5999/files
https://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
https://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
https://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
https://github.com/PowerShell/PowerShell/pull/5999/files#diff-038ca8de73484e33a7e92915e85120f8bc3246c61fc59967aa345313a6c78b29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.