| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:55485c00-dcc3-e3e4-626e-e0caadb9fb4f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B5DE:39F762:12D79C:1A7743:6A551267 |
| html-safe-nonce | c3cb33bd58acba569f60bdfe63a078d439824ff3c330d1fb4564ab739318a1f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNURFOjM5Rjc2MjoxMkQ3OUM6MUE3NzQzOjZBNTUxMjY3IiwidmlzaXRvcl9pZCI6IjE1NTc1NTU0NjA1ODgyNDU2MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 79cd89895c8a1a169c78e9fc5994726014c44a8f6886a1a82763265b0ea259bc |
| hovercard-subject-tag | pull_request:163330542 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PowerShell/5923/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/06528db30c425a9053ef8312932658bd24651520dbd1d195d58b2f9d89cb469b/PowerShell/PowerShell/pull/5923 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/06528db30c425a9053ef8312932658bd24651520dbd1d195d58b2f9d89cb469b/PowerShell/PowerShell/pull/5923 |
| og:image:alt | PR Summary
When we decided not to take #4119 it meant that the file encoding for New-ModuleManifest on Windows stayed as UTF-16 w/ BOM.
We had decided to adopt UTF-8 NoBOM as standard in PSCore6.
T... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SteveL-MSFT |
| hostname | github.com |
| expected-hostname | github.com |
| None | 682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5 |
| turbo-cache-control | no-cache |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0f2adbaa4b43ea302b02981f637a782ae92ed6dc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/PowerShell/PowerShell/pull/5923#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F5923 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F5923 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPowerShell |
| Reload | https://github.com/PowerShell/PowerShell/pull/5923 |
| Reload | https://github.com/PowerShell/PowerShell/pull/5923 |
| Reload | https://github.com/PowerShell/PowerShell/pull/5923 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
|
PowerShell
| https://github.com/PowerShell |
| PowerShell | https://github.com/PowerShell/PowerShell |
|
Notifications
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Fork
8.4k
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Star
54.4k
| https://github.com/login?return_to=%2FPowerShell%2FPowerShell |
|
Code
| https://github.com/PowerShell/PowerShell |
|
Issues
1.2k
| https://github.com/PowerShell/PowerShell/issues |
|
Pull requests
288
| https://github.com/PowerShell/PowerShell/pulls |
|
Discussions
| https://github.com/PowerShell/PowerShell/discussions |
|
Actions
| https://github.com/PowerShell/PowerShell/actions |
|
Projects
| https://github.com/PowerShell/PowerShell/projects |
|
Security and quality
3
| https://github.com/PowerShell/PowerShell/security |
|
Insights
| https://github.com/PowerShell/PowerShell/pulse |
|
Code
| https://github.com/PowerShell/PowerShell |
|
Issues
| https://github.com/PowerShell/PowerShell/issues |
|
Pull requests
| https://github.com/PowerShell/PowerShell/pulls |
|
Discussions
| https://github.com/PowerShell/PowerShell/discussions |
|
Actions
| https://github.com/PowerShell/PowerShell/actions |
|
Projects
| https://github.com/PowerShell/PowerShell/projects |
|
Security and quality
| https://github.com/PowerShell/PowerShell/security |
|
Insights
| https://github.com/PowerShell/PowerShell/pulse |
| adityapatwardhan | https://github.com/adityapatwardhan |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| SteveL-MSFT:new-manifest-utf8 | https://github.com/SteveL-MSFT/PowerShell/tree/new-manifest-utf8 |
| Conversation | https://github.com/PowerShell/PowerShell/pull/5923 |
| Commits3 (3) | https://github.com/PowerShell/PowerShell/pull/5923/commits |
| Checks | https://github.com/PowerShell/PowerShell/pull/5923/checks |
| Files changed | https://github.com/PowerShell/PowerShell/pull/5923/files |
| Encoding for New-ModuleManifest on all platforms should be UTF-8 NoBOM | https://github.com/PowerShell/PowerShell/pull/5923#top |
| adityapatwardhan | https://github.com/adityapatwardhan |
| PowerShell:master | https://github.com/PowerShell/PowerShell/tree/master |
| SteveL-MSFT:new-manifest-utf8 | https://github.com/SteveL-MSFT/PowerShell/tree/new-manifest-utf8 |
|
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#issue-289113516 |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
| #4119 | https://github.com/PowerShell/PowerShell/pull/4119 |
| PR has a meaningful title | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Summarized changes | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| Documentation needed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission |
| update file encoding of New-ModuleManifest MicrosoftDocs/PowerShell-Docs#2064 | https://github.com/MicrosoftDocs/PowerShell-Docs/pull/2064 |
| Change is not breaking | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes |
| Make sure you've added a new test if existing tests do not effectively test the code changed | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting |
| Add [feature] if the change is significant or affects feature tests | https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr |
| Work in Progress | https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
|
| https://github.com/SteveL-MSFT |
| encoding for new-modulemanifest on all platforms should be utf8nobom | https://github.com/PowerShell/PowerShell/pull/5923/commits/361c34da8e9c7d78d81e2f8d8f4a6d755a9e45e9 |
| 361c34d | https://github.com/PowerShell/PowerShell/pull/5923/commits/361c34da8e9c7d78d81e2f8d8f4a6d755a9e45e9 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
|
Breaking-Change
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ABreaking-Change |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#event-1427391473 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| adityapatwardhan | https://github.com/adityapatwardhan |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#event-1427391475 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| anmenaga | https://github.com/anmenaga |
| January 17, 2018 01:33 | https://github.com/PowerShell/PowerShell/pull/5923#event-1427391476 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| BrucePay | https://github.com/BrucePay |
| daxian-dbw | https://github.com/daxian-dbw |
| lzybkr | https://github.com/lzybkr |
| code owners | https://github.com/PowerShell/PowerShell/blob/3f9564e665a976b98ef08c793def98e32f1b8748/.github/CODEOWNERS#L44 |
| January 17, 2018 01:33 | https://github.com/PowerShell/PowerShell/pull/5923#event-1427391485 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
|
Jan 17, 2018
| https://github.com/PowerShell/PowerShell/pull/5923#ref-pullrequest-289114387 |
|
update file encoding of New-ModuleManifest
MicrosoftDocs/PowerShell-Docs#2064
| https://github.com/MicrosoftDocs/PowerShell-Docs/pull/2064 |
| https://github.com/adityapatwardhan |
| adityapatwardhan | https://github.com/adityapatwardhan |
|
Jan 17, 2018
| https://github.com/PowerShell/PowerShell/pull/5923#pullrequestreview-89306411 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/5923/files/361c34da8e9c7d78d81e2f8d8f4a6d755a9e45e9 |
| src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs | https://github.com/PowerShell/PowerShell/pull/5923/files/361c34da8e9c7d78d81e2f8d8f4a6d755a9e45e9#diff-4af74ffbc208d7a2ebb48c410311f8519d52cb7b9afd7b81bd9ae9f49e72f03e |
| adityapatwardhan | https://github.com/adityapatwardhan |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161936707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161938184 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
| test/powershell/engine/Module/NewModuleManifest.Tests.ps1 | https://github.com/PowerShell/PowerShell/pull/5923/files/361c34da8e9c7d78d81e2f8d8f4a6d755a9e45e9#diff-e89710daf5b97471eedc18b7dafa668365579ef6cc7e7a83acfa6c59aa8d40e7 |
| adityapatwardhan | https://github.com/adityapatwardhan |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161937527 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161938201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
|
| https://github.com/SteveL-MSFT |
| address PR feedback | https://github.com/PowerShell/PowerShell/pull/5923/commits/952a576e3e90f234d8d0f7db42f1bc094cb4af3a |
| 952a576 | https://github.com/PowerShell/PowerShell/pull/5923/commits/952a576e3e90f234d8d0f7db42f1bc094cb4af3a |
| https://github.com/adityapatwardhan |
| adityapatwardhan | https://github.com/adityapatwardhan |
|
Jan 17, 2018
| https://github.com/PowerShell/PowerShell/pull/5923#pullrequestreview-89312914 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/5923/files/952a576e3e90f234d8d0f7db42f1bc094cb4af3a |
| src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs | https://github.com/PowerShell/PowerShell/pull/5923/files/952a576e3e90f234d8d0f7db42f1bc094cb4af3a#diff-4af74ffbc208d7a2ebb48c410311f8519d52cb7b9afd7b81bd9ae9f49e72f03e |
| adityapatwardhan | https://github.com/adityapatwardhan |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161942317 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| Jan 17, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#discussion_r161947576 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
|
| https://github.com/SteveL-MSFT |
| fix test | https://github.com/PowerShell/PowerShell/pull/5923/commits/8f80cc92c8e79f506a65f9ea9152d79c491edc8c |
| 8f80cc9 | https://github.com/PowerShell/PowerShell/pull/5923/commits/8f80cc92c8e79f506a65f9ea9152d79c491edc8c |
| https://github.com/adityapatwardhan |
| adityapatwardhan | https://github.com/adityapatwardhan |
|
Jan 17, 2018
| https://github.com/PowerShell/PowerShell/pull/5923#pullrequestreview-89539831 |
|
View reviewed changes
| https://github.com/PowerShell/PowerShell/pull/5923/files/8f80cc92c8e79f506a65f9ea9152d79c491edc8c |
| https://github.com/adityapatwardhan |
| adityapatwardhan | https://github.com/adityapatwardhan |
| 7437f3d | https://github.com/PowerShell/PowerShell/commit/7437f3dd3ad97c1df5f34f962969a7f593ae79b8 |
| Jan 18, 2018 | https://github.com/PowerShell/PowerShell/pull/5923#event-1429457492 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
| January 31, 2018 05:14 | https://github.com/PowerShell/PowerShell/pull/5923#event-1450027071 |
| https://github.com/SteveL-MSFT |
| SteveL-MSFT | https://github.com/SteveL-MSFT |
|
Feb 7, 2018
| https://github.com/PowerShell/PowerShell/pull/5923#ref-pullrequest-288121613 |
|
Fix New-ModuleManifest encoding in What's New 6.0
MicrosoftDocs/PowerShell-Docs#2048
| https://github.com/MicrosoftDocs/PowerShell-Docs/pull/2048 |
| https://github.co/hiddenchars |
| https://github.com/PowerShell/PowerShell/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F5923 |
|
| https://github.com/adityapatwardhan |
|
adityapatwardhan
| https://github.com/adityapatwardhan |
|
| https://github.com/PowerShell/PowerShell/pull/5923/files/8f80cc92c8e79f506a65f9ea9152d79c491edc8c |
|
| https://github.com/anmenaga |
|
anmenaga
| https://github.com/anmenaga |
|
| https://github.com/BrucePay |
|
BrucePay
| https://github.com/BrucePay |
|
| https://github.com/daxian-dbw |
|
daxian-dbw
| https://github.com/daxian-dbw |
|
| https://github.com/lzybkr |
|
lzybkr
| https://github.com/lzybkr |
|
| https://github.com/adityapatwardhan |
|
adityapatwardhan
| https://github.com/adityapatwardhan |
|
Breaking-Change
| https://github.com/PowerShell/PowerShell/issues?q=state%3Aopen%20label%3ABreaking-Change |
| Please reload this page | https://github.com/PowerShell/PowerShell/pull/5923 |
|
| https://github.com/SteveL-MSFT |
|
| https://github.com/adityapatwardhan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |