Title: Update a flaky test that fails intermittently in CI by daxian-dbw · Pull Request #5641 · PowerShell/PowerShell · GitHub
Open Graph Title: Update a flaky test that fails intermittently in CI by daxian-dbw · Pull Request #5641 · PowerShell/PowerShell
X Title: Update a flaky test that fails intermittently in CI by daxian-dbw · Pull Request #5641 · PowerShell/PowerShell
Description: PR Summary Close #5627 Update a flaky test that fails intermittently in our CI builds: [-] Validate running time ' NotNullFunc -Value $byteArray ' 88ms Expected {35} to be less than {22} at line: 343 in /Users/travis/build/PowerShell/PowerShell/test/powershell/engine/Basic/ValidateAttributes.Tests.ps1 343: (Measure-Command $ScriptBlock).Milliseconds | Should BeLessThan $expected The tests were added along with the fix for the issue #5417. The tests are to validate that we don't check each element of a value-type collection argument. This fix is to increase the upper bound of the expected time to 200ms, which is still way less than the time it would take before the fix -- more than 2000ms for a byte collection of 28mb in size. PR Checklist Note: Please mark anything not applicable to this PR NA. PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes [NA] Update the changelog [NA] User facing Documentation needed [NA] Issue filed - Issue link: Change is not breaking [NA] Make sure you've added a new test, if existing tests do not effectively test the code changed [NA] Add [feature] if the change is significant or affectes feature tests
Open Graph Description: PR Summary Close #5627 Update a flaky test that fails intermittently in our CI builds: [-] Validate running time ' NotNullFunc -Value $byteArray ' 88ms Expected {35} to be less than {22}...
X Description: PR Summary Close #5627 Update a flaky test that fails intermittently in our CI builds: [-] Validate running time ' NotNullFunc -Value $byteArray ' 88ms Expected {35} to be less t...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/5641
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d5330662-1435-d75b-9def-d374e86ebeff |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC7E:35CE3D:1B759C:281B8D:6A576E79 |
| html-safe-nonce | 447aba152c8a8c293d721b0961e6d4d32a18f009040593faf34979c120c50e05 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzdFOjM1Q0UzRDoxQjc1OUM6MjgxQjhEOjZBNTc2RTc5IiwidmlzaXRvcl9pZCI6IjczMDU1MzY0ODIzMjAwMTkwNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | df5d0c258051fb2600a971f25ab3c3c727c9ba4ace231c79e1844bc2ac1734bb |
| hovercard-subject-tag | pull_request:156804488 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/5641/files |
| twitter:image | https://avatars.githubusercontent.com/u/127450?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/127450?s=400&v=4 |
| og:image:alt | PR Summary Close #5627 Update a flaky test that fails intermittently in our CI builds: [-] Validate running time ' NotNullFunc -Value $byteArray ' 88ms Expected {35} to be less than {22}... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c0ca805e53f128ba1f966be1d3ccd81d0d1959c7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width