René's URL Explorer Experiment


Title: Create generic Linux-x64 packages that are portable to all supported Linux distros by daxian-dbw · Pull Request #4902 · PowerShell/PowerShell · GitHub

Open Graph Title: Create generic Linux-x64 packages that are portable to all supported Linux distros by daxian-dbw · Pull Request #4902 · PowerShell/PowerShell

X Title: Create generic Linux-x64 packages that are portable to all supported Linux distros by daxian-dbw · Pull Request #4902 · PowerShell/PowerShell

Description: Update build and package scripts to create portable Linux packages. Fix the second task of #3961 Update packaging script to package native binaries published and remove unneeded dependencies Help Needed I need help from the team to verify the single DEB/RPM package on different distros. Background Information "RID Linux-x64 isn't any different from Ubuntu.16.04-x64. The change we've made to enable the portable Linux-x64 rid was that we dynamically load OpenSSL and ICU libraries at runtime and we can also handle few missing APIs in various versions of CURL, so we can handle subtle differences between the distros. We don't build any distro specific binaries, so the dotnet publish publishes the same files when using those 2 RIDs respectively." See #3961 (comment) "if you build the libpsl-native.so on CentOS 7, then it should be as portable as the dotnet stuff (we build it on CentOS 7 to ensure that it doesn't depend on newer glibc)." See #3961 (comment) Therefore, we need to use the Linux-x64 libpsl-native.so built on CentOS 7 for all Linux distros. The way to do that is to create nuget package for libpsl and consume it from our build. Native Dependencies of dotnet-runtime-2.0.0 packages The dependencies below were got by inspecting the dotnet-runtime-2.0.0 packages (You can get those packages from https://www.microsoft.com/net/download/linux). DEB Ubuntu 16.04 depends libc6, libcurl3, libgcc1, libgssapi-krb5-2, liblttng-ust0, libstdc++6, libunwind8, libuuid1, zlib1g, libssl1.0.0, libicu55 Ubuntu 14.04 depends libc6, libcurl3, libgcc1, libgssapi-krb5-2, liblttng-ust0, libstdc++6, libunwind8, libuuid1, zlib1g, libssl1.0.0, libicu52 Ubuntu 17.04 depends libc6, libcurl3, libgcc1, libgssapi-krb5-2, liblttng-ust0, libstdc++6, libunwind8, libuuid1, zlib1g, libssl1.0.0, libicu57 Debian-stretch (9) depends libc6, libcurl3, libgcc1, libgssapi-krb5-2, liblttng-ust0, libstdc++6, libunwind8, libuuid1, zlib1g, libssl1.0.2, libicu57 Debian-jessie (8) depends libc6, libcurl3, libgcc1, libgssapi-krb5-2, liblttng-ust0, libstdc++6, libunwind8, libuuid1, zlib1g, libssl1.0.0, libicu52 RPM CentOS 7/Oracle Linux 7/openSUSE depend openssl-libs, libcurl However, when installing dotnet-sdk-2.0.0, two more packages are required to be manually installed: libunwind, libicu. Fedora 26 openssl-libs, libcurl However, when installing dotnet-sdk-2.0.0, three more packages are required to be manually installed: libunwind, libicu, compat-openssl10 As shown above: The only difference in DEB world is libicu (libicu52, libicu55, libicu57). The only difference in RPM world is that Fedora needs compat-openssl10 (see https://www.microsoft.com/net/core#linuxfedora). compat-openssl10 might be required only for dotnet-sdk toolings, but I'm not sure. Major Changes Move the Unix native component build out of Start-PSBuild to Start-BuildNativeUnixBinaries Pack libps1-native into a nuget package libpsl. It includes binaries for linux-x64, linux-arm and osx. NOTE: the linux-x64 version libps1-native.so is built on CentOS 7. Update the package script to use the correct dependencies and also use names for .deb and .rpm names. NOTE1: for DEB, since libicu is different on different distros, I decided to use libicu-dev which will pull in the correct packages for libicu for different distros. NOTE2: for RPM, since compat-openssl10 is only available to Fedora, I don't include it in the dependencies. We can do the same as .NET Core (https://www.microsoft.com/net/core#linuxfedora), asking Fedora users to install compat-openssl10 manually. NOTE3: the updated package names are: powershell_6.0.0-beta.20_amd64.deb and powershell-6.0.0_beta.22-1.rhel.7.x86_64.rpm. I use rhel.7 because dotnet-runtime-2.0.0 use it in the name dotnet-runtime-2.0.0-rhel.7-x64.rpm. Distros that I have verified DEB package built from Ubuntu.16.04 Works on Ubuntu.16.04 and Ubuntu.14.04 Haven't tried on Ubuntu.17.04, Debian 8 and Debian 9 RPM package built from CentOS 7 Works on CentOS7, openSUSE.42.2 Attention: installing RPM on openSUSE has the same issue as dotnet-runtime-2.0.0 package. It's quoted below from https://www.microsoft.com/net/core#linuxopensuse. Haven't tried on other RedHat distros "Note: When installing the SDK, SUSE and OpenSUSE may report that nothing provides libcurl. libcurl should already be installed on supported versions of both distros. Run zypper search libcurl to confirm. The error will present 2 'solutions'. Choose 'Solution 2' to continue installing .NET Core."

Open Graph Description: Update build and package scripts to create portable Linux packages. Fix the second task of #3961 Update packaging script to package native binaries published and remove unneeded dependencies Hel...

X Description: Update build and package scripts to create portable Linux packages. Fix the second task of #3961 Update packaging script to package native binaries published and remove unneeded dependencies Hel...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/4902

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78b682b5-9297-344c-38e8-34456f3f6b7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFA0:1A676A:59A16A:81AD5F:6AFD89E1
html-safe-nonce6501210bd3eb0ad763d097fb454f0b41b992f9b6b3356d41a5238c69a364ad06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkEwOjFBNjc2QTo1OUExNkE6ODFBRDVGOjZBRkQ4OUUxIiwidmlzaXRvcl9pZCI6IjY0MDI2NDQ4NzEwNjgwOTI4OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7db75c131d634af1d2df073e774d8faa41af2b03f25feff16eddc0808d0670e9
hovercard-subject-tagpull_request:142689820
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/4902/files
twitter:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/127450?s=400&v=4
og:image:altUpdate build and package scripts to create portable Linux packages. Fix the second task of #3961 Update packaging script to package native binaries published and remove unneeded dependencies Hel...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/4902/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F4902%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F4902%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/4902/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/4902/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/4902/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Travis Plunk (TravisEz13)https://github.com/TravisEz13
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
daxian-dbw:portablebuildhttps://github.com/daxian-dbw/PowerShell/tree/portablebuild
Conversation 6 https://github.com/PowerShell/PowerShell/pull/4902
Commits 4 https://github.com/PowerShell/PowerShell/pull/4902/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/4902/checks
Files changed https://github.com/PowerShell/PowerShell/pull/4902/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
Create generic Linux-x64 packages that are portable to all supported Linux distros https://github.com/PowerShell/PowerShell/pull/4902/files#top
Show all changes 4 commits https://github.com/PowerShell/PowerShell/pull/4902/files
5704b4b Update dependencies and other things daxian-dbw Sep 22, 2017 https://github.com/PowerShell/PowerShell/pull/4902/commits/5704b4b69809d87bd09382223e4e2f812699c936
a1c7c5f Update 'Start-PSBuild' to not build native for Unix daxian-dbw Sep 22, 2017 https://github.com/PowerShell/PowerShell/pull/4902/commits/a1c7c5f772f49b2b9b2e0e7c45cf525eb04abdcd
a767191 Build and publish libpsl-native as .nupkg daxian-dbw Sep 22, 2017 https://github.com/PowerShell/PowerShell/pull/4902/commits/a767191e1c11d136bf94cf97d26404b3efa295c6
89c096c [Feature] Remove the unused parameter daxian-dbw Sep 22, 2017 https://github.com/PowerShell/PowerShell/pull/4902/commits/89c096cbfe0ef7599d68a7a87e0430177e5f6799
Clear filters https://github.com/PowerShell/PowerShell/pull/4902/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
build.psm1 https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
powershell-unix.csproj https://github.com/PowerShell/PowerShell/pull/4902/files#diff-aacdc6d61a824ac4db84f3c082a2696b3a14ac533a790461a81f634bb6fced6a
packaging.psm1 https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L63
build.psm1https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
View file https://github.com/daxian-dbw/PowerShell/blob/89c096cbfe0ef7599d68a7a87e0430177e5f6799/build.psm1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/4902/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914a
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L62
src/powershell-unix/powershell-unix.csprojhttps://github.com/PowerShell/PowerShell/pull/4902/files#diff-aacdc6d61a824ac4db84f3c082a2696b3a14ac533a790461a81f634bb6fced6a
View file https://github.com/daxian-dbw/PowerShell/blob/89c096cbfe0ef7599d68a7a87e0430177e5f6799/src/powershell-unix/powershell-unix.csproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/4902/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-aacdc6d61a824ac4db84f3c082a2696b3a14ac533a790461a81f634bb6fced6a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-aacdc6d61a824ac4db84f3c082a2696b3a14ac533a790461a81f634bb6fced6a
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-aacdc6d61a824ac4db84f3c082a2696b3a14ac533a790461a81f634bb6fced6a
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L64
tools/packaging/packaging.psm1https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
View file https://github.com/daxian-dbw/PowerShell/blob/89c096cbfe0ef7599d68a7a87e0430177e5f6799/tools/packaging/packaging.psm1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/4902/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
Travis Plunk (TravisEz13)https://github.com/TravisEz13
Sep 25, 2017https://github.com/PowerShell/PowerShell/pull/4902/files#r140845886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Sep 25, 2017https://github.com/PowerShell/PowerShell/pull/4902/files#r140901764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
Travis Plunk (TravisEz13)https://github.com/TravisEz13
Sep 25, 2017https://github.com/PowerShell/PowerShell/pull/4902/files#r140847602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
Sep 25, 2017https://github.com/PowerShell/PowerShell/pull/4902/files#r140902057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3961https://github.com/PowerShell/PowerShell/issues/3961
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/4902/files
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com/PowerShell/PowerShell/pull/4902/files#diff-8ac11d6f4bbedfce810550a3f8cfd0ee21f8b14085a5764d38577994c7e7c736
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.