Title: Fixes SSH Remoting KeyFilePath Parameter by PaulHigin · Pull Request #4529 · PowerShell/PowerShell · GitHub
Open Graph Title: Fixes SSH Remoting KeyFilePath Parameter by PaulHigin · Pull Request #4529 · PowerShell/PowerShell
X Title: Fixes SSH Remoting KeyFilePath Parameter by PaulHigin · Pull Request #4529 · PowerShell/PowerShell
Description: This change addresses issue #4475. When creating the SSH child process for remoting the KeyFilePath parameter path was enclosed in double quotes to handle potential space characters in the file path. The problem was that the new SSH child process creation code was leaving the quote characters in the key filepath causing SSH to fail to find the key file. In addition KeyFilePath paths with space characters were not being handled correctly. With this change the KeyFilePath parameter now works as expected: PS > New-PSSession -HostName Machine1 -UserName User1 -KeyFilePath c:\users\User1\Keys\User1Key PS > New-PSSession -HostName Machine2 -UserName User2 -KeyFilePath "c:\users\User2\My Keys\User2Key" This worked correctly on Windows and only failed on Linux systems using the new SSH process creation code. I also noticed and fixed a problem where trying to back out of a SSH remoting password prompt resulted in a hang (until the 1 minute protocol timeout occurred). PS > New-PSSession -HostName Machine1 -UserName User1 User1@Machine1's password: Ctrl+C The problem was that the client side connection did not end. Fix is to add CloseAsync override to close the connection.
Open Graph Description: This change addresses issue #4475. When creating the SSH child process for remoting the KeyFilePath parameter path was enclosed in double quotes to handle potential space characters in the file pat...
X Description: This change addresses issue #4475. When creating the SSH child process for remoting the KeyFilePath parameter path was enclosed in double quotes to handle potential space characters in the file pat...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/4529
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7e86144e-1f66-c780-8395-822c4658e887 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C6EE:4364C:FD56D6:15729BA:6A594862 |
| html-safe-nonce | 2d8c7607911bc53985cfb208a5d21c0ff286895e393a5e9d0707aab792c022f1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkVFOjQzNjRDOkZENTZENjoxNTcyOUJBOjZBNTk0ODYyIiwidmlzaXRvcl9pZCI6Ijg2MTI1ODY1ODIwMTU4MjE5MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4360708960d0d027944151e52a041c4f9cd0aa1249181ab41c556f47e0c21eda |
| hovercard-subject-tag | pull_request:134762242 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/4529/files |
| twitter:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| og:image:alt | This change addresses issue #4475. When creating the SSH child process for remoting the KeyFilePath parameter path was enclosed in double quotes to handle potential space characters in the file pat... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9f801e05b35c85b2d72eae6534d2b1d4c02ba8732fd046450bab31e2f52450ce |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 49918fc503387d6d65b6bc6ce6f711c14d17bfbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width