Title: Find help again after the help cache is reset by ChrisTX · Pull Request #28294 · PowerShell/PowerShell · GitHub
Open Graph Title: Find help again after the help cache is reset by ChrisTX · Pull Request #28294 · PowerShell/PowerShell
X Title: Find help again after the help cache is reset by ChrisTX · Pull Request #28294 · PowerShell/PowerShell
Description: PR Summary Fixes #28274. When Get-Help finds the help of a cmdlet or function in a file, CommandHelpProvider sets the HelpFile property of the command to the full path of that file. From then on, FindHelpFile()/GetHelpFile() load that path directly instead of searching for the help. Reset() runs after Update-Help and when the UI culture changes. It clears the cached help, but leaves those full paths in place, so the session keeps loading the help from the same file: After Update-Help -Scope CurrentUser, help in $PSHOME that was loaded before keeps winning over the newly installed CurrentUser help, which is searched first otherwise (#28274). After the UI culture changes, the help stays in the previous culture. This PR makes CommandHelpProvider keep the original HelpFile value of every command it changes, and Reset() restores those values, so the help is searched for again. The original values are kept in a ConditionalWeakTable, so commands of removed modules aren't kept alive until the next reset. HelpFile still shows the full path of the help file after Get-Help, as before. The new test in HelpSystem.Tests.ps1 covers the UI culture case, as it doesn't need help in $PSHOME: a script module with help in en-US and de-DE, Get-Help in en-US, then in de-DE. Without the fix, the second Get-Help returns the en-US help. PR Context Get-Help in a session returns outdated help after Update-Help or a change of the UI culture, until a new session is started. This also makes HelpSystem.Tests.ps1 fail when $PSHOME contains help: "Validate that get-help works for CurrentUserScope" installs the test help in the CurrentUser scope, but gets the help from $PSHOME that an earlier test loaded. I built and tested the change on 7.6.9 (HelpSystem.Tests.ps1 passes, including with help in $PSHOME, and the new test fails without the fix). It applies cleanly to master, but I don't have the .NET 11 SDK master needs here, so the build on master is left to CI. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed 🤖 Generated with Claude Code
Open Graph Description: PR Summary Fixes #28274. When Get-Help finds the help of a cmdlet or function in a file, CommandHelpProvider sets the HelpFile property of the command to the full path of that file. From then on, F...
X Description: PR Summary Fixes #28274. When Get-Help finds the help of a cmdlet or function in a file, CommandHelpProvider sets the HelpFile property of the command to the full path of that file. From then on, F...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/28294
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:25a533b4-4354-de4d-c5fc-0fa37078b39d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA00:27724C:C54AB:109AC4:6AFD3EBD |
| html-safe-nonce | ffc6c1ac850f8da55cd87734324c1d243c063a4d726db87a307e2425977fe64f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTAwOjI3NzI0QzpDNTRBQjoxMDlBQzQ6NkFGRDNFQkQiLCJ2aXNpdG9yX2lkIjoiODQ5MjUzODc2Mjg4NDg5MDMwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aaa57d41b943e1bd7b1a60e13ef32f955d856cc8d3c6c7d261fe8ec2223218bb |
| hovercard-subject-tag | pull_request:5092375975 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/28294/files |
| twitter:image | https://avatars.githubusercontent.com/u/491026?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/491026?s=400&v=4 |
| og:image:alt | PR Summary Fixes #28274. When Get-Help finds the help of a cmdlet or function in a file, CommandHelpProvider sets the HelpFile property of the command to the full path of that file. From then on, F... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | bdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 556dd37bb0aceffb25724e151b5d858b3265b40b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width