René's URL Explorer Experiment


Title: Improve Array BinaryAdd Method for object[] by jborean93 · Pull Request #23901 · PowerShell/PowerShell · GitHub

Open Graph Title: Improve Array BinaryAdd Method for object[] by jborean93 · Pull Request #23901 · PowerShell/PowerShell

X Title: Improve Array BinaryAdd Method for object[] by jborean93 · Pull Request #23901 · PowerShell/PowerShell

Description: PR Summary Use Array.Resize when doing += on an array type. This is more efficient than the default BinaryAdd done on other enumerable types. As adding to an array is a common operation done by people new to PowerShell this should reduce some of the issues which come with that type of code. An example of dramatic difference this can make is reflected by this code $s = [gc]::GetTotalAllocatedBytes($true) Measure-Command { & { $val = @() for ($i = 0; $i -lt 20000; $i++) { $val += $i } } } $e = [gc]::GetTotalAllocatedBytes($true); Write-Host "Allocated Bytes $($e-$s)" When run with the new code (TEST=true) you can see it is 8 seconds faster and requires less memory to allocate. As the arrays get larger the differences are even more profound. jborean:~/dev/PowerShell$ TEST=true debug/pwsh -File jordan.ps1 Days : 0 Hours : 0 Minutes : 0 Seconds : 0 Milliseconds : 795 Ticks : 7950790 TotalDays : 9.20230324074074E-06 TotalHours : 0.000220855277777778 TotalMinutes : 0.0132513166666667 TotalSeconds : 0.795079 TotalMilliseconds : 795.079 Allocated Bytes 1604712232 jborean:~/dev/PowerShell$ debug/pwsh -File jordan.ps1 Days : 0 Hours : 0 Minutes : 0 Seconds : 9 Milliseconds : 145 Ticks : 91453429 TotalDays : 0.000105848876157407 TotalHours : 0.00254037302777778 TotalMinutes : 0.152422381666667 TotalSeconds : 9.1453429 TotalMilliseconds : 9145.3429 Allocated Bytes 6372367600 This doesn't negate the existing performance impacts of adding to an array, it just removes extra work that wasn't needed in the first place (which was pretty inefficient) making it slower than it has to. People should still use an alternative like capturing the output from the pipeline or use List. PR Context Partially Fixes: #23899 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed - [ ] Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:

Open Graph Description: PR Summary Use Array.Resize when doing += on an array type. This is more efficient than the default BinaryAdd done on other enumerable types. As adding to an array is a common operation done by peo...

X Description: PR Summary Use Array.Resize when doing += on an array type. This is more efficient than the default BinaryAdd done on other enumerable types. As adding to an array is a common operation done by peo...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/23901

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e0d5e130-bca3-6843-0a08-db2507ae5fcb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD774:21F45C:123F9A6:1A2BB06:6AFDB6D3
html-safe-nonce39e8a02bfe18f87b6a67010f782730e7ed2f272074573cfee17bfc1b2274ea8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzc0OjIxRjQ1QzoxMjNGOUE2OjFBMkJCMDY6NkFGREI2RDMiLCJ2aXNpdG9yX2lkIjoiMTcyMjM1ODg2MTg5NDg5MTIxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93ab3ad35a837e0cade0bf54d3a63c9f7f88467e0a3fd01f3f6ee311d5dca9a0
hovercard-subject-tagpull_request:1908375018
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/23901/files
twitter:imagehttps://avatars.githubusercontent.com/u/8462645?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8462645?s=400&v=4
og:image:altPR Summary Use Array.Resize when doing += on an array type. This is more efficient than the default BinaryAdd done on other enumerable types. As adding to an array is a common operation done by peo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None8309f07eb60a4237a657068c83d0bb57be4c7e02937f5e9933126f4bd596aac4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f7154d847f1ddc5baa83b109a3e1d924605e2a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/23901/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F23901%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F23901%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/23901/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/23901/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/23901/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests366 (366)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Dongbo Wang (daxian-dbw)https://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
jborean93:array-addhttps://github.com/jborean93/PowerShell/tree/array-add
Conversation 17 https://github.com/PowerShell/PowerShell/pull/23901
Commits 1 https://github.com/PowerShell/PowerShell/pull/23901/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/23901/checks
Files changed https://github.com/PowerShell/PowerShell/pull/23901/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/23901/files
Improve Array BinaryAdd Method for object[] https://github.com/PowerShell/PowerShell/pull/23901/files#top
Show all changes 1 commit https://github.com/PowerShell/PowerShell/pull/23901/files
d1e58fd Improve Array BinaryAdd Method for object[] jborean93 Jun 7, 2024 https://github.com/PowerShell/PowerShell/pull/23901/commits/d1e58fda3a26b6359290aee341f7fa088acd0803
Clear filters https://github.com/PowerShell/PowerShell/pull/23901/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/23901/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/23901/files
Compiler.cs https://github.com/PowerShell/PowerShell/pull/23901/files#diff-9187d207767f8dde169abec7fb461e2f26c03d92dc2c9962067bb14cfb8f41e0
Binders.cs https://github.com/PowerShell/PowerShell/pull/23901/files#diff-f88a08a85a812ceafb9f51639c1926d388d0c69b22a726397abb20d255442852
ArrayOps.cs https://github.com/PowerShell/PowerShell/pull/23901/files#diff-1801d375d4eea6b1f39e39fecc12a83209b7374ffd364accb7f42c89bc6fba29
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L49
src/System.Management.Automation/engine/parser/Compiler.cshttps://github.com/PowerShell/PowerShell/pull/23901/files#diff-9187d207767f8dde169abec7fb461e2f26c03d92dc2c9962067bb14cfb8f41e0
View file https://github.com/jborean93/PowerShell/blob/d1e58fda3a26b6359290aee341f7fa088acd0803/src/System.Management.Automation/engine/parser/Compiler.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/23901/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-9187d207767f8dde169abec7fb461e2f26c03d92dc2c9962067bb14cfb8f41e0
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-9187d207767f8dde169abec7fb461e2f26c03d92dc2c9962067bb14cfb8f41e0
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/runtime/Binding/Binders.cshttps://github.com/PowerShell/PowerShell/pull/23901/files#diff-f88a08a85a812ceafb9f51639c1926d388d0c69b22a726397abb20d255442852
View file https://github.com/jborean93/PowerShell/blob/d1e58fda3a26b6359290aee341f7fa088acd0803/src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/23901/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-f88a08a85a812ceafb9f51639c1926d388d0c69b22a726397abb20d255442852
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-f88a08a85a812ceafb9f51639c1926d388d0c69b22a726397abb20d255442852
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/runtime/Operations/ArrayOps.cshttps://github.com/PowerShell/PowerShell/pull/23901/files#diff-1801d375d4eea6b1f39e39fecc12a83209b7374ffd364accb7f42c89bc6fba29
View file https://github.com/jborean93/PowerShell/blob/d1e58fda3a26b6359290aee341f7fa088acd0803/src/System.Management.Automation/engine/runtime/Operations/ArrayOps.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/23901/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-1801d375d4eea6b1f39e39fecc12a83209b7374ffd364accb7f42c89bc6fba29
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/23901/files
https://github.com/PowerShell/PowerShell/pull/23901/files#diff-1801d375d4eea6b1f39e39fecc12a83209b7374ffd364accb7f42c89bc6fba29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.