Title: Fix implicit remoting proxy cmdlets to act on common parameters by SteveL-MSFT · Pull Request #20367 · PowerShell/PowerShell · GitHub
Open Graph Title: Fix implicit remoting proxy cmdlets to act on common parameters by SteveL-MSFT · Pull Request #20367 · PowerShell/PowerShell
X Title: Fix implicit remoting proxy cmdlets to act on common parameters by SteveL-MSFT · Pull Request #20367 · PowerShell/PowerShell
Description: PR Summary The PR to add ProgressAction common parameter caused this regression due to an internal helper to determine if the proxy is for a cmdlet. It expected CommonParameters to never change so if they differ, then the parameter is treated as custom so it doesn't work as expected. This works remoting from latest PS7 to latest PS7 since the common parameters match. However, latest to older PS7 or WinPS5.1 (like via WinCompat layer) fails as the new ProgressAction isn't found on the target. Fix is to exclude ProgressAction from this check to enable it to work for the other common parameters. PR Context Fix #20209 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:
Open Graph Description: PR Summary The PR to add ProgressAction common parameter caused this regression due to an internal helper to determine if the proxy is for a cmdlet. It expected CommonParameters to never change so...
X Description: PR Summary The PR to add ProgressAction common parameter caused this regression due to an internal helper to determine if the proxy is for a cmdlet. It expected CommonParameters to never change so...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/20367
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b03e52a4-471c-827b-b128-fe67656f6390 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE0C:360352:C948D:112A60:6A55481A |
| html-safe-nonce | cfcb99a3c6b30b399820f96afaf62b7ed3b789bb933624c7e690ab2529a8035c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTBDOjM2MDM1MjpDOTQ4RDoxMTJBNjA6NkE1NTQ4MUEiLCJ2aXNpdG9yX2lkIjoiNzU1NzUyNDE5Nzg1MTA4ODkyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d777be8747c822284e86394487710d3a1822c0cce7d8740378c1a90c21f0e568 |
| hovercard-subject-tag | pull_request:1529542489 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/20367/files |
| twitter:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11859881?s=400&v=4 |
| og:image:alt | PR Summary The PR to add ProgressAction common parameter caused this regression due to an internal helper to determine if the proxy is for a cmdlet. It expected CommonParameters to never change so... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width