René's URL Explorer Experiment


Title: WebCmdlets get encoding from BOM by CarloToso · Pull Request #19379 · PowerShell/PowerShell · GitHub

Open Graph Title: WebCmdlets get encoding from BOM by CarloToso · Pull Request #19379 · PowerShell/PowerShell

X Title: WebCmdlets get encoding from BOM by CarloToso · Pull Request #19379 · PowerShell/PowerShell

Description: PR Summary Add EncodingHelper to detect the response encoding from the BOM Add tests PR Context using: https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs fixes #11547 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:

Open Graph Description: PR Summary Add EncodingHelper to detect the response encoding from the BOM Add tests PR Context using: https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/Sys...

X Description: PR Summary Add EncodingHelper to detect the response encoding from the BOM Add tests PR Context using: https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/Sys...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/19379

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40a47e7d-f6f9-445a-f564-f83d7aff8411
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7F2:22FDB8:78F888:A50865:6A554BF2
html-safe-nonceb31a070a182b82eaa16a476f3dacbbc1f96df7bcb651e52448282c35d664ae1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0YyOjIyRkRCODo3OEY4ODg6QTUwODY1OjZBNTU0QkYyIiwidmlzaXRvcl9pZCI6IjE1Nzk1MzUxMzE4MTkxOTk0NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac25fd853b9c57b769b8de48ae262c878798a08f179bf927ac60dc7a396dcaa0c5
hovercard-subject-tagpull_request:1284129783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/19379/files
twitter:imagehttps://avatars.githubusercontent.com/u/105941898?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/105941898?s=400&v=4
og:image:altPR Summary Add EncodingHelper to detect the response encoding from the BOM Add tests PR Context using: https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/Sys...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/19379/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19379%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19379%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/19379/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19379/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19379/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19379/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
CarloTosohttps://github.com/CarloToso
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
CarloToso:encodinghelperhttps://github.com/CarloToso/PowerShell/tree/encodinghelper
Conversation 49 https://github.com/PowerShell/PowerShell/pull/19379
Commits 23 https://github.com/PowerShell/PowerShell/pull/19379/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/19379/checks
Files changed 3 https://github.com/PowerShell/PowerShell/pull/19379/files
WebCmdlets get encoding from BOM https://github.com/PowerShell/PowerShell/pull/19379/files#top
Show all changes 23 commits https://github.com/PowerShell/PowerShell/pull/19379/files
0cebc78 Add EncodingHelper CarloToso Mar 21, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/0cebc7862312f7e0182e6dbda5148ba533673e40
dd9811b remove const CarloToso Mar 21, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/dd9811b53ec5836e84730557659ddc0023dbc70a
efe8e0a add stream.length chack CarloToso Mar 21, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/efe8e0aa8d12e6eb15a1013d04ac9a0816dfb364
3d42ae5 use when CarloToso Mar 21, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/3d42ae55dce6a789bd59060b76127b9bf88603d6
b43ef89 use StreamReader detectEncodingFromByteOrderMarks CarloToso Mar 23, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/b43ef898c1d54aa6387fce915396cd4898434966
1141be9 fix return CarloToso Mar 23, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/1141be9442a590dd3236c256ea962216f5928aec
4a90872 stream leaveOpen: true CarloToso Mar 23, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/4a90872659a734cc22f586be47ff4af1f86fc024
a2233fc add tests CarloToso Mar 24, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/a2233fc7c77cfa9ca5f154af463b3eacaeeae8fc
af44f31 fix codefactor CarloToso Mar 24, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/af44f3175a1043207f25383a2a3764679bcdcb4b
314c979 fix tests CarloToso Mar 25, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/314c97964701f3c1e6033af48e9e6990540d5f0d
2d1107b reader.Peek() CarloToso Mar 25, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/2d1107b015f5638fceb05f24c8099d9e913abc15
c64591a comment out reader.Peek() CarloToso Mar 26, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/c64591a5f227b1b89824c9527632bb1b84a72805
79698f3 try fix CarloToso Mar 26, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/79698f35926e90527168f2bad7477d7f3873b900
1a6707d Pr/19379 (#1) stevenebutler Apr 8, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/1a6707d38d65f85fc96920f66a0905207a194768
0b48687 Merge branch 'master' into encodinghelper CarloToso Apr 8, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/0b48687de5952a7e71b0ba5ef99b67a63b3400e7
08f4cda Merge branch 'master' into encodinghelper CarloToso May 3, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/08f4cda2902081052f5d601ae41ee0aefb10b0c0
3ecad71 fix nullable CarloToso May 3, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/3ecad716c36f16d33d1227dd33efdf971484e982
61b23d3 Add comments to code; better name for variable; encoding precedence t… CarloToso Dec 11, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/61b23d3e55c2eb1ff8062217269b61fbc3382b5b
c9d68d9 Merge branch 'master' into encodinghelper CarloToso Dec 11, 2023 https://github.com/PowerShell/PowerShell/pull/19379/commits/c9d68d97d7b6b5693b7f2dad9949a4670ca4184a
2edb659 Make encoding changes handle network stall timeouts stevenebutler Jan 4, 2024 https://github.com/PowerShell/PowerShell/pull/19379/commits/2edb659544b29bca6cfbd72f2a5b95f49533256c
311a0ad Merge pull request #2 from stevenebutler/encodinghelper-patch CarloToso Jan 4, 2024 https://github.com/PowerShell/PowerShell/pull/19379/commits/311a0ad73863a387b5d72c274252d3c85300a93c
bf03dfc Merge branch 'PowerShell:master' into encodinghelper CarloToso Jan 5, 2024 https://github.com/PowerShell/PowerShell/pull/19379/commits/bf03dfc0ad205e3a7df7f09d304c63b337fa3495
4abf713 Add ConfigureAwait(false) to awaits (#3) stevenebutler Jan 7, 2024 https://github.com/PowerShell/PowerShell/pull/19379/commits/4abf7139dffcbc7aa104a72fd81ed1de1784abbb
Clear filters https://github.com/PowerShell/PowerShell/pull/19379/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19379/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19379/files
StreamHelper.cs https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
WebCmdlets.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
EncodingController.cs https://github.com/PowerShell/PowerShell/pull/19379/files#diff-a30357b781b079b298edd873dd865c804c87fb13d42d4dbb745805aa1ce09366
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cshttps://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
View file https://github.com/PowerShell/PowerShell/blob/4abf7139dffcbc7aa104a72fd81ed1de1784abbb/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19379/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
View file https://github.com/PowerShell/PowerShell/blob/4abf7139dffcbc7aa104a72fd81ed1de1784abbb/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19379/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-1b256250c40f42b7c01f2695c0c908112a4eead87e3ef3ff534768ad930e7ca1
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L64
test/tools/WebListener/Controllers/EncodingController.cshttps://github.com/PowerShell/PowerShell/pull/19379/files#diff-a30357b781b079b298edd873dd865c804c87fb13d42d4dbb745805aa1ce09366
View file https://github.com/PowerShell/PowerShell/blob/4abf7139dffcbc7aa104a72fd81ed1de1784abbb/test/tools/WebListener/Controllers/EncodingController.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19379/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-a30357b781b079b298edd873dd865c804c87fb13d42d4dbb745805aa1ce09366
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19379/files
https://github.com/PowerShell/PowerShell/pull/19379/files#diff-a30357b781b079b298edd873dd865c804c87fb13d42d4dbb745805aa1ce09366
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.