René's URL Explorer Experiment


Title: Small cleanup WebCmdlets by CarloToso · Pull Request #19299 · PowerShell/PowerShell · GitHub

Open Graph Title: Small cleanup WebCmdlets by CarloToso · Pull Request #19299 · PowerShell/PowerShell

X Title: Small cleanup WebCmdlets by CarloToso · Pull Request #19299 · PowerShell/PowerShell

Description: PR Summary small cleanup InvokeRestMethodCommand.Common.cs small cleanup StreamHelper.cs Merge DecodeStream replace StreamReader with StreamHelper.GetResponseString Remove unneeded code (we already use UTF8 as default) if (string.IsNullOrEmpty(characterSet) && ContentHelper.IsJson(contentType)) { characterSet = Encoding.UTF8.HeaderName; } PR Context PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:

Open Graph Description: PR Summary small cleanup InvokeRestMethodCommand.Common.cs small cleanup StreamHelper.cs Merge DecodeStream replace StreamReader with StreamHelper.GetResponseString Remove unneeded code (...

X Description: PR Summary small cleanup InvokeRestMethodCommand.Common.cs small cleanup StreamHelper.cs Merge DecodeStream replace StreamReader with StreamHelper.GetResponseString Remove unneeded code (...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/19299

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5bdff647-bb94-5f88-d03a-0b79ab48b6af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83A0:3D5C98:4DE7BC:69F552:6A553E9F
html-safe-nonceafd68bb26dc8377283cef841cef3df0e90c6f3ebbe953f6511b12023ffc338c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0EwOjNENUM5ODo0REU3QkM6NjlGNTUyOjZBNTUzRTlGIiwidmlzaXRvcl9pZCI6IjQwMDAzMDEyNTY3MzY1ODc0MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c119dbd368f944b4b4b43a2da406646cef46856d6027617b411f6b9390d3d84
hovercard-subject-tagpull_request:1268735704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/19299/files
twitter:imagehttps://avatars.githubusercontent.com/u/105941898?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/105941898?s=400&v=4
og:image:altPR Summary small cleanup InvokeRestMethodCommand.Common.cs small cleanup StreamHelper.cs Merge DecodeStream replace StreamReader with StreamHelper.GetResponseString Remove unneeded code (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release811f50b757204c6a1b4da0ea780075b3e1cc9e57
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/19299/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19299%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19299%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/19299/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19299/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19299/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
daxian-dbwhttps://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
CarloToso:cleanup-restmethodhttps://github.com/CarloToso/PowerShell/tree/cleanup-restmethod
Conversation 18 https://github.com/PowerShell/PowerShell/pull/19299
Commits 9 https://github.com/PowerShell/PowerShell/pull/19299/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/19299/checks
Files changed https://github.com/PowerShell/PowerShell/pull/19299/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
Small cleanup WebCmdlets https://github.com/PowerShell/PowerShell/pull/19299/files#top
Show all changes 9 commits https://github.com/PowerShell/PowerShell/pull/19299/files
b3dc569 Small cleanup CarloToso Mar 9, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/b3dc569582dda98788edd545aaf4b608b249f41f
1333c50 replace var CarloToso Mar 9, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/1333c50479046b0f52ddbafd965beedf2ef66fa5
cf4b994 add ? CarloToso Mar 9, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/cf4b994fcbfd28d924aaac6b9aa87eb26a32f334
c820546 changes from #19308 CarloToso Mar 10, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/c820546e2601dac735de8e066ae90f2affe1b29a
df7ab30 merge DecodeStream CarloToso Mar 10, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/df7ab30bc75147f54370f0b6ca98d85dbe82ab62
57cbd6e remove StreamReader CarloToso Mar 10, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/57cbd6e515909cecbe2355fd508e2497588b897d
43ed05d Merge branch 'PowerShell:master' into cleanup-restmethod CarloToso Mar 13, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/43ed05d281550e2129cd8a4b8b689e09651629fb
3af2a03 revert following suggestions @daxian-dbw CarloToso Mar 13, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/3af2a034b65b39e038e7f9dccdae3778e5af710a
788f719 revert CarloToso Mar 13, 2023 https://github.com/PowerShell/PowerShell/pull/19299/commits/788f71944e0afa886605c93a6565535cd2c410c5
Clear filters https://github.com/PowerShell/PowerShell/pull/19299/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
BasicHtmlWebResponseObject.Common.cs https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
InvokeRestMethodCommand.Common.cs https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
WebRequestPSCmdlet.Common.cs https://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
WebResponseHelper.CoreClr.cs https://github.com/PowerShell/PowerShell/pull/19299/files#diff-09addb89c092e322969b2bb28a2baf1860efe2f984a99d796a2a6bcb38479168
StreamHelper.cs https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
...l.Commands.Utility/commands/utility/WebCmdlet/Common/BasicHtmlWebResponseObject.Common.cshttps://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
View file https://github.com/CarloToso/PowerShell/blob/788f71944e0afa886605c93a6565535cd2c410c5/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/BasicHtmlWebResponseObject.Common.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19299/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4a0284fed3a84615c7b131de87e030f330414625234be0e25a4cc6db66b9cca8
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
...hell.Commands.Utility/commands/utility/WebCmdlet/Common/InvokeRestMethodCommand.Common.cshttps://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
View file https://github.com/CarloToso/PowerShell/blob/788f71944e0afa886605c93a6565535cd2c410c5/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/InvokeRestMethodCommand.Common.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19299/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-4c55a0b35ba5ce69067caf76b0b94599e0ff304a67add0636bf226fc1cf0fe0f
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cshttps://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
View file https://github.com/CarloToso/PowerShell/blob/788f71944e0afa886605c93a6565535cd2c410c5/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19299/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-9e8673bc737d91c9712fa4e7e5fef6aac6690999bcbd0777759563afd015c50d
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
...werShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebResponseHelper.CoreClr.cshttps://github.com/PowerShell/PowerShell/pull/19299/files#diff-09addb89c092e322969b2bb28a2baf1860efe2f984a99d796a2a6bcb38479168
View file https://github.com/CarloToso/PowerShell/blob/788f71944e0afa886605c93a6565535cd2c410c5/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebResponseHelper.CoreClr.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19299/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-09addb89c092e322969b2bb28a2baf1860efe2f984a99d796a2a6bcb38479168
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-09addb89c092e322969b2bb28a2baf1860efe2f984a99d796a2a6bcb38479168
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cshttps://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
View file https://github.com/CarloToso/PowerShell/blob/788f71944e0afa886605c93a6565535cd2c410c5/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19299/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
iSazonovhttps://github.com/iSazonov
Mar 11, 2023https://github.com/PowerShell/PowerShell/pull/19299/files#r1133047315
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19299/files
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com/PowerShell/PowerShell/pull/19299/files#diff-cd17ef568c17aed5340e0dc2c224a29ede85a7bc19f8297339b80098cc60722d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.