René's URL Explorer Experiment


Title: Replace `Requires.NotNullOrEmpty(string)` with `ArgumentException.ThrowIfNullOrEmpty` by xtqqczze · Pull Request #19197 · PowerShell/PowerShell · GitHub

Open Graph Title: Replace `Requires.NotNullOrEmpty(string)` with `ArgumentException.ThrowIfNullOrEmpty` by xtqqczze · Pull Request #19197 · PowerShell/PowerShell

X Title: Replace `Requires.NotNullOrEmpty(string)` with `ArgumentException.ThrowIfNullOrEmpty` by xtqqczze · Pull Request #19197 · PowerShell/PowerShell

Description: Breaking change: Bucket 3: Unlikely Grey Area This PR makes changes to public APIs so that an ArgumentException is thrown instead of ArgumentNullException when a string is empty rather than null. System.Management.Automation.Subsystem.Prediction.PredictionContext.Create(String) System.Management.Automation.Subsystem.Prediction.PredictiveSuggestion..ctor(String) System.Management.Automation.Subsystem.Prediction.PredictiveSuggestion..ctor(String, String) System.Management.Automation.Subsystem.Prediction.CommandPrediction.OnSuggestionAccepted(PredictionClient, Guid, UInt32, String) If a consumer caught the ArgumentNullException and not the base class ArgumentException this is a change in behavior. However, it seems unlikely to depend on a specific exception being thrown, because if specific behavior was required, the caller could have implemented the necessary business logic.

Open Graph Description: Breaking change: Bucket 3: Unlikely Grey Area This PR makes changes to public APIs so that an ArgumentException is thrown instead of ArgumentNullException when a string is empty rather than null. ...

X Description: Breaking change: Bucket 3: Unlikely Grey Area This PR makes changes to public APIs so that an ArgumentException is thrown instead of ArgumentNullException when a string is empty rather than null. ...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/19197

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9e67a968-de4f-da25-d4fc-eb2d2ceb51c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id926C:196973:365DE:469E6:6A5546A3
html-safe-nonce9234e55e19467253260bf952f1356cbb9c02973cdd868c4574280518d160b4c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjZDOjE5Njk3MzozNjVERTo0NjlFNjo2QTU1NDZBMyIsInZpc2l0b3JfaWQiOiI4NzczMTY3NjY1Mzg2OTY0NjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb11ca956db9659659af6eababfcec8f6babc193963dc6169ba8066f9b963beb8
hovercard-subject-tagpull_request:1250889354
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/19197/files
twitter:imagehttps://avatars.githubusercontent.com/u/45661989?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45661989?s=400&v=4
og:image:altBreaking change: Bucket 3: Unlikely Grey Area This PR makes changes to public APIs so that an ArgumentException is thrown instead of ArgumentNullException when a string is empty rather than null. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/19197/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19197%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F19197%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/19197/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19197/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/19197/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19197/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
daxian-dbwhttps://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
xtqqczze:Requires.NotNullOrEmptyhttps://github.com/xtqqczze/PowerShell-PowerShell/tree/Requires.NotNullOrEmpty
Conversation 6 https://github.com/PowerShell/PowerShell/pull/19197
Commits 2 https://github.com/PowerShell/PowerShell/pull/19197/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/19197/checks
Files changed https://github.com/PowerShell/PowerShell/pull/19197/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19197/files
Replace Requires.NotNullOrEmpty(string) with ArgumentException.ThrowIfNullOrEmpty https://github.com/PowerShell/PowerShell/pull/19197/files#top
Show all changes 2 commits https://github.com/PowerShell/PowerShell/pull/19197/files
0c99171 Replace `Requires.NotNullOrEmpty` with `ArgumentException.ThrowIfNull… xtqqczze Feb 22, 2023 https://github.com/PowerShell/PowerShell/pull/19197/commits/0c99171e4b4de61a4c6e1c9a76091a4593969eb6
f16cb79 Update with changes from 79b4b5c33f6048ef9cb8b6b24400a564d57c4227 xtqqczze Feb 23, 2023 https://github.com/PowerShell/PowerShell/pull/19197/commits/f16cb7990106eaf09254f98107a5689f43fe9a02
Clear filters https://github.com/PowerShell/PowerShell/pull/19197/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19197/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/19197/files
IFeedbackProvider.cs https://github.com/PowerShell/PowerShell/pull/19197/files#diff-077e6442fe8a5ae9834d6958d6e5c6572f2471fcc667ff7c819c5b03a044e0ec
CommandPrediction.cs https://github.com/PowerShell/PowerShell/pull/19197/files#diff-7f28880eadfef0bc730aa0eca4b873d1f6060cd9329f9a0f3507e6b0717c9214
ICommandPredictor.cs https://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
Utils.cs https://github.com/PowerShell/PowerShell/pull/19197/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cshttps://github.com/PowerShell/PowerShell/pull/19197/files#diff-077e6442fe8a5ae9834d6958d6e5c6572f2471fcc667ff7c819c5b03a044e0ec
View file https://github.com/xtqqczze/PowerShell-PowerShell/blob/f16cb7990106eaf09254f98107a5689f43fe9a02/src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19197/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-077e6442fe8a5ae9834d6958d6e5c6572f2471fcc667ff7c819c5b03a044e0ec
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-077e6442fe8a5ae9834d6958d6e5c6572f2471fcc667ff7c819c5b03a044e0ec
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cshttps://github.com/PowerShell/PowerShell/pull/19197/files#diff-7f28880eadfef0bc730aa0eca4b873d1f6060cd9329f9a0f3507e6b0717c9214
View file https://github.com/xtqqczze/PowerShell-PowerShell/blob/f16cb7990106eaf09254f98107a5689f43fe9a02/src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19197/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-7f28880eadfef0bc730aa0eca4b873d1f6060cd9329f9a0f3507e6b0717c9214
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-7f28880eadfef0bc730aa0eca4b873d1f6060cd9329f9a0f3507e6b0717c9214
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/ICommandPredictor.cshttps://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
View file https://github.com/xtqqczze/PowerShell-PowerShell/blob/f16cb7990106eaf09254f98107a5689f43fe9a02/src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/ICommandPredictor.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19197/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-ca26678f79c7153126505905224c9dd6d5476240222ee5e42d47494ac36f3f58
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/engine/Utils.cshttps://github.com/PowerShell/PowerShell/pull/19197/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
View file https://github.com/xtqqczze/PowerShell-PowerShell/blob/f16cb7990106eaf09254f98107a5689f43fe9a02/src/System.Management.Automation/engine/Utils.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/19197/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
https://github.com/PowerShell/PowerShell/pull/19197/files#diff-08b9d853f19b7b63dfb6b0fa7b634db55f2a20aeed01ffb5855b3e5b0da3431b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.