Title: Fix Update-Help failing silently with implicit non-US culture. by dkaszews · Pull Request #17780 · PowerShell/PowerShell · GitHub
Open Graph Title: Fix Update-Help failing silently with implicit non-US culture. by dkaszews · Pull Request #17780 · PowerShell/PowerShell
X Title: Fix Update-Help failing silently with implicit non-US culture. by dkaszews · Pull Request #17780 · PowerShell/PowerShell
Description: PR Summary HelpCultureNotSupported is caught and ignored with implicit culture (-UICulture not given explicitly, defaults to system) to allow trying again with culture's parents. It does not however check if there are any more fallbacks, so all errors of this type are completely silenced. I store first error of this type, then show it if none of the fallbacks succeed, Fixes #17696 PR Context Update-Help with implcit culture fails silently on non-US systems (en-GB in my case), with no feedback on what is wrong even when using -Verbose. With this fix, the user is shown the same error as with explicit -UICulture (Get-UICulture), which clearly describes what they should do: Update-Help: Failed to update Help for the module(s) '...' with UI culture(s) {en-GB} : No UI culture was found that matches the following pattern: en-GB. Verify the pattern and then try the command again.. English-US help content is available and can be installed using: Update-Help -UICulture en-US. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Docs issue #9072 Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:
Open Graph Description: PR Summary HelpCultureNotSupported is caught and ignored with implicit culture (-UICulture not given explicitly, defaults to system) to allow trying again with culture's parents. It does not h...
X Description: PR Summary HelpCultureNotSupported is caught and ignored with implicit culture (-UICulture not given explicitly, defaults to system) to allow trying again with culture's parents. It does n...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/17780
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5aae522f-858d-bdd9-85e2-a8e8c414223d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BFF8:390ECE:4C98818:6BC37CF:6A56E647 |
| html-safe-nonce | d6486f829c768d177ad3935eb47f9ae7a49c1cd928cd7b42160bf40dd0e2b5b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkY4OjM5MEVDRTo0Qzk4ODE4OjZCQzM3Q0Y6NkE1NkU2NDciLCJ2aXNpdG9yX2lkIjoiMTc4ODM5MTU2MTY5ODQwMzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 801fda4119cfed30ed0f52480d01f67938584218352a59aedb89d95204b49a6c |
| hovercard-subject-tag | pull_request:1008960627 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/17780/files |
| twitter:image | https://avatars.githubusercontent.com/u/26599495?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/26599495?s=400&v=4 |
| og:image:alt | PR Summary HelpCultureNotSupported is caught and ignored with implicit culture (-UICulture not given explicitly, defaults to system) to allow trying again with culture's parents. It does not h... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8684ae1a81cd3e4ef219b241179982bbda1a5b1f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width