René's URL Explorer Experiment


Title: Improve hashtable key completion for type constrained variable assignments, nested hashtables and more by MartinGC94 · Pull Request #17660 · PowerShell/PowerShell · GitHub

Open Graph Title: Improve hashtable key completion for type constrained variable assignments, nested hashtables and more by MartinGC94 · Pull Request #17660 · PowerShell/PowerShell

X Title: Improve hashtable key completion for type constrained variable assignments, nested hashtables and more by MartinGC94 · Pull Request #17660 · PowerShell/PowerShell

Description: PR Summary Fixes PowerShell/PowerShellEditorServices#1852 Decided to make a full fix for all hashtable key completion scenarios I could think of: Fixes type inference for ConvertExpressions that use a PowerShell type that hasn't been loaded yet. Fix tab completion for constructor hashtables so it only completes properties if the class has a null constructor or if it's an interface. Fix tab completion for constructor hashtables that use a PowerShell type that hasn't been loaded yet. Fix tab completion for nested hashtables like: Get-WinEvent -FilterHashtable @{SuppressHashFilter=@{ Fix tab completion for hashtables that are in an array of arguments like: ls | select Name,@{} Add the same property completion that exists for type conversions to typed variables command parameters and Property assignments Add completion for the module specification used in using module @{ PR Context PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:

Open Graph Description: PR Summary Fixes PowerShell/PowerShellEditorServices#1852 Decided to make a full fix for all hashtable key completion scenarios I could think of: Fixes type inference for ConvertExpressions that u...

X Description: PR Summary Fixes PowerShell/PowerShellEditorServices#1852 Decided to make a full fix for all hashtable key completion scenarios I could think of: Fixes type inference for ConvertExpressions that u...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/17660

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab955ba0-002d-91c9-c369-ad87df27fd7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FAA:43A60:63E609:87CF7D:6A55467C
html-safe-noncec98aa4c7f28d301fea94598156414cf5f6366647ac411f28f6baf20cee1637f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkFBOjQzQTYwOjYzRTYwOTo4N0NGN0Q6NkE1NTQ2N0MiLCJ2aXNpdG9yX2lkIjoiNTYzOTQ3MTg2MTY0Nzg4NTk0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ea6fc35adf70c059f9c63d1e3106b152f4938b54eec44441b4de5b8064c569a
hovercard-subject-tagpull_request:992516430
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/17660/files
twitter:imagehttps://avatars.githubusercontent.com/u/42123497?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/42123497?s=400&v=4
og:image:altPR Summary Fixes PowerShell/PowerShellEditorServices#1852 Decided to make a full fix for all hashtable key completion scenarios I could think of: Fixes type inference for ConvertExpressions that u...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/17660/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F17660%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F17660%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/17660/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/17660/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/17660/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/17660/files
PowerShell https://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Notifications https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Fork 8.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Star 54.4k https://github.com/login?return_to=%2FPowerShell%2FPowerShell
Code https://github.com/PowerShell/PowerShell
Issues 1.2k https://github.com/PowerShell/PowerShell/issues
Pull requests 287 https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality 3 https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Code https://github.com/PowerShell/PowerShell
Issues https://github.com/PowerShell/PowerShell/issues
Pull requests https://github.com/PowerShell/PowerShell/pulls
Discussions https://github.com/PowerShell/PowerShell/discussions
Actions https://github.com/PowerShell/PowerShell/actions
Projects https://github.com/PowerShell/PowerShell/projects
Security and quality https://github.com/PowerShell/PowerShell/security
Insights https://github.com/PowerShell/PowerShell/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
daxian-dbwhttps://github.com/daxian-dbw
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
MartinGC94:AddCompletionForTypedVariableshttps://github.com/MartinGC94/PowerShell/tree/AddCompletionForTypedVariables
Conversation 35 https://github.com/PowerShell/PowerShell/pull/17660
Commits 11 https://github.com/PowerShell/PowerShell/pull/17660/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/17660/checks
Files changed https://github.com/PowerShell/PowerShell/pull/17660/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/17660/files
Improve hashtable key completion for type constrained variable assignments, nested hashtables and more https://github.com/PowerShell/PowerShell/pull/17660/files#top
Show all changes 11 commits https://github.com/PowerShell/PowerShell/pull/17660/files
15aae32 Add completion for hashtable property definitions for typed variables… MartinGC94 Jul 10, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/15aae3273add48b369e2a2a72692c7292da41aba
f7fdcb1 Fixes type inference for ConvertExpressions that use a PowerShell typ… MartinGC94 Aug 8, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/f7fdcb173287f398329ef8d41849422027a8a02a
7bf6736 Merge branch 'master' into AddCompletionForTypedVariables MartinGC94 Aug 9, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/7bf673693bd7581c99eb77fbb1763fa4c4209936
1455f2e Add missing tests MartinGC94 Aug 11, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/1455f2eda4f85b45d80efc0e20b9118b8c71e680
5a46afd Exclude interfaces from the null constructor check MartinGC94 Aug 12, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/5a46afde380297f2341a07c45e382cee281bcec6
c715ee5 Add completion for module specification keys in using module statement MartinGC94 Aug 18, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/c715ee553a570b8fb3a7a32aec46f0526068b270
eb05d9e Merge branch 'master' into AddCompletionForTypedVariables MartinGC94 Nov 22, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/eb05d9e88810a071279aba07e8d256caa0db6d4f
31474e2 Merge branch 'PowerShell:master' into AddCompletionForTypedVariables MartinGC94 Dec 14, 2022 https://github.com/PowerShell/PowerShell/pull/17660/commits/31474e2d462b3ec174ae35d0cb5ceabb9f80aa62
81f5468 Merge branch 'PowerShell:master' into AddCompletionForTypedVariables MartinGC94 Apr 25, 2023 https://github.com/PowerShell/PowerShell/pull/17660/commits/81f54683bcd754406ae9b5c62c50a02b30696d84
7e435e5 Apply Dongbo suggestion. MartinGC94 Apr 25, 2023 https://github.com/PowerShell/PowerShell/pull/17660/commits/7e435e59b4fd8a6b906bc4607b1bcf56cbaa0dfd
12cf01f Return early when encountering unexpected Ast MartinGC94 Apr 28, 2023 https://github.com/PowerShell/PowerShell/pull/17660/commits/12cf01fad72c4716421f7fc1e91bbf83b9760881
Clear filters https://github.com/PowerShell/PowerShell/pull/17660/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/17660/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/17660/files
CompletionCompleters.cs https://github.com/PowerShell/PowerShell/pull/17660/files#diff-a9d279ca59037e4fccfc4a0a6f23c87c5555b78dead860918c91168055d57933
TypeInferenceVisitor.cs https://github.com/PowerShell/PowerShell/pull/17660/files#diff-30feea0794a0191c121a83e2fa60dbacf701dd9c5be6c4d57b1865cdee745d6b
TabCompletion.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/17660/files#diff-393e1fa171a673ad5e5c3c1f3700ad03d32d46031ffcf72e4eaac1a7c7c46579
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/17660/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.