Title: Add fix of process objects for processes that have exited. by PaulHigin · Pull Request #16946 · PowerShell/PowerShell · GitHub
Open Graph Title: Add fix of process objects for processes that have exited. by PaulHigin · Pull Request #16946 · PowerShell/PowerShell
X Title: Add fix of process objects for processes that have exited. by PaulHigin · Pull Request #16946 · PowerShell/PowerShell
Description: PR Summary This PR fixes the Enter-PSHostProcess and Get-PSHostProcessInfo cmdlets so that they will ignore processes that have already exited. PR Context .NET GetProcess method sometimes returns process objects for processes that have recently exited. In addition, the exited process object will throw if some properties are accessed (process.ProcessName), causing the cmdlet to fail and in turn causing some tests to fail. This fix ignores already exited process objects. This appears to be a .NET 7 regression, and I have created an Issue in that repo: dotnet/runtime#66096 PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:
Open Graph Description: PR Summary This PR fixes the Enter-PSHostProcess and Get-PSHostProcessInfo cmdlets so that they will ignore processes that have already exited. PR Context .NET GetProcess method sometimes returns p...
X Description: PR Summary This PR fixes the Enter-PSHostProcess and Get-PSHostProcessInfo cmdlets so that they will ignore processes that have already exited. PR Context .NET GetProcess method sometimes returns p...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/16946
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f70c521a-5fd3-f486-d8c4-6e98dbe3a617 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9858:24A400:223574:2F05B6:6A5537BE |
| html-safe-nonce | 6f1c14428e7544be1d0d2e56cba306539702523567acb912fcff7fb19f02e21f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODU4OjI0QTQwMDoyMjM1NzQ6MkYwNUI2OjZBNTUzN0JFIiwidmlzaXRvcl9pZCI6IjY2ODAxMzEzMTc3OTgzNTI4MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3435d7053e0254cb0e03f6144a1e1dc7f484cd7c2fbcc1239f8b5c8692fe5d49 |
| hovercard-subject-tag | pull_request:868407329 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/16946/files |
| twitter:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| og:image:alt | PR Summary This PR fixes the Enter-PSHostProcess and Get-PSHostProcessInfo cmdlets so that they will ignore processes that have already exited. PR Context .NET GetProcess method sometimes returns p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 811f50b757204c6a1b4da0ea780075b3e1cc9e57 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width