Title: Add a couple fixes to generic method invocation by daxian-dbw · Pull Request #16822 · PowerShell/PowerShell · GitHub
Open Graph Title: Add a couple fixes to generic method invocation by daxian-dbw · Pull Request #16822 · PowerShell/PowerShell
X Title: Add a couple fixes to generic method invocation by daxian-dbw · Pull Request #16822 · PowerShell/PowerShell
Description: PR Summary Fix #16809 Follow up on #12412 Add a couple fixes to generic method invocation: For a generic type argument, if it doesn't exist at compilation time but available at run time, it should work as expected. For a generic type argument, if it doesn't exist at all, we should report error about which type name cannot be resolved. Make sure the tests actually run and fix all the tests. @vexx32 It turns out the tests you added didn't run at all because of this: PowerShell/test/powershell/Language/Parser/MethodInvocation.Tests.ps1 Lines 3 to 5 in 8af0834 if ( $IsCoreCLR ) { return } PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
Open Graph Description: PR Summary Fix #16809 Follow up on #12412 Add a couple fixes to generic method invocation: For a generic type argument, if it doesn't exist at compilation time but available at run time, it sh...
X Description: PR Summary Fix #16809 Follow up on #12412 Add a couple fixes to generic method invocation: For a generic type argument, if it doesn't exist at compilation time but available at run time, i...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/16822
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0df11b27-aaba-56a3-eb75-ce29c0647345 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9AA:3AA5E2:77E8F5:A4C799:6A554BAE |
| html-safe-nonce | 4fbbbe490c13851f08e2160ae1aaf19e2e9276d81001f484df95984650291c5c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUFBOjNBQTVFMjo3N0U4RjU6QTRDNzk5OjZBNTU0QkFFIiwidmlzaXRvcl9pZCI6Ijg5MzYwNDQ4MDM5MTUwNzQ0NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 82d06f19969a196b57a91e151ef63cd690e1ffbe916b10e645c2f71418d39600 |
| hovercard-subject-tag | pull_request:836696056 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/16822/files |
| twitter:image | https://avatars.githubusercontent.com/u/127450?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/127450?s=400&v=4 |
| og:image:alt | PR Summary Fix #16809 Follow up on #12412 Add a couple fixes to generic method invocation: For a generic type argument, if it doesn't exist at compilation time but available at run time, it sh... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width