Title: Add lock and null check to remoting internals (#16542) by SergeyZalyadeev · Pull Request #16683 · PowerShell/PowerShell · GitHub
Open Graph Title: Add lock and null check to remoting internals (#16542) by SergeyZalyadeev · Pull Request #16683 · PowerShell/PowerShell
X Title: Add lock and null check to remoting internals (#16542) by SergeyZalyadeev · Pull Request #16683 · PowerShell/PowerShell
Description: PR Summary Lock and null check of the PrioritySendDataCollection.cs members to avoid race condition. PR Context Copy-Item cmdlet can throw unhandled exception that terminates the process. The issue occures in WSManTransportManager internals. The PrioritySendDataCollection class is used by 2 threads: first thread calls ReadOrRegisterCallback method, that gets _dataToBeSent field, when second thread calls Clear method, where _dataToBeSent member is disposed. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Issue filed: Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Issue filed: Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Issue filed: Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors). Issue filed:
Open Graph Description: PR Summary Lock and null check of the PrioritySendDataCollection.cs members to avoid race condition. PR Context Copy-Item cmdlet can throw unhandled exception that terminates the process. The issue...
X Description: PR Summary Lock and null check of the PrioritySendDataCollection.cs members to avoid race condition. PR Context Copy-Item cmdlet can throw unhandled exception that terminates the process. The issue...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/16683
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:569bc74e-717b-bd79-c91b-2d2f6948cbd9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5C0:278A53:6F766D:97C503:6A5548D5 |
| html-safe-nonce | 517663cc853c37919614b3322e04c25ca929a74918e6eeb20a23fc68aed25ef1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUMwOjI3OEE1Mzo2Rjc2NkQ6OTdDNTAzOjZBNTU0OEQ1IiwidmlzaXRvcl9pZCI6IjEzNzc5Njc3NTUzNjI2NTAzMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cd2c720e9dda25170e542a79e432d643a5a0820a79f6ab9dc971cbaeed5aeeaf |
| hovercard-subject-tag | pull_request:812156884 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/16683/files |
| twitter:image | https://avatars.githubusercontent.com/u/475988?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/475988?s=400&v=4 |
| og:image:alt | PR Summary Lock and null check of the PrioritySendDataCollection.cs members to avoid race condition. PR Context Copy-Item cmdlet can throw unhandled exception that terminates the process. The issue... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width