Title: Fix IPC default named pipe clean up on exit by PaulHigin · Pull Request #12187 · PowerShell/PowerShell · GitHub
Open Graph Title: Fix IPC default named pipe clean up on exit by PaulHigin · Pull Request #12187 · PowerShell/PowerShell
X Title: Fix IPC default named pipe clean up on exit by PaulHigin · Pull Request #12187 · PowerShell/PowerShell
Description: PR Summary This PR addresses #11599. On Linux platforms, the default named pipe file was not getting cleaned up on PowerShell exit. PR Context Windows PowerShell uses the CLR Appdomain unload event to dispose the NamedPipeServerStream object on exit, but that does not work with .NET core runtime. This was not a problem on Windows platforms because the Windows OS releases all process resources on process exit, including named pipes. Fix is to change this to use the CLR 'ProcessExit' event. Note that this only works when PowerShell exits normally, i.e., via the 'exit' command. If the console or terminal window is closed then the CLR cannot fire the event. PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Open Graph Description: PR Summary This PR addresses #11599. On Linux platforms, the default named pipe file was not getting cleaned up on PowerShell exit. PR Context Windows PowerShell uses the CLR Appdomain unload even...
X Description: PR Summary This PR addresses #11599. On Linux platforms, the default named pipe file was not getting cleaned up on PowerShell exit. PR Context Windows PowerShell uses the CLR Appdomain unload even...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/12187
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ed84df78-fbe1-6ad3-a46b-b72e7398fb75 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE66:1F8816:36CDDD9:48F185D:6A655AA7 |
| html-safe-nonce | 95d28e86b4eb7490440505e37762696e0bb31b47e34f1a999537384ac6145bc6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTY2OjFGODgxNjozNkNEREQ5OjQ4RjE4NUQ6NkE2NTVBQTciLCJ2aXNpdG9yX2lkIjoiMzQwNjQzNjg4ODkyODkzNDU2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 61a2673af3f86d91131f91c874f99b1e3754b9ec7143455e55b943d7ca0d7ec2 |
| hovercard-subject-tag | pull_request:392688546 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/12187/files/11c361da6be86c612603836adc56029e680e3972 |
| twitter:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14019529?s=400&v=4 |
| og:image:alt | PR Summary This PR addresses #11599. On Linux platforms, the default named pipe file was not getting cleaned up on PowerShell exit. PR Context Windows PowerShell uses the CLR Appdomain unload even... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width