René's URL Explorer Experiment


Title: Update `CmsCommands` to use Store vs cert provider by mikeTWC1984 · Pull Request #11643 · PowerShell/PowerShell · GitHub

Open Graph Title: Update `CmsCommands` to use Store vs cert provider by mikeTWC1984 · Pull Request #11643 · PowerShell/PowerShell

X Title: Update `CmsCommands` to use Store vs cert provider by mikeTWC1984 · Pull Request #11643 · PowerShell/PowerShell

Description: PR Summary This PR replaces cert provider (windows only) with X509Store class to resolve certificate by name/thumbprint on CmsUtils. PR Work items: ResolveFromSubjectName and ResolveFromThumbprint - remove cert: provider call and merge into single method ( both lookups can utilize X509Certificate2Collection.Find ) Remove GetCertEKU (that uses native calls). Use X509Certificate2 Extensions property instead in CertHasOId method. LocalMachine/My store - Windows only replace List<509Certificate2> with X509Certificate2Collection on related methods. Update tests test on Mac add wildcard for subjectname lookup PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary This PR replaces cert provider (windows only) with X509Store class to resolve certificate by name/thumbprint on CmsUtils. PR Work items: ResolveFromSubjectName and ResolveFromThumbprin...

X Description: PR Summary This PR replaces cert provider (windows only) with X509Store class to resolve certificate by name/thumbprint on CmsUtils. PR Work items: ResolveFromSubjectName and ResolveFromThumbprin...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11643

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73f984ca-699d-f153-cada-68ec2b237e02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1CE:1B2B05:2364B0:2FCA63:6AFD4662
html-safe-nonce6ed5a53c1824c4d7f69b7559fe71ec65ade9aa81efc4a3f575a1ef9cb9e5e61f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUNFOjFCMkIwNToyMzY0QjA6MkZDQTYzOjZBRkQ0NjYyIiwidmlzaXRvcl9pZCI6IjY4MjA5MzEzODI4MTMxNzk4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacde231cdca7ab259f7d92f3e07c580fc3f400ddd19723d84bc34bdf047664ad6d
hovercard-subject-tagpull_request:365427902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11643/files
twitter:imagehttps://avatars.githubusercontent.com/u/31977106?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31977106?s=400&v=4
og:image:altPR Summary This PR replaces cert provider (windows only) with X509Store class to resolve certificate by name/thumbprint on CmsUtils. PR Work items: ResolveFromSubjectName and ResolveFromThumbprin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11643/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11643%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11643%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11643/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11643/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11643/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Travis Plunk (TravisEz13)https://github.com/TravisEz13
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
mikeTWC1984:masterhttps://github.com/mikeTWC1984/PowerShell-1/tree/master
Conversation 67 https://github.com/PowerShell/PowerShell/pull/11643
Commits 25 https://github.com/PowerShell/PowerShell/pull/11643/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11643/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11643/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11643/files
Update CmsCommands to use Store vs cert provider https://github.com/PowerShell/PowerShell/pull/11643/files#top
Show all changes 25 commits https://github.com/PowerShell/PowerShell/pull/11643/files
8bd284e updated CmsCommands to use Store vs cert provider Jan 21, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/8bd284e467ffd91c8f9c9de7f71ec57401744828
be31050 cmscommands fixed x509collection type Jan 21, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/be3105066046d3c2db1990db156a69b4ddc56c63
52e1679 codacity fix 1 Jan 21, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/52e1679eccd57b23f7ba0e44f974c880e22303ed
164a0dd removed GetCertEKU, getting EKUs from cert directly Jan 23, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/164a0dd71ba39ca64a18d08272ed83152a16bf1d
d020ca9 added Cms commands to Unix modules Jan 23, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/d020ca9f08470b59e43c3cee76f47fff2874ea70
7124b18 removed break from CertHasOid Jan 23, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/7124b18d02b10d9ed69d5afaaa8057189d765877
c9fe59d checking if this is failing pester on linux mikeTWC1984 Jan 24, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/c9fe59d25b69402a0aac9e6e080fb4b05c6bc7c9
9da7f8e updated CertHasOid and DefaultCommandsTests Jan 24, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/9da7f8ecb79c4a5e1df3bb0f14e1fd7e26c9a530
931538b added new test for CMS commands Jan 28, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/931538b9cd7a6281da66b3d51667e816f6275ecf
f076dcc codacity fix Jan 28, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/f076dcca432f7acf3fe915fb7f45b5dd6e97e119
a3a4b25 removing test mikeTWC1984 Jan 29, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/a3a4b259f80e50fd504b988780e06f8ff7f0f405
08b57a8 refactor test file Jan 29, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/08b57a8a7644c1187646ed0468fac55e200651b6
205544e added wildcard for subj name Jan 29, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/205544e655c0aeca5d82ea69cb98a934823b4e5a
8705eef updated test mikeTWC1984 Feb 1, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/8705eef85ad37cd82d5a0ee7c49fc7a7df3525c4
ccd717f sometest fix Feb 1, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/ccd717f741dc387a00a7241979bbe344e0e237c5
7d9b179 mac test update mikeTWC1984 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/7d9b179a7c908e464cf5e46434c082884a267f83
9a36db1 test - certgen fix mikeTWC1984 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/9a36db198ad89a34f4972d0baf639ddf91f36409
2c0ac81 test - certgen fix2 mikeTWC1984 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/2c0ac81642144f952cda39cc2e354351fccc862c
514a9e8 add findBySubjectName search + codacity fix mikeTWC1984 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/514a9e81f6b908a6af3e5df892bae8c00d4a085c
f00595f codacity fix2 mikeTWC1984 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/f00595fec17525061255cae46fb0d684e6ef827c
9f3baa0 code review refactor1 Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/9f3baa05f9d289c48309e68f3ac15e7a4717706a
3b6ad33 review refact2 + go back to foreach Feb 4, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/3b6ad33d6b3bed0183dabe94a31a0f0312620fdb
a7b19d9 merge remote-tracking branch 'upstream/master' Feb 5, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/a7b19d9754e4e014b55a709634738ae65f0017b1
0c69438 test refactor + added simple name lookup Feb 5, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/0c69438bcac9565f80663dd0335cc7faf599b465
3413394 fixed minor format issues Feb 6, 2020 https://github.com/PowerShell/PowerShell/pull/11643/commits/341339466bc503bfb2f037b3c73944142250bb65
Clear filters https://github.com/PowerShell/PowerShell/pull/11643/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11643/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11643/files
Microsoft.PowerShell.Security.psd1 https://github.com/PowerShell/PowerShell/pull/11643/files#diff-920aee31f7b40f98474eb5d7ea58c89c8af34ef45abd7a50982088e6c1d1964d
SecuritySupport.cs https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
CmsMessage2.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11643/files#diff-aa4383e5d631f69cbb212376ebac8f06dcb8141a647241e56b0ef2f679c1cbd1
DefaultCommands.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11643/files#diff-adf034e44202ea065ef630717c6edd25fa8b7305ddd098cae7b35684368b363a
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/Modules/Unix/Microsoft.PowerShell.Security/Microsoft.PowerShell.Security.psd1https://github.com/PowerShell/PowerShell/pull/11643/files#diff-920aee31f7b40f98474eb5d7ea58c89c8af34ef45abd7a50982088e6c1d1964d
View file https://github.com/mikeTWC1984/PowerShell-1/blob/341339466bc503bfb2f037b3c73944142250bb65/src/Modules/Unix/Microsoft.PowerShell.Security/Microsoft.PowerShell.Security.psd1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11643/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-920aee31f7b40f98474eb5d7ea58c89c8af34ef45abd7a50982088e6c1d1964d
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-920aee31f7b40f98474eb5d7ea58c89c8af34ef45abd7a50982088e6c1d1964d
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
src/System.Management.Automation/security/SecuritySupport.cshttps://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
View file https://github.com/mikeTWC1984/PowerShell-1/blob/341339466bc503bfb2f037b3c73944142250bb65/src/System.Management.Automation/security/SecuritySupport.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11643/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
https://github.com/PowerShell/PowerShell/pull/11643/files#diff-5fb0dc8cc7630fb96b61695451c901e388500f9f66420e955b1a0e68394f9237
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11643/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.