René's URL Explorer Experiment


Title: Format-Hex - Fix Grouping Behaviour with Boolean values by vexx32 · Pull Request #11587 · PowerShell/PowerShell · GitHub

Open Graph Title: Format-Hex - Fix Grouping Behaviour with Boolean values by vexx32 · Pull Request #11587 · PowerShell/PowerShell

X Title: Format-Hex - Fix Grouping Behaviour with Boolean values by vexx32 · Pull Request #11587 · PowerShell/PowerShell

Description: PR Summary We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush the input buffer when the incoming object is a different type than anything we have buffered. This PR also contains a commit which cuts down the visual representation of booleans to 1 byte. Marshal.SizeOf() actually returns 4 for boolean values, since .NET pads Boolean values apparently to make them easier to compare with on modern processors which tend to be optimized for 32 or 64 bit values. See this SO question for reference. I modified some of the logic to skip checking the size if the input value is Boolean, and simply represent it with an 0x1 or 0x0 byte to keep the representation as effective as possible. PR Context Resolves #11585 /cc Steve Lee (@SteveL-MSFT) Ilya (@iSazonov) PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Open Graph Description: PR Summary We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush...

X Description: PR Summary We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush...

Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c6cfb867-a1ba-af2d-a2dc-f726fb79dacf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC016:3483E8:253052:327420:6AFD468E
html-safe-nonce33fc71b62308fc882aec368b7025f4c6ccd8ab4857525447f1c81d8948690ca3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDE2OjM0ODNFODoyNTMwNTI6MzI3NDIwOjZBRkQ0NjhFIiwidmlzaXRvcl9pZCI6IjkxODY3MzkyMTg5MDUxMjI0NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac51417c0864e42be3b78bc57f292e53f843eb9876c16f49d687a40517a954905d
hovercard-subject-tagpull_request:362955471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11587/files
twitter:imagehttps://avatars.githubusercontent.com/u/32407840?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/32407840?s=400&v=4
og:image:altPR Summary We were not flushing the input buffer immediately when a different type is encountered. This caused some odd behaviour when piping in a mix of bools and ints. Fix is to immediately flush...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git
octolytics-dimension-user_id11524380
octolytics-dimension-user_loginPowerShell
octolytics-dimension-repository_id49609581
octolytics-dimension-repository_nwoPowerShell/PowerShell
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id49609581
octolytics-dimension-repository_network_root_nwoPowerShell/PowerShell
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/PowerShell/PowerShell/pull/11587/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11587%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fpull%2F11587%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=PowerShell%2FPowerShell
Reloadhttps://github.com/PowerShell/PowerShell/pull/11587/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11587/files
Reloadhttps://github.com/PowerShell/PowerShell/pull/11587/files
PowerShellhttps://github.com/PowerShell
PowerShellhttps://github.com/PowerShell/PowerShell
Codehttps://github.com/PowerShell/PowerShell
Issues1.3k (1.3k)https://github.com/PowerShell/PowerShell/issues
Pull requests365 (365)https://github.com/PowerShell/PowerShell/pulls
Discussionshttps://github.com/PowerShell/PowerShell/discussions
Actionshttps://github.com/PowerShell/PowerShell/actions
Projectshttps://github.com/PowerShell/PowerShell/projects
Security and quality3 (3)https://github.com/PowerShell/PowerShell/security
Insightshttps://github.com/PowerShell/PowerShell/insights
Sign up for GitHub https://github.com/signup?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FPowerShell%2FPowerShell%2Fissues%2Fnew%2Fchoose
Ilya (iSazonov)https://github.com/iSazonov
PowerShell:masterhttps://github.com/PowerShell/PowerShell/tree/master
vexx32:FormatHex/FixGroupinghttps://github.com/vexx32/PowerShell/tree/FormatHex/FixGrouping
Conversation 23 https://github.com/PowerShell/PowerShell/pull/11587
Commits 2 https://github.com/PowerShell/PowerShell/pull/11587/commits
Checks 0 https://github.com/PowerShell/PowerShell/pull/11587/checks
Files changed https://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Format-Hex - Fix Grouping Behaviour with Boolean values https://github.com/PowerShell/PowerShell/pull/11587/files#top
Show all changes 2 commits https://github.com/PowerShell/PowerShell/pull/11587/files
7279970 :bug: Resolve issue with grouping bools & ints vexx32 Jan 15, 2020 https://github.com/PowerShell/PowerShell/pull/11587/commits/72799706e9477b70a86710fa1a51a75b48a783cf
904bdeb :white_check_mark: Add regression tests vexx32 Jan 15, 2020 https://github.com/PowerShell/PowerShell/pull/11587/commits/904bdeb92549656548046292e7b7f1c2f2d2c07a
Clear filters https://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Format-Hex.cs https://github.com/PowerShell/PowerShell/pull/11587/files#diff-59d7905db8c7f76204d6de9960824b0b7011a72f76b70b14a7623b78c5382605
Format-Hex.Tests.ps1 https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
...oft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cshttps://github.com/PowerShell/PowerShell/pull/11587/files#diff-59d7905db8c7f76204d6de9960824b0b7011a72f76b70b14a7623b78c5382605
View file https://github.com/vexx32/PowerShell/blob/904bdeb92549656548046292e7b7f1c2f2d2c07a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11587/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-59d7905db8c7f76204d6de9960824b0b7011a72f76b70b14a7623b78c5382605
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
Please reload this pagehttps://github.com/PowerShell/PowerShell/pull/11587/files
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-59d7905db8c7f76204d6de9960824b0b7011a72f76b70b14a7623b78c5382605
https://github.com/PowerShell/PowerShell/blob/master/.github/CODEOWNERS#L7
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Hex.Tests.ps1https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
View file https://github.com/vexx32/PowerShell/blob/904bdeb92549656548046292e7b7f1c2f2d2c07a/test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Hex.Tests.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/PowerShell/PowerShell/pull/11587/{{ revealButtonHref }}
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com/PowerShell/PowerShell/pull/11587/files#diff-a18685d648cd60ac2ca8e4fb4a102347e5bbfe60ece1aecebdb2c4151d2e34ff
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.