Title: Use ISOWeek for week numbers in Get-Date by paalbra · Pull Request #11536 · PowerShell/PowerShell · GitHub
Open Graph Title: Use ISOWeek for week numbers in Get-Date by paalbra · Pull Request #11536 · PowerShell/PowerShell
X Title: Use ISOWeek for week numbers in Get-Date by paalbra · Pull Request #11536 · PowerShell/PowerShell
Description: PR Summary In #6542 we had to use a workaround to get a week of the year because .Net Core did not support the feature. As result Get-Date -UFormat "%V" returns wrong week numbers around new year in some cases mentioned in issue #11534 . Now we have ISOWeek API in .Net Core 3.1. The PR removes our workaround and utilizes new ISOWeek.GetWeekOfYear() method. PR Context This PR fixes #11534 . PR Checklist PR has a meaningful title Use the present tense and imperative mood when describing your changes Summarized changes Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header This PR is ready to merge and is not Work in Progress. If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready. Breaking changes None OR Experimental feature(s) needed Experimental feature name(s): User-facing changes Not Applicable OR Documentation needed Issue filed: Testing - New and feature N/A or can only be tested interactively OR Make sure you've added a new test if existing tests do not effectively test the code changed Tooling I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. OR I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host). Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions). Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Open Graph Description: PR Summary In #6542 we had to use a workaround to get a week of the year because .Net Core did not support the feature. As result Get-Date -UFormat "%V" returns wrong week numbers around ...
X Description: PR Summary In #6542 we had to use a workaround to get a week of the year because .Net Core did not support the feature. As result Get-Date -UFormat "%V" returns wrong week numbers...
Opengraph URL: https://github.com/PowerShell/PowerShell/pull/11536
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0b8b0a81-7ece-a7fb-3e44-e385c271e1c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9488:3E6ECA:18F1F9:21B970:6A5534F5 |
| html-safe-nonce | 94049d88840af4857de429411948d99a848232aa92725bb9a3714dc4c9c79a2e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDg4OjNFNkVDQToxOEYxRjk6MjFCOTcwOjZBNTUzNEY1IiwidmlzaXRvcl9pZCI6IjIwMTA4ODU5MTI5MDE1MzA4NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 83c389945825624a5b435107fb857dbdbb21ac0259c6c9f4b2e1c5540ef62974 |
| hovercard-subject-tag | pull_request:360981550 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/PowerShell/PowerShell/pull/11536/files |
| twitter:image | https://avatars.githubusercontent.com/u/265215?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/265215?s=400&v=4 |
| og:image:alt | PR Summary In #6542 we had to use a workaround to get a week of the year because .Net Core did not support the feature. As result Get-Date -UFormat "%V" returns wrong week numbers around ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/PowerShell/PowerShell git https://github.com/PowerShell/PowerShell.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 49609581 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShell |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 49609581 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShell |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 811f50b757204c6a1b4da0ea780075b3e1cc9e57 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width